chore(sync): cascade main -> dev #212

Merged

jmiller merged 2 commits from main into dev 2026-07-05 23:03:59 +00:00

Conversation 0 Commits 2 Files Changed 2

+3 -3

jmiller commented 2026-07-05 21:33:54 +00:00

Owner

Copy Link

Copy Source

Automated cascade of main into dev. Auto-merges only if conflict-free; otherwise left open for manual resolution.

Automated cascade of main into dev. Auto-merges only if conflict-free; otherwise left open for manual resolution.

jmiller added 36 commits 2026-07-05 21:33:55 +00:00

chore: remove stray root services/provider.php ... c12d207a96

The canonical webservices provider lives in
source/packages/plg_webservices_mokosuitebackup/services/provider.php.
This root-level copy is an orphaned duplicate — nothing references it and
it is not part of any packaged extension. Recovered from a stash of
previously-set-aside cleanup.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.55.03-dev [skip ci] 5363a85b92

Merge pull request 'chore: remove stray root services/provider.php' (#207) from chore/remove-stray-provider into main 939964bff9

chore(release): build 02.56.00 [skip ci] 6074aa55ae

chore: promote changelog [Unreleased] → [02.56.00] 1dde736225

chore: sync issue-branch.yml from Template-Generic [skip ci] d0ce09abf0

fix(profile): remote destinations tab broken — lazy-init Bootstrap modal ... 4ca9e23630

The remote destinations table stayed stuck at "Loading…" and the "Add
Destination" button did nothing. Root cause: the profile-edit DOMContentLoaded
handler instantiated the Bootstrap modal eagerly at the top
(`bootstrap.Modal.getOrCreateInstance`). In Joomla 6, Bootstrap loads as a
deferred ES module, so `bootstrap` is undefined at DOMContentLoaded — the
reference threw a ReferenceError that aborted the entire handler, so
loadRemotes() never ran and the Add button was never bound. (The purge and
stepped-backup modals worked because they resolve the modal lazily inside
click handlers.)

- Resolve the modal lazily via getModal() at click-time (matches the working modals)
- Explicitly load the bootstrap.modal web asset so window.bootstrap.Modal is registered

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Merge pull request 'fix: remote destinations tab broken (Add Destination + stuck loading)' (#208) from fix/remote-destinations-modal into main 183b2d2d6f

chore(release): build 02.56.00 [skip ci] a7611d17d9

chore: promote changelog [Unreleased] → [02.56.00] e37a52df4e

chore: sync auto-release.yml from Template-Generic [skip ci] 0926e82465

fix(sql): purge stranded legacy remote-storage columns (MySQL 8 safe) ... 6a62868881

02.52.25.sql used `DROP COLUMN IF EXISTS` (MariaDB-only), which errors on
Oracle MySQL 8.x — so on MySQL 8 installs the 26 legacy remote_storage/ftp_*/
sftp_*/gdrive_*/s3_* columns were never dropped, yet Joomla recorded the schema
as applied (confirmed on suite.dev: MySQL 8.0.41, all 26 columns still present,
0 profiles with legacy remote data).

New 02.56.01 migration removes them portably: an INFORMATION_SCHEMA-gated
prepared-statement ALTER that drops all 26 columns where present (plain
DROP COLUMN, valid on MySQL 8 + MariaDB) and is a no-op where already gone
(so it's safe on already-migrated installs too). Validated non-destructively
against suite.dev (gate=1, ALTER PREPAREs cleanly).

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.56.05-dev [skip ci] c7a57116a7

Merge pull request 'fix(sql): purge stranded legacy remote-storage columns (MySQL 8 safe)' (#210) from fix/purge-legacy-remote-columns into main 2a7fb74ef9

chore(release): build 02.56.05 [skip ci] 8e3e473426

chore: promote changelog [Unreleased] → [02.56.05] ee293e8038

chore: sync cleanup.yml from Template-Generic [skip ci] 1c643b097f

chore: sync issue-branch.yml from Template-Generic [skip ci] b2770df80f

chore: sync notify.yml from Template-Generic [skip ci] d780e10a2f

chore: sync auto-bump.yml from Template-Generic [skip ci] b2d35bc9b3

chore: sync auto-release.yml from Template-Generic [skip ci] 6e66de4c65

chore: sync branch-cleanup.yml from Template-Generic [skip ci] b38ddb5b62

chore: sync cascade-dev.yml from Template-Generic [skip ci] cd721d450e

chore: sync ci-issue-reporter.yml from Template-Generic [skip ci] af215482bd

chore: sync gitleaks.yml from Template-Generic [skip ci] f4b6e23d58

chore: sync pr-check.yml from Template-Generic [skip ci] 478adfcde8

chore: sync pre-release.yml from Template-Generic [skip ci] 26121e3628

chore: sync rc-revert.yml from Template-Generic [skip ci] 4740a09d79

chore: sync repo-health.yml from Template-Generic [skip ci] 4ab9ab3806

chore: sync sync-on-merge.yml from Template-Generic [skip ci] 8ac3bedff3

chore: sync version-set.yml from Template-Generic [skip ci] bcb4368bd1

chore: sync pr-check.yml from Template-Generic [skip ci] 11b0ea3c21

chore: sync workflow-sync-trigger.yml from Template-Generic [skip ci] 75bbb55e29

fix: security + data-integrity fixes (P0/P1) ... 99b844e04a

Security (P0):
- #169 mask FTP password in AjaxController maskSecrets()/mergeExistingSecrets()
- #187 stop leaking absolute_path in API item view (JsonapiView)
- #182 SftpUploader StrictHostKeyChecking=no -> accept-new (MITM)

Data integrity / correctness (P1):
- #179 DatabaseDumper: real newline after DROP TABLE (was literal backslash-n)
- #180 profile-picker forms ORDER BY id (the 'ordering' column is dropped on
  upgraded sites, breaking the query) — run_profile.xml + plg_content xml
- #181 uninstall.mysql.sql: add missing DROP for snapshots table
- #184 CLI snapshot delete uses data_file column (file_path does not exist,
  so snapshot files were never deleted)
- #186 remove duplicate pre-update backup: content plugin no longer subscribes
  to onExtensionBeforeUpdate (owned by the system plugin); keeps pre-install
- #188 DatabaseImporter now collects non-fatal statement errors
  (getErrors()/hasErrors()) so restores are no longer silent and callers can
  surface a warning status

Also folds in the .mokogitea/CLAUDE.md mokoplatform -> mokocli fix (stale repo
name after the rename).

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.56.07-dev [skip ci] 6ab31c12be

Merge pull request 'fix: security + data-integrity fixes (P0/P1)' (#211) from fix/security-integrity-p0p1 into main f4bc1d128c

jmiller added 1 commit 2026-07-05 21:34:08 +00:00

chore(release): build 02.56.07 [skip ci] 24d7dc0064

jmiller added 1 commit 2026-07-05 21:34:20 +00:00

chore: promote changelog [Unreleased] → [02.56.07] 1f7c2ef1ba

jmiller added 1 commit 2026-07-05 21:49:09 +00:00

chore: sync auto-bump.yml from Template-Generic [skip ci] d69db6fac3

jmiller added 1 commit 2026-07-05 21:49:10 +00:00

chore: sync auto-release.yml from Template-Generic [skip ci] f9169fd9f7

jmiller added 1 commit 2026-07-05 21:49:13 +00:00

chore: sync branch-cleanup.yml from Template-Generic [skip ci] 60c5c00333

jmiller added 1 commit 2026-07-05 21:49:18 +00:00

chore: sync ci-generic.yml from Template-Generic [skip ci] 68043c9a37

jmiller added 1 commit 2026-07-05 21:49:22 +00:00

chore: sync cleanup.yml from Template-Generic [skip ci] 4cf8f8243d

jmiller added 1 commit 2026-07-05 21:49:25 +00:00

chore: sync gitleaks.yml from Template-Generic [skip ci] cc7f18ae45

jmiller added 1 commit 2026-07-05 21:49:26 +00:00

chore: sync issue-branch.yml from Template-Generic [skip ci] 7a3f0f914e

jmiller added 1 commit 2026-07-05 21:49:30 +00:00

chore: sync notify.yml from Template-Generic [skip ci] c0792a6ba0

jmiller added 1 commit 2026-07-05 21:49:31 +00:00

chore: sync pr-check.yml from Template-Generic [skip ci] a5397c0f16

jmiller added 1 commit 2026-07-05 21:49:34 +00:00

chore: sync pre-release.yml from Template-Generic [skip ci] 55f29498b0

jmiller added 1 commit 2026-07-05 21:49:37 +00:00

chore: sync rc-revert.yml from Template-Generic [skip ci] 2389df8670

jmiller added 1 commit 2026-07-05 21:49:41 +00:00

chore: sync repo-health.yml from Template-Generic [skip ci] d2cc234fce

jmiller added 1 commit 2026-07-05 21:49:42 +00:00

chore: sync version-set.yml from Template-Generic [skip ci] 351321161a

jmiller added 1 commit 2026-07-05 21:49:45 +00:00

chore: sync workflow-sync-trigger.yml from Template-Generic [skip ci] 0c7c3552ed

jmiller added 3 commits 2026-07-05 22:01:22 +00:00

fix(manifest): component <name> must be element-safe (com_mokosuitebackup) ... 9db54ac60c

The "Type - Name" convention (commit d155958) set the component <name> to
"Component - MokoSuiteBackup". Joomla derives a component's element from its
<name> (com_ + sanitized name), so this produced element
`com_component-mokosuitebackup` instead of `com_mokosuitebackup`. On update,
Joomla registered a NEW component (new element + folder) at the current
version and orphaned the real `com_mokosuitebackup` at its old version — which
is what `?option=com_mokosuitebackup` and the admin menu still load. Net
effect: the component appears "stuck" on the old version with the old UI.

Revert the component <name> to "MokoSuiteBackup" (-> com_mokosuitebackup) and
document why the display convention must not be applied to a component's
<name>. Packages are exempt (they use <packagename>); plugins/modules are
exempt (<name> is only a display label there).

Refs #171-area remote tab reports; fixes the duplicate-component registration.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.56.08-dev [skip ci] f92e5227dc

Merge pull request 'fix(manifest): component &lt;name&gt; must be element-safe (com_mokosuitebackup)' (#213) from fix/component-element-name into main 3c5ad43e97

jmiller added 1 commit 2026-07-05 22:01:51 +00:00

chore(release): build 02.56.08 [skip ci] 4a2bb1b19d

jmiller added 1 commit 2026-07-05 22:02:17 +00:00

chore: promote changelog [Unreleased] → [02.56.08] ec3094385f

jmiller added 3 commits 2026-07-05 22:23:11 +00:00

fix(installer): self-heal orphaned com_component-mokosuitebackup on update ... 1029e40908

The old "Type - Name" component <name> made Joomla register a duplicate
component under element com_component-mokosuitebackup (its own extension row,
admin menu, schema rows and administrator/ folder), orphaning the real
com_mokosuitebackup on the old version. The manifest fix (#213) prevents new
occurrences; this reconciles already-affected sites automatically.

Package postflight now removes any component whose element matches
%component%mokosuitebackup% (excluding com_mokosuitebackup): deletes its
#__menu, #__schemas and #__update_sites_extensions rows, the #__extensions
record, and the stray admin folder. Idempotent and non-fatal.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.56.11-dev [skip ci] 39d94a31d6

Merge pull request 'fix(installer): self-heal orphaned com_component-mokosuitebackup on update' (#216) from fix/orphan-component-cleanup into main 2688ea352b

jmiller added 1 commit 2026-07-05 22:23:28 +00:00

chore(release): build 02.56.11 [skip ci] 0cba7f81e8

jmiller added 1 commit 2026-07-05 22:23:37 +00:00

chore: promote changelog [Unreleased] → [02.56.11] bcc4054ced

jmiller added 2 commits 2026-07-05 22:26:21 +00:00

docs(changelog): backfill 02.56.07/08 + dedupe blank duplicate headers ... 8bdadb68c2

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Merge pull request 'docs(changelog): backfill 02.56.07 + 02.56.08 (shipped with empty changelogs)' (#215) from fix/changelog-backfill into main 14392de078

jmiller added 2 commits 2026-07-05 22:28:22 +00:00

fix(release): idempotent changelog promote + dedupe 02.56.11 header ... 129be7ef9d

Guard the promote so it only inserts a version header when absent (stops the
empty duplicate headers each build was appending), and remove the duplicate
02.56.11 header the non-idempotent promote just created.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Merge pull request 'fix(release): idempotent changelog promote (no duplicate version headers)' (#217) from fix/changelog-promote-idempotent into main 7f5f041588

jmiller added 3 commits 2026-07-05 22:29:43 +00:00

feat: BackupRunner helper — unify backup run/status/notification ... 307067580c

Every non-interactive backup trigger used a slightly different path, so
final status and notification gating behaved inconsistently depending on
what started the backup (this is why pre-update backups did not gate
notifications the way "Backup Now" does).

Add src/Service/BackupRunner.php as the single synchronous entry point.
It delegates to BackupEngine (which already sends notifications gated by
the profile's notify_on_success/notify_on_failure and applies retention —
so there is exactly ONE notification layer), and normalises the result,
including the real complete/warning/fail status the engine records but did
not return. BackupRunner self-loads BackupEngine so callers require one file.

Routed through BackupRunner:
- plg_system  runPreActionBackup() (preaction) + web-cron handler (webcron)
- plg_content triggerAutoBackup() (pre-install)
- plg_task    scheduled task run
- plg_console RunCommand (cli)

The dashboard AJAX/stepped "Backup Now" flow is unchanged (it is the
interactive equivalent). The installer progress popup is deferred — the
installer request cannot drive the AJAX modal (TODO(#196) noted in code).

php -l clean on all changed files.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

docs(changelog): add BackupRunner entry (#214) ... 28ca110d7b

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Merge pull request 'feat: BackupRunner helper — unify backup run/status/notification' (#214) from feat/backup-runner-helper into main 99d8e954bd

jmiller added 1 commit 2026-07-05 22:30:36 +00:00

chore(release): build 02.57.00 [skip ci] ea91b49e50

jmiller added 2 commits 2026-07-05 22:50:56 +00:00

chore(docs): normalize refs — MokoStandards->org wiki, moko-platform->mokocli, residual MokoGitea/MokoSuite ... 94ff15c128

Non-workflow docs/config only (CLAUDE.md, README, branch-protection, ISSUE_TEMPLATE/config.yml,
ci-issue-reporter). Workflow files, manifest schema, and Makefile install paths left for the
forge-rebrand gate. Authored-by: Moko Consulting

Merge chore/normalize-docs: normalize doc/config refs 604412f82f

jmiller scheduled this pull request to auto merge when all checks succeed 2026-07-05 23:03:56 +00:00

jmiller merged commit 4f91d1e432 into dev 2026-07-05 23:03:59 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

component: admin

Admin UI and views

component: api

REST API

component: engine

Backup/restore engine

component: remote

Remote storage (FTP/GDrive)

component: scheduler

Scheduled tasks

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#212