fix: ORDER BY ordering ASC on profiles table after column was dropped #180

New Issue

2026-06-29T14:39:39Z

jmiller commented

2026-06-29 14:39:39 +00:00

Summary

Migration 01.43.33.sql dropped the ordering column from #__mokosuitebackup_profiles. Two plugin form XMLs still reference it, causing SQL errors:

plg_content_mokosuitebackup/mokosuitebackup.xml:62 — ORDER BY ordering ASC
plg_task_mokosuitebackup/forms/run_profile.xml:14 — ORDER BY ordering ASC

Severity

Critical — breaks profile dropdown rendering in content plugin config and scheduled task creation/editing.

Impact

Content plugin: profile dropdown fails when rendering config
Task plugin: profile dropdown fails when creating/editing scheduled tasks

Fix

Change ORDER BY ordering ASC to ORDER BY id ASC (or title ASC) in both files.

## Summary Migration `01.43.33.sql` dropped the `ordering` column from `#__mokosuitebackup_profiles`. Two plugin form XMLs still reference it, causing SQL errors: 1. `plg_content_mokosuitebackup/mokosuitebackup.xml:62` — `ORDER BY ordering ASC` 2. `plg_task_mokosuitebackup/forms/run_profile.xml:14` — `ORDER BY ordering ASC` ## Severity **Critical** — breaks profile dropdown rendering in content plugin config and scheduled task creation/editing. ## Impact - Content plugin: profile dropdown fails when rendering config - Task plugin: profile dropdown fails when creating/editing scheduled tasks ## Fix Change `ORDER BY ordering ASC` to `ORDER BY id ASC` (or `title ASC`) in both files.

jmiller commented

2026-06-29 14:39:43 +00:00

Branch created: feature/180-fix-order-by-ordering-asc-on-profiles-ta

git fetch origin
git checkout feature/180-fix-order-by-ordering-asc-on-profiles-ta

Branch created: [`feature/180-fix-order-by-ordering-asc-on-profiles-ta`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteBackup/src/branch/feature/180-fix-order-by-ordering-asc-on-profiles-ta) ```bash git fetch origin git checkout feature/180-fix-order-by-ordering-asc-on-profiles-ta ```

jmiller commented

2026-07-05 19:43:00 +00:00

Confirmed in 02.56.05 — keep open.

Both forms still ORDER BY ordering ASC while migration sql/updates/mysql/01.43.33.sql drops that column on upgraded sites:

plg_task_mokosuitebackup/forms/run_profile.xml:14
plg_content_mokosuitebackup/mokosuitebackup.xml:62

Fix: change to ORDER BY id ASC.

Additional inconsistency worth fixing together: install.mysql.sql:91 still defines ordering INT(11) in the profiles CREATE, so a fresh install still has the column and masks the bug — only upgraded sites (past 01.43.33) hit it. Recommend removing ordering from install.mysql.sql as well so fresh and upgraded schemas match.

Confirmed in 02.56.05 — keep open. Both forms still `ORDER BY ordering ASC` while migration `sql/updates/mysql/01.43.33.sql` drops that column on upgraded sites: - `plg_task_mokosuitebackup/forms/run_profile.xml:14` - `plg_content_mokosuitebackup/mokosuitebackup.xml:62` Fix: change to `ORDER BY id ASC`. **Additional inconsistency worth fixing together:** `install.mysql.sql:91` still defines `ordering INT(11)` in the profiles CREATE, so a *fresh* install still has the column and masks the bug — only *upgraded* sites (past 01.43.33) hit it. Recommend removing `ordering` from `install.mysql.sql` as well so fresh and upgraded schemas match.

jmiller referenced this issue from a commit

2026-07-05 21:31:27 +00:00

fix: security + data-integrity fixes (P0/P1)

jmiller referenced this issue

2026-07-05 21:31:47 +00:00

fix: security + data-integrity fixes (P0/P1) #211

jmiller referenced this issue from a commit

2026-07-05 21:33:12 +00:00

fix: security + data-integrity fixes (P0/P1)

jmiller referenced this issue

2026-07-05 22:06:17 +00:00

docs(changelog): backfill 02.56.07 + 02.56.08 (shipped with empty changelogs) #215