MokoConsulting/MokoSuiteBackup
1
0
Fork 0
Code Issues 30 Pull Requests 3 Releases 2 Wiki Activity

fix(sql): purge stranded legacy remote-storage columns (MySQL 8 safe) #210

Merged
jmiller merged 2 commits from fix/purge-legacy-remote-columns into main 2026-07-05 00:02:30 +00:00
Conversation 0 Commits 2 Files Changed 15
+46 -13
jmiller commented 2026-07-05 00:02:09 +00:00
Owner
Copy Link
Copy Source

Problem

02.52.25.sql used DROP COLUMN IF EXISTS — a MariaDB-only extension that errors on Oracle MySQL 8.x. On MySQL 8 installs that migration failed, but Joomla still recorded the schema as applied, so the 26 legacy remote_storage/ftp_*/sftp_*/gdrive_*/s3_* columns were left stranded on the profiles table and will never be retried.

Confirmed on suite.dev: MySQL 8.0.41, all 26 columns still present, 0 profiles with legacy remote data.

Fix

New 02.56.01.sql migration removes them portably and idempotently:

  • Gates on INFORMATION_SCHEMA.COLUMNS (presence of remote_storage, which tracks the whole set).
  • Builds an ALTER … DROP COLUMN … (plain drop — valid on both MySQL 8 and MariaDB) via a prepared statement, executed only when the columns exist; otherwise a DO 0 no-op.
  • So it's safe on stuck installs (drops), already-migrated installs (no-op), and fresh installs (columns never existed).

Assimilation into #__mokosuitebackup_remotes was intentionally omitted — no install has legacy remote data (the single-remote UI was removed back in 02.55.00), so there's nothing to migrate; the rows would be empty.

Validation

Ran non-destructively against suite.dev (build + PREPARE the ALTER, then DEALLOCATE without executing): gate returned 1, the ALTER prepared cleanly on MySQL 8.0.41 — nothing was dropped.

Note

suite.dev's schema is recorded at 02.52.29; this file (> 02.52.29) will run on the next extension update. If the schema-update chain is itself stuck there, the columns can also be dropped by running this ALTER directly — say the word and I'll apply it to suite.dev.

## Problem `02.52.25.sql` used `DROP COLUMN IF EXISTS` — a **MariaDB-only** extension that errors on **Oracle MySQL 8.x**. On MySQL 8 installs that migration failed, but Joomla still recorded the schema as applied, so the **26 legacy `remote_storage`/`ftp_*`/`sftp_*`/`gdrive_*`/`s3_*` columns were left stranded** on the profiles table and will never be retried. Confirmed on suite.dev: **MySQL 8.0.41**, all 26 columns still present, **0 profiles with legacy remote data**. ## Fix New `02.56.01.sql` migration removes them **portably and idempotently**: - Gates on `INFORMATION_SCHEMA.COLUMNS` (presence of `remote_storage`, which tracks the whole set). - Builds an `ALTER … DROP COLUMN …` (plain drop — valid on **both** MySQL 8 and MariaDB) via a **prepared statement**, executed only when the columns exist; otherwise a `DO 0` no-op. - So it's safe on stuck installs (drops), already-migrated installs (no-op), and fresh installs (columns never existed). Assimilation into `#__mokosuitebackup_remotes` was intentionally omitted — no install has legacy remote data (the single-remote UI was removed back in 02.55.00), so there's nothing to migrate; the rows would be empty. ## Validation Ran non-destructively against suite.dev (build + `PREPARE` the ALTER, then `DEALLOCATE` **without executing**): gate returned `1`, the ALTER prepared cleanly on MySQL 8.0.41 — nothing was dropped. ## Note suite.dev's schema is recorded at `02.52.29`; this file (`> 02.52.29`) will run on the next extension update. If the schema-update chain is itself stuck there, the columns can also be dropped by running this ALTER directly — say the word and I'll apply it to suite.dev.
jmiller added 1 commit 2026-07-05 00:02:10 +00:00
fix(sql): purge stranded legacy remote-storage columns (MySQL 8 safe)
Universal: PR Check / Branch Policy (pull_request) Successful in 2s
Details
Joomla: Extension CI / Release Readiness Check (pull_request) Failing after 8s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 9s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 34s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 15s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Repo Health / Access control (pull_request) Successful in 2s
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 15s
Details
Universal: Build & Release / Promote to RC (pull_request) Failing after 17s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 1m2s
Details
Joomla: Extension CI / Lint & Validate (pull_request) Failing after 1m6s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Joomla: Extension CI / Tests (PHP 8.2) (pull_request) Has been cancelled
Details
Joomla: Extension CI / Tests (PHP 8.3) (pull_request) Has been cancelled
Details
Joomla: Extension CI / PHPStan Analysis (pull_request) Has been cancelled
Details
Joomla: Extension CI / Build RC Pre-Release (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled
Details
6a62868881 
02.52.25.sql used `DROP COLUMN IF EXISTS` (MariaDB-only), which errors on
Oracle MySQL 8.x — so on MySQL 8 installs the 26 legacy remote_storage/ftp_*/
sftp_*/gdrive_*/s3_* columns were never dropped, yet Joomla recorded the schema
as applied (confirmed on suite.dev: MySQL 8.0.41, all 26 columns still present,
0 profiles with legacy remote data).

New 02.56.01 migration removes them portably: an INFORMATION_SCHEMA-gated
prepared-statement ALTER that drops all 26 columns where present (plain
DROP COLUMN, valid on MySQL 8 + MariaDB) and is a no-op where already gone
(so it's safe on already-migrated installs too). Validated non-destructively
against suite.dev (gate=1, ALTER PREPAREs cleanly).

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
jmiller added 1 commit 2026-07-05 00:02:17 +00:00
chore(version): pre-release bump to 02.56.05-dev [skip ci]
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 3s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Successful in 44s
Details
Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Successful in 9m41s
Details
c7a57116a7
jmiller merged commit 2a7fb74ef9 into main 2026-07-05 00:02:30 +00:00
jmiller deleted branch fix/purge-legacy-remote-columns 2026-07-05 00:02:35 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
component: admin
Admin UI and views
 component: api
REST API
 component: engine
Backup/restore engine
 component: remote
Remote storage (FTP/GDrive)
 component: scheduler
Scheduled tasks
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#210
Delete Branch "fix/purge-legacy-remote-columns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?