fix: DatabaseDumper dumpToFile() double-escapes newline after DROP TABLE #179

New Issue

2026-06-29T14:39:34Z

jmiller commented

2026-06-29 14:39:34 +00:00

Summary

DatabaseDumper.php:329 — fwrite($fp, 'DROP TABLE IF EXISTS \' . $abstractName . "\;\\n");

The double-escaped backslash produces literal \n in the SQL file instead of a newline. This concatenates the DROP TABLE statement with the CREATE TABLE statement, producing invalid SQL on import.

The in-memory dump() method doesn't have this issue — only the streaming dumpToFile() path (used by BackupEngine).

Severity

Critical — corrupts every database backup created via the streaming path.

Location

source/packages/com_mokosuitebackup/src/Engine/DatabaseDumper.php:329

Fix

Change "\\;\n"to"`;\n"` (single-escaped newline).

## Summary `DatabaseDumper.php:329` — `fwrite($fp, 'DROP TABLE IF EXISTS \`' . $abstractName . "\\`;\\n");` The double-escaped backslash produces literal `\n` in the SQL file instead of a newline. This concatenates the DROP TABLE statement with the CREATE TABLE statement, producing invalid SQL on import. The in-memory `dump()` method doesn't have this issue — only the streaming `dumpToFile()` path (used by BackupEngine). ## Severity **Critical** — corrupts every database backup created via the streaming path. ## Location `source/packages/com_mokosuitebackup/src/Engine/DatabaseDumper.php:329` ## Fix Change `"\\`;\\n"` to `"\`;\n"` (single-escaped newline).

jmiller added the component: engine label 2026-06-29 14:39:34 +00:00

jmiller commented

2026-06-29 14:39:38 +00:00

Branch created: feature/179-fix-databasedumper-dumptofile-double-esc

git fetch origin
git checkout feature/179-fix-databasedumper-dumptofile-double-esc

Branch created: [`feature/179-fix-databasedumper-dumptofile-double-esc`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteBackup/src/branch/feature/179-fix-databasedumper-dumptofile-double-esc) ```bash git fetch origin git checkout feature/179-fix-databasedumper-dumptofile-double-esc ```

jmiller commented

2026-07-05 19:42:56 +00:00

Confirmed present in 02.56.05 — keep open.

DatabaseDumper.php:329 writes 'DROP TABLE IF EXISTS \' . $abstractName . "`;\n"— the\n in that double-quoted string emits a literal backslash+n, not a newline. Line 330 correctly uses "\n\n". Fix: change "`;\n"to"`;\n"`.

Confirmed present in 02.56.05 — keep open. `DatabaseDumper.php:329` writes `'DROP TABLE IF EXISTS \`' . $abstractName . "\`;\\n"` — the `\\n` in that double-quoted string emits a literal backslash+`n`, not a newline. Line 330 correctly uses `"\n\n"`. Fix: change `"\`;\\n"` to `"\`;\n"`.

jmiller referenced this issue from a commit

2026-07-05 21:31:27 +00:00

fix: security + data-integrity fixes (P0/P1)

jmiller referenced this issue

2026-07-05 21:31:47 +00:00

fix: security + data-integrity fixes (P0/P1) #211

jmiller referenced this issue from a commit

2026-07-05 21:33:12 +00:00

fix: security + data-integrity fixes (P0/P1)

jmiller referenced this issue

2026-07-05 22:06:17 +00:00

docs(changelog): backfill 02.56.07 + 02.56.08 (shipped with empty changelogs) #215