fix: DatabaseImporter silently continues on SQL execution errors #188

New Issue

2026-06-29T14:41:12Z

jmiller commented

2026-06-29 14:41:12 +00:00

Summary

DatabaseImporter.php catches SQL execution errors in the import loop and logs them but continues to the next statement. A partially-imported database is left in an inconsistent state with no clear indication to the user that the import was incomplete.

Location

source/packages/com_mokosuitebackup/src/Engine/DatabaseImporter.php

Fix

Track error count and report in the final result
Optionally support a "stop on error" mode
At minimum, set the restore status to warning (not complete) if any statements failed

## Summary `DatabaseImporter.php` catches SQL execution errors in the import loop and logs them but continues to the next statement. A partially-imported database is left in an inconsistent state with no clear indication to the user that the import was incomplete. ## Location `source/packages/com_mokosuitebackup/src/Engine/DatabaseImporter.php` ## Fix - Track error count and report in the final result - Optionally support a "stop on error" mode - At minimum, set the restore status to `warning` (not `complete`) if any statements failed

jmiller added the component: engine label 2026-06-29 14:41:12 +00:00

jmiller commented

2026-06-29 14:41:16 +00:00

Branch created: feature/188-fix-databaseimporter-silently-continues-

git fetch origin
git checkout feature/188-fix-databaseimporter-silently-continues-

Branch created: [`feature/188-fix-databaseimporter-silently-continues-`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteBackup/src/branch/feature/188-fix-databaseimporter-silently-continues-) ```bash git fetch origin git checkout feature/188-fix-databaseimporter-silently-continues- ```

jmiller commented

2026-07-05 19:43:04 +00:00

Confirmed in 02.56.05 — keep open.

DatabaseImporter::import() still swallows errors: the catch at DatabaseImporter.php:97-102 (and the tail-statement path at :116-118) only calls error_log(...) and continues. The method returns just $statementsExecuted (:124) with no failure count, no stop-on-error mode, and no way to surface a warning restore status. None of the three requested remediations are implemented.

Confirmed in 02.56.05 — keep open. `DatabaseImporter::import()` still swallows errors: the catch at `DatabaseImporter.php:97-102` (and the tail-statement path at `:116-118`) only calls `error_log(...)` and continues. The method returns just `$statementsExecuted` (`:124`) with no failure count, no stop-on-error mode, and no way to surface a warning restore status. None of the three requested remediations are implemented.

jmiller referenced this issue from a commit

2026-07-05 21:31:27 +00:00

fix: security + data-integrity fixes (P0/P1)

jmiller referenced this issue

2026-07-05 21:31:47 +00:00

fix: security + data-integrity fixes (P0/P1) #211

jmiller referenced this issue from a commit

2026-07-05 21:33:12 +00:00

fix: security + data-integrity fixes (P0/P1)

jmiller referenced this issue

2026-07-05 22:06:17 +00:00

docs(changelog): backfill 02.56.07 + 02.56.08 (shipped with empty changelogs) #215