Merge pull request 'fix(installer): self-heal orphaned com_component-mokosuitebackup on update' (#216) from fix/orphan-component-cleanup into main

.mokogitea/workflows/issue-branch.yml

@@ -5,7 +5,7 @@
 # FILE INFORMATION
 # DEFGROUP: MokoGitea.Workflow
 # INGROUP: mokocli.Automation
-# VERSION: 02.56.08
+# VERSION: 02.56.11
 # BRIEF: Auto-create feature branch when an issue is opened
 
 name: "Universal: Issue Branch"

CHANGELOG.md

@@ -1,6 +1,9 @@
 # Changelog
 ## [Unreleased]
 
+### Fixed
+- Package `postflight` now removes the orphaned `com_component-mokosuitebackup` registration (stray extension record, admin menu items, schema rows, and `administrator/` folder) left behind by the old "Type - Name" component `<name>` — self-healing on update so affected sites reconcile to the real `com_mokosuitebackup`. (#213 follow-up)
+
 ## [02.56.08] --- 2026-07-05
 
 ## [02.56.08] --- 2026-07-05

SECURITY.md

@@ -23,7 +23,7 @@ DEFGROUP: Template-Joomla
 INGROUP: Template-Joomla.Documentation
 REPO: https://git.mokoconsulting.tech/MokoConsulting/Template-Joomla
 PATH: /SECURITY.md
-VERSION: 02.56.08
+VERSION: 02.56.11
 BRIEF: Security vulnerability reporting and handling policy
 -->
 

source/packages/com_mokosuitebackup/mokosuitebackup.xml

@@ -17,7 +17,7 @@
 		display label there.
 	-->
 	<name>MokoSuiteBackup</name>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/com_mokosuitebackup/sql/updates/mysql/02.56.11.sql

@@ -0,0 +1 @@
+/* 02.56.11 — no schema changes */

source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="module" client="administrator" method="upgrade">
 	<name>Module - MokoSuiteBackup - cPanel</name>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-23</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="actionlog" method="upgrade">
 	<name>Action Log - MokoSuiteBackup</name>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="console" method="upgrade">
 	<name>Console - MokoSuiteBackup</name>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="content" method="upgrade">
 	<name>Content - MokoSuiteBackup</name>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <extension type="plugin" group="quickicon" method="upgrade">
 	<name>Quick Icon - MokoSuiteBackup</name>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="system" method="upgrade">
 	<name>System - MokoSuiteBackup</name>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="task" method="upgrade">
 	<name>Task - MokoSuiteBackup</name>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="webservices" method="upgrade">
 	<name>Web Services - MokoSuiteBackup</name>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/pkg_mokosuitebackup.xml

@@ -8,7 +8,7 @@
 <extension type="package" method="upgrade">
 	<name>Package - MokoSuiteBackup</name>
 	<packagename>mokosuitebackup</packagename>
-	<version>02.56.08</version>
+	<version>02.56.11</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/script.php

@@ -172,6 +172,11 @@ class Pkg_MokoSuiteBackupInstallerScript
 		/* Migrate profiles with old default backup_dir values to [DEFAULT_DIR] placeholder */
 		$this->migrateDefaultBackupDir();
 
+		/* Remove the orphaned mis-registered component (element
+		   com_component-mokosuitebackup) left behind when the component <name>
+		   briefly used the "Type - Name" convention. Self-healing on every update. */
+		$this->removeOrphanedComponent();
+
 		/* Install completion notice (install and update) */
 		$this->installSuccessful();
 
@@ -192,6 +197,107 @@ class Pkg_MokoSuiteBackupInstallerScript
 		}
 	}
 
+	/**
+	 * Remove the orphaned component registration created when the component
+	 * <name> briefly used the "Type - Name" display convention. Joomla derives a
+	 * component's element from its <name>, so "Component - MokoSuiteBackup"
+	 * produced element com_component-mokosuitebackup — its own extension record,
+	 * admin menu items, schema rows and administrator/ folder — orphaning the real
+	 * com_mokosuitebackup on the old version. This reconciles affected sites on
+	 * update. Idempotent and non-fatal: does nothing when no orphan exists.
+	 *
+	 * @return  void
+	 */
+	private function removeOrphanedComponent(): void
+	{
+		try {
+			$db = Factory::getDbo();
+
+			$query = $db->getQuery(true)
+				->select($db->quoteName(['extension_id', 'element']))
+				->from($db->quoteName('#__extensions'))
+				->where($db->quoteName('type') . ' = ' . $db->quote('component'))
+				->where($db->quoteName('client_id') . ' = 1')
+				->where($db->quoteName('element') . ' LIKE ' . $db->quote('%component%mokosuitebackup%'))
+				->where($db->quoteName('element') . ' <> ' . $db->quote('com_mokosuitebackup'));
+			$db->setQuery($query);
+			$orphans = $db->loadObjectList();
+
+			if (empty($orphans)) {
+				return;
+			}
+
+			foreach ($orphans as $orphan) {
+				$id = (int) $orphan->extension_id;
+
+				/* Admin menu items owned by the orphan component */
+				$db->setQuery(
+					$db->getQuery(true)
+						->delete($db->quoteName('#__menu'))
+						->where($db->quoteName('component_id') . ' = ' . $id)
+				)->execute();
+
+				/* Schema-version rows */
+				$db->setQuery(
+					$db->getQuery(true)
+						->delete($db->quoteName('#__schemas'))
+						->where($db->quoteName('extension_id') . ' = ' . $id)
+				)->execute();
+
+				/* Update-site mapping (leave #__update_sites; harmless if orphaned) */
+				$db->setQuery(
+					$db->getQuery(true)
+						->delete($db->quoteName('#__update_sites_extensions'))
+						->where($db->quoteName('extension_id') . ' = ' . $id)
+				)->execute();
+
+				/* The bogus extension record itself */
+				$db->setQuery(
+					$db->getQuery(true)
+						->delete($db->quoteName('#__extensions'))
+						->where($db->quoteName('extension_id') . ' = ' . $id)
+				)->execute();
+
+				/* The stray admin component folder on disk */
+				$this->deleteFolderRecursive(JPATH_ADMINISTRATOR . '/components/' . $orphan->element);
+
+				Factory::getApplication()->enqueueMessage(
+					'MokoSuiteBackup: removed orphaned component registration "'
+					. htmlspecialchars($orphan->element, ENT_QUOTES, 'UTF-8') . '".',
+					'info'
+				);
+			}
+		} catch (\Throwable $e) {
+			/* Never block the install/update over best-effort cleanup */
+			Log::add('MokoSuiteBackup orphan-component cleanup failed: ' . $e->getMessage(), Log::WARNING, 'jerror');
+		}
+	}
+
+	/**
+	 * Recursively delete a directory (version-independent, no Folder dependency).
+	 *
+	 * @param   string  $dir  Absolute path
+	 *
+	 * @return  void
+	 */
+	private function deleteFolderRecursive(string $dir): void
+	{
+		if ($dir === '' || !is_dir($dir)) {
+			return;
+		}
+
+		$items = new \RecursiveIteratorIterator(
+			new \RecursiveDirectoryIterator($dir, \FilesystemIterator::SKIP_DOTS),
+			\RecursiveIteratorIterator::CHILD_FIRST
+		);
+
+		foreach ($items as $item) {
+			$item->isDir() ? @rmdir($item->getPathname()) : @unlink($item->getPathname());
+		}
+
+		@rmdir($dir);
+	}
+
 	/**
 	 * Generate a cryptographically random webcron secret word on fresh install.
 	 */