release: promote dev → main (installer + admin-menu + UI fixes) #224

Merged

jmiller merged 25 commits from dev into main 2026-07-06 00:30:30 +00:00

Conversation 0 Commits 25 Files Changed 33

+308 -78

jmiller commented 2026-07-06 00:29:54 +00:00

Owner

Copy Link

Copy Source

Promote the validated dev line to stable. All changed PHP php -l clean; verified end-to-end on the dev channel.

What's included

Installer / update reliability

• MySQL 8 install no longer aborts on PREPARE/EXECUTE/DEALLOCATE (error 1295) — legacy remote-column purge moved to PHP in script.php (dropLegacyRemoteColumns, INFORMATION_SCHEMA-gated plain ALTER); 02.56.01.sql neutralised.
• Duplicate-component self-heal: orphan com_component-mokosuitebackup removed in preflight + postflight (record, menu, schemas, folder).
• Admin menu self-heal: ensureSubmenuItems() recreates the top-level "Backup" menu if missing; menu label uses the short constant COM_MOKOJOOMBACKUP_SHORT. Restores the cPanel module + MokoSuiteClient detection.

UI

• Add/Edit Destination modal: Bootstrap .container-fluid padding frame, CSS via the Web Asset Manager (media/ + joomla.asset.json), no inline styles.
• SFTP key can be uploaded as a file (not only pasted).
• "Keep local copy" is per remote destination; removed from the main profile tab.

Behaviour

• Pre-update backup now shows an admin notification on every outcome (success/warning/failure), not only failure.

Merging cuts the stable release.

https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Promote the validated dev line to stable. All changed PHP `php -l` clean; verified end-to-end on the dev channel. ## What's included **Installer / update reliability** - MySQL 8 install no longer aborts on `PREPARE`/`EXECUTE`/`DEALLOCATE` (error 1295) — legacy remote-column purge moved to PHP in `script.php` (`dropLegacyRemoteColumns`, INFORMATION_SCHEMA-gated plain `ALTER`); `02.56.01.sql` neutralised. - Duplicate-component self-heal: orphan `com_component-mokosuitebackup` removed in **preflight** + postflight (record, menu, schemas, folder). - Admin menu self-heal: `ensureSubmenuItems()` recreates the top-level "Backup" menu if missing; menu label uses the short constant `COM_MOKOJOOMBACKUP_SHORT`. Restores the cPanel module + MokoSuiteClient detection. **UI** - Add/Edit Destination modal: Bootstrap `.container-fluid` padding frame, CSS via the **Web Asset Manager** (`media/` + `joomla.asset.json`), no inline styles. - SFTP key can be **uploaded as a file** (not only pasted). - "Keep local copy" is **per remote destination**; removed from the main profile tab. **Behaviour** - Pre-update backup now shows an admin notification on **every** outcome (success/warning/failure), not only failure. Merging cuts the stable release. https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

jmiller added 25 commits 2026-07-06 00:29:57 +00:00

fix(installer): drop legacy remote columns in PHP, not PREPARE-based SQL ... 8a85370e32

02.56.01.sql used PREPARE/EXECUTE/DEALLOCATE to conditionally drop the 26 legacy
remote_storage/ftp_*/sftp_*/gdrive_*/s3_* columns portably. Joomla's installer
rejects those statements on MySQL 8 (error 1295: "This command is not supported
in the prepared statement protocol yet"), aborting the whole component install
when updating from an old schema.

Neutralize 02.56.01.sql (now a no-op comment) and move the purge into
Pkg_MokoSuiteBackupInstallerScript::dropLegacyRemoteColumns(): gate on
INFORMATION_SCHEMA, then issue one plain ALTER dropping only the columns that
still exist — portable on MariaDB and MySQL 8, idempotent, non-fatal.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.57.01-dev [skip ci] 72aeea6955

Merge pull request 'fix(installer): drop legacy remote columns in PHP, not PREPARE-based SQL' (#218) from fix/sql-prepared-statement-protocol into dev ba2cda1385

chore(version): pre-release bump to 02.57.02-dev [skip ci] a92f423767

Merge pull request 'chore(sync): cascade main -> dev' (#212) from main into dev 4f91d1e432

chore(version): pre-release bump to 02.57.04-dev [skip ci] a3c7183374

fix(installer): self-heal admin menu; fix alias collision; short-constant label ... 2af2641712

Fallout of the duplicate-component element bug:

- Preflight now runs removeOrphanedComponent() BEFORE the component install
  recreates its menu, so the orphan's "Backup" menu (alias "backup") no longer
  collides ("The alias backup is already being used by the Backup menu item").
- ensureSubmenuItems() recreates the top-level "Backup" menu when it is missing
  (via new createTopMenu()) instead of bailing out — so a failed install that
  deleted the parent menu no longer leaves Backup gone from the admin menu (which
  also broke the cPanel module and MokoSuiteClient component detection).
- The top-level menu label now uses the short constant COM_MOKOJOOMBACKUP_SHORT
  (manifest <menu> + enforced/normalized in the script).

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.57.05-dev [skip ci] 1c420b2277

Merge pull request 'fix(installer): self-heal admin menu + alias collision + short-constant label' (#219) from fix/admin-menu-selfheal into dev 77bfaff8cd

chore(version): pre-release bump to 02.57.06-dev [skip ci] 8d5b33a74d

fix(ui): WAM-loaded CSS, per-destination keep-local, tidy destination modal ... 97e8d0cbe9

- Move component admin CSS to the Joomla Web Asset Manager: new
  media/com_mokosuitebackup/css/admin.css + media/joomla.asset.json, a <media>
  entry in the manifest, and useStyle('com_mokosuitebackup.admin') in the
  profile edit view. Removes the inline <style> block (no more inline CSS).
- Remove the profile-level "Keep local copy" field/"Remote" fieldset from
  forms/profile.xml — it is now per remote destination (modal remoteKeepLocal).
- Clean up the Add/Edit Destination modal padding/margins (in admin.css).

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.57.07-dev [skip ci] 2d538d3372

Merge pull request 'fix(ui): WAM-loaded CSS, per-destination keep-local, tidy destination modal' (#220) from fix/remote-modal-cleanup into dev 115ccfb069

chore(version): pre-release bump to 02.57.08-dev [skip ci] 9571b3759a

fix(plugin): pre-update backup notifies on success too, not only failure ... 1a1c81550c

runPreActionBackup() only enqueued a message when the backup failed, so a
successful pre-update backup produced no admin notification at all. Now it
surfaces every outcome via the BackupRunner status: complete -> success,
warning (archive made but remote upload failed) -> warning, fail -> error.

Refs #192

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.57.09-dev [skip ci] dfd4e77ade

Merge pull request 'fix(plugin): pre-update backup notifies on success, not only failure' (#221) from fix/preupdate-notification into dev e1f5afb301

chore(version): pre-release bump to 02.57.10-dev [skip ci] c84dcf2864

feat(ui): SFTP key file upload; msbackup modal padding frame ... 1ab99daaba

- Add/Edit Destination modal: SFTP key can now be UPLOADED as a file (read into
  the key textarea client-side via FileReader) instead of copy/paste; pasting
  still works.
- Give .modal-content a "msbackup" class with a 1rem padding frame — Bootstrap's
  .modal-content has no padding of its own, which made the modal feel cramped.
  Styling lives in the WAM stylesheet (media/.../admin.css), scoped to .msbackup.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Merge pull request 'feat(ui): SFTP key file upload + msbackup modal padding frame' (#222) from fix/modal-msbackup-class into dev 662918db38

chore(version): pre-release bump to 02.57.11-dev [skip ci] 8325afb03a

refactor(ui): modal padding via Bootstrap container, drop msbackup class ... dad3ce2db3

Per feedback, wrap the destination modal content in a Bootstrap .container-fluid
and give that a 1rem frame in the WAM stylesheet, instead of a custom
.msbackup class on .modal-content. Inner header/body/footer drop their own
horizontal padding so the frame isn't doubled.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.57.12-dev [skip ci] 9e5a942800

Merge pull request 'refactor(ui): modal padding via Bootstrap container, drop msbackup class' (#223) from fix/modal-container-padding into dev f7d8d82a4e

chore(version): pre-release bump to 02.57.13-dev [skip ci] 387bfbdeda

jmiller merged commit ba91f74edc into main 2026-07-06 00:30:30 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

component: admin

Admin UI and views

component: api

REST API

component: engine

Backup/restore engine

component: remote

Remote storage (FTP/GDrive)

component: scheduler

Scheduled tasks

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#224