fix(ui): WAM-loaded CSS, per-destination keep-local, tidy destination modal
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Universal: PR Check / Secret Scan (pull_request) Successful in 9s
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 25s
Generic: Project CI / Lint & Validate (pull_request) Successful in 12s
Universal: PR Check / Validate PR (pull_request) Failing after 47s
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 54s
Generic: Project CI / Tests (pull_request) Has been cancelled
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Universal: PR Check / Secret Scan (pull_request) Successful in 9s
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 25s
Generic: Project CI / Lint & Validate (pull_request) Successful in 12s
Universal: PR Check / Validate PR (pull_request) Failing after 47s
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 54s
Generic: Project CI / Tests (pull_request) Has been cancelled
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Universal: PR Check / Report Issues (pull_request) Has been cancelled
- Move component admin CSS to the Joomla Web Asset Manager: new
media/com_mokosuitebackup/css/admin.css + media/joomla.asset.json, a <media>
entry in the manifest, and useStyle('com_mokosuitebackup.admin') in the
profile edit view. Removes the inline <style> block (no more inline CSS).
- Remove the profile-level "Keep local copy" field/"Remote" fieldset from
forms/profile.xml — it is now per remote destination (modal remoteKeepLocal).
- Clean up the Add/Edit Destination modal padding/margins (in admin.css).
Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
This commit is contained in:
@@ -2,6 +2,11 @@
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
### Changed
|
||||
- Component admin CSS now loads via the Joomla **Web Asset Manager** (`media/com_mokosuitebackup/` + `joomla.asset.json`) instead of an inline `<style>` block.
|
||||
- "Keep local copy" is configured **per remote destination** (in the Add/Edit Destination modal); the redundant profile-level field and its "Remote" tab are removed.
|
||||
- Add/Edit Destination modal: cleaned up the cramped padding/margins.
|
||||
|
||||
### Fixed
|
||||
- Admin menu / duplicate-component fallout: (a) the orphaned `com_component-mokosuitebackup` is now removed in **preflight** too, so its "Backup" menu no longer collides on install ("The alias backup is already being used"); (b) `ensureSubmenuItems()` **recreates the top-level "Backup" menu** if it was deleted, instead of giving up — so Backup no longer disappears from the admin menu (and the cPanel module / MokoSuiteClient can find it again); (c) the component menu label now uses the short constant `COM_MOKOJOOMBACKUP_SHORT`. (#213 fallout)
|
||||
- Installer no longer aborts on MySQL 8 with "This command is not supported in the prepared statement protocol yet" (error 1295). The legacy remote-column purge migration (`02.56.01.sql`) used `PREPARE`/`EXECUTE`/`DEALLOCATE`, which Joomla's installer rejects; the drop now runs in the package installer script via an INFORMATION_SCHEMA-gated plain `ALTER` (portable across MariaDB and MySQL 8). (#213 update path)
|
||||
|
||||
@@ -205,19 +205,9 @@
|
||||
/>
|
||||
</fieldset>
|
||||
|
||||
<fieldset name="remote" label="COM_MOKOJOOMBACKUP_FIELDSET_REMOTE">
|
||||
<field
|
||||
name="remote_keep_local"
|
||||
type="radio"
|
||||
label="COM_MOKOJOOMBACKUP_FIELD_KEEP_LOCAL"
|
||||
description="COM_MOKOJOOMBACKUP_FIELD_KEEP_LOCAL_DESC"
|
||||
default="1"
|
||||
class="btn-group"
|
||||
>
|
||||
<option value="1">JYES</option>
|
||||
<option value="0">JNO</option>
|
||||
</field>
|
||||
</fieldset>
|
||||
<!-- The "Keep local copy" setting is now configured per remote destination
|
||||
(in the Add/Edit Destination modal), so the profile-level field and its
|
||||
"Remote" tab have been removed. -->
|
||||
|
||||
<fieldset name="retention" label="COM_MOKOJOOMBACKUP_FIELDSET_RETENTION">
|
||||
<field
|
||||
|
||||
@@ -0,0 +1,31 @@
|
||||
/**
|
||||
* MokoSuiteBackup — admin styles (loaded via the Joomla Web Asset Manager).
|
||||
*/
|
||||
|
||||
/* Add/Edit Destination modal — comfortable, consistent spacing */
|
||||
#remoteModal .modal-header,
|
||||
#remoteModal .modal-footer {
|
||||
padding: 1rem 1.75rem;
|
||||
}
|
||||
|
||||
#remoteModal .modal-body {
|
||||
padding: 1.5rem 1.75rem;
|
||||
}
|
||||
|
||||
#remoteModal .modal-body .row + .row,
|
||||
#remoteModal .remote-type-fields {
|
||||
margin-top: 0.25rem;
|
||||
}
|
||||
|
||||
#remoteModal hr {
|
||||
margin: 1.5rem 0;
|
||||
opacity: 0.12;
|
||||
}
|
||||
|
||||
#remoteModal .form-label {
|
||||
margin-bottom: 0.35rem;
|
||||
}
|
||||
|
||||
#remoteModal .form-check.form-switch {
|
||||
padding-top: 0.15rem;
|
||||
}
|
||||
@@ -0,0 +1,14 @@
|
||||
{
|
||||
"$schema": "https://developer.joomla.org/schemas/json-schema/web_assets.json",
|
||||
"name": "com_mokosuitebackup",
|
||||
"version": "1.0.0",
|
||||
"description": "MokoSuiteBackup web assets",
|
||||
"license": "GPL-3.0-or-later",
|
||||
"assets": [
|
||||
{
|
||||
"name": "com_mokosuitebackup.admin",
|
||||
"type": "style",
|
||||
"uri": "com_mokosuitebackup/css/admin.css"
|
||||
}
|
||||
]
|
||||
}
|
||||
@@ -78,6 +78,11 @@
|
||||
</languages>
|
||||
</administration>
|
||||
|
||||
<media destination="com_mokosuitebackup" folder="media">
|
||||
<folder>css</folder>
|
||||
<filename>joomla.asset.json</filename>
|
||||
</media>
|
||||
|
||||
<api>
|
||||
<files folder="api">
|
||||
<folder>src</folder>
|
||||
|
||||
@@ -19,6 +19,9 @@ HTMLHelper::_('behavior.formvalidator');
|
||||
HTMLHelper::_('behavior.keepalive');
|
||||
HTMLHelper::_('bootstrap.modal');
|
||||
|
||||
/* Component CSS via the Web Asset Manager (declared in media/joomla.asset.json) */
|
||||
$this->getDocument()->getWebAssetManager()->useStyle('com_mokosuitebackup.admin');
|
||||
|
||||
$profileId = (int) $this->item->id;
|
||||
$token = Session::getFormToken();
|
||||
?>
|
||||
|
||||
Reference in New Issue
Block a user