MokoConsulting/MokoSuiteBackup
1
0
Fork 0
Code Issues 28 Pull Requests Releases 2 Wiki Activity

fix(ui): WAM-loaded CSS, per-destination keep-local, tidy destination modal #220

Merged
jmiller merged 2 commits from fix/remote-modal-cleanup into dev 2026-07-05 23:49:04 +00:00
Conversation 0 Commits 2 Files Changed 18
+74 -25
jmiller commented 2026-07-05 23:48:50 +00:00
Owner
Copy Link
Copy Source

Targeting dev for the next dev build.

Three UI cleanups you flagged:

  1. CSS via the Web Asset Manager (no inline <style>): new media/com_mokosuitebackup/css/admin.css + media/joomla.asset.json, a <media destination="com_mokosuitebackup" folder="media"> entry in the component manifest, and useStyle('com_mokosuitebackup.admin') in the profile-edit view. This establishes the WAM pattern for the component (ref #175 — remaining inline JS/CSS can migrate the same way).
  2. "Keep local copy" removed from the main profile tab — it's now per remote destination (the modal's remoteKeepLocal). Dropped the profile-level remote_keep_local field and its "Remote" fieldset from forms/profile.xml.
  3. Add/Edit Destination modal spacing — comfortable, consistent padding/margins (now in admin.css, not inline).

Validated: manifest XML, joomla.asset.json, and php -l on the edit view all clean.

https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Targeting **dev** for the next dev build. Three UI cleanups you flagged: 1. **CSS via the Web Asset Manager** (no inline `<style>`): new `media/com_mokosuitebackup/css/admin.css` + `media/joomla.asset.json`, a `<media destination="com_mokosuitebackup" folder="media">` entry in the component manifest, and `useStyle('com_mokosuitebackup.admin')` in the profile-edit view. This establishes the WAM pattern for the component (ref #175 — remaining inline JS/CSS can migrate the same way). 2. **"Keep local copy" removed from the main profile tab** — it's now per remote destination (the modal's `remoteKeepLocal`). Dropped the profile-level `remote_keep_local` field and its "Remote" fieldset from `forms/profile.xml`. 3. **Add/Edit Destination modal spacing** — comfortable, consistent padding/margins (now in `admin.css`, not inline). Validated: manifest XML, `joomla.asset.json`, and `php -l` on the edit view all clean. https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
jmiller added 1 commit 2026-07-05 23:48:51 +00:00
fix(ui): WAM-loaded CSS, per-destination keep-local, tidy destination modal
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Details
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 9s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 25s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 12s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 47s
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 54s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
97e8d0cbe9 
- Move component admin CSS to the Joomla Web Asset Manager: new
  media/com_mokosuitebackup/css/admin.css + media/joomla.asset.json, a <media>
  entry in the manifest, and useStyle('com_mokosuitebackup.admin') in the
  profile edit view. Removes the inline <style> block (no more inline CSS).
- Remove the profile-level "Keep local copy" field/"Remote" fieldset from
  forms/profile.xml — it is now per remote destination (modal remoteKeepLocal).
- Clean up the Add/Edit Destination modal padding/margins (in admin.css).

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
jmiller added 1 commit 2026-07-05 23:48:53 +00:00
chore(version): pre-release bump to 02.57.07-dev [skip ci]
Branch Cleanup / Delete merged branch (pull_request) Successful in 1s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
2d538d3372
jmiller merged commit 115ccfb069 into dev 2026-07-05 23:49:04 +00:00
jmiller deleted branch fix/remote-modal-cleanup 2026-07-05 23:49:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
component: admin
Admin UI and views
 component: api
REST API
 component: engine
Backup/restore engine
 component: remote
Remote storage (FTP/GDrive)
 component: scheduler
Scheduled tasks
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#220
Delete Branch "fix/remote-modal-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?