fix: resolve version mismatches, missing lang keys, and error handling #109

Merged

jmiller merged 9 commits from dev into main 2026-05-24 03:44:16 +00:00

Conversation 0 Commits 9 Files Changed 5

+105 -25

jmiller commented 2026-05-23 23:11:32 +00:00

Owner

Copy Link

Copy Source

Summary

• Sync VERSION header in mokojoomtos.xml to 04.02.01 (#105)
• Add SEF_WARNING to site-side .ini files (#106)
• Fix updates.xml version, download URLs, and add Joomla 4.x target (#107)
• catch(Throwable) instead of catch(Exception) in script.php (#108)

Closes #105, #106, #107, #108

## Summary - Sync VERSION header in mokojoomtos.xml to 04.02.01 (#105) - Add SEF_WARNING to site-side .ini files (#106) - Fix updates.xml version, download URLs, and add Joomla 4.x target (#107) - catch(Throwable) instead of catch(Exception) in script.php (#108) Closes #105, #106, #107, #108

jmiller added 6 commits 2026-05-23 23:11:32 +00:00

fix(update): point dev channel to stable release artifact ... f7a0c3672d

The development channel was pointing to a non-existent dev release
tag, causing download failures. All channels now point to the stable
release (04.01.00) until a dev pre-release is actually built.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: resolve critical bugs and code quality issues ... a49fe2add8

Critical fixes:
- #89: Move enablePlugin() to postflight() — called unconditionally
- #90: Replace Table::addIncludePath() with bootComponent()->getMVCFactory()
       for Joomla 5 compatibility (was causing fatal crash on install)
- #91: Add non-SEF fallback — match by Itemid when SEF URLs are disabled

High priority fixes:
- #92: enablePlugin() now called on upgrade path too
- #93: Remove $_GET['tmpl'] superglobal mutation, use $input->set() only
- #94: Add params, metadata, attribs defaults to article creation data
- #95: Apply urldecode() to URI path before slug comparison
- #96: Cast Registry return to array before iterating slugs

Medium fixes:
- #99: Fix MenuslugField separator 'disable' → 'disabled' property

Code quality:
- #101: Strip legacy mokojoomtos.php to minimal stub (dead code under Joomla 5)
- #102: Convert script.php from spaces to tabs
- #103: Rename installer class to PlgSystemMokojoomtosInstallerScript

Closes: #89, #90, #91, #92, #93, #94, #95, #96, #99, #101, #102, #103

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: SEF warning in slug field + CHANGELOG cleanup ... b61a1eff6d

- #97: Add disabled warning option in MenuslugField when SEF URLs
  are off, with translatable language key in en-GB and en-US
- #100: Remove duplicate [03.09.00] entry, merge into single entry,
  update comparison links to Gitea, fix VERSION header to 04.02.01,
  add [Unreleased] section with current fixes

Closes: #97, #100

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat(plugin): add include children toggle + hardcode manifest description ... bab1187da3

Adds a Yes/No radio field to control whether child menu items under
selected slugs are also accessible during offline mode. Defaults to
Yes for backwards compatibility. Also hardcodes the manifest
description to prevent raw language keys during installation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge pull request 'chore: cascade main → dev (fcacd01) [skip ci]' (#104) from main into dev ... 97cc0acdf3

chore: cascade main → dev [skip ci]

fix: resolve version mismatches, missing lang keys, and error handling ... 39177bf78b

- Sync VERSION header in mokojoomtos.xml to 04.02.01 (#105)
- Add SEF_WARNING language key to site-side .ini files (#106)
- Update updates.xml: version to 04.02.01, add Joomla 4.x to
  targetplatform regex, fix download URLs (#107)
- Change catch(Exception) to catch(Throwable) in script.php to
  handle TypeError from chained null calls (#108)

Closes: #105, #106, #107, #108
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jmiller added 1 commit 2026-05-23 23:12:01 +00:00

chore: update updates.xml (development: 04.02.01-dev) [skip ci] 06d9499b39

jmiller added 1 commit 2026-05-23 23:16:58 +00:00

feat(install): auto-select default menu slugs on fresh install ... d6a1e77453

After creating the TOS article and menu item, automatically sets
terms-of-service and privacy-policy as the default tos_slug params
so the plugin works immediately with zero configuration. Only sets
defaults if no slugs are already configured.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jmiller added 1 commit 2026-05-23 23:17:24 +00:00

chore: update updates.xml (development: 04.02.01-dev) [skip ci] 5b378b564b

jmiller merged commit 4c62eac923 into main 2026-05-24 03:44:16 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

automation

Automated processes or scripts

breaking-change

Breaking API or functionality change

bug

Something is broken

build

Build system changes

ci-cd

CI/CD pipeline changes

code-quality

Code standards and cleanup

config

Configuration file changes

css

CSS/styling changes

dependencies

Dependency updates

deploy-failure

Automated deploy failure tracking

docker

Docker configuration changes

documentation

Documentation changes

dolibarr

Dolibarr module or extension

enhancement

New feature or improvement

generic

Generic project or library

good first issue

Good for newcomers

health-check

Repository health check results

health: excellent

Health score 90-100

health: fair

Health score 50-69

health: good

Health score 70-89

health: poor

Health score below 50

help wanted

Extra attention needed

html

HTML template changes

javascript

JavaScript code changes

joomla

Joomla extension or component

major-release

Major version release (breaking changes)

minor-release

Minor version release (XX.YY.00)

mokostandards

MokoStandards compliance

needs-review

Awaiting code review

needs-testing

Requires manual or automated testing

patch-release

Patch version release (XX.YY.ZZ)

pending: testing

Closed without testing proof - needs verification before closing

php

PHP code changes

priority: critical

Must fix before any release

priority: critical

Critical priority, must be addressed immediately

priority: high

High priority

priority: high

Should fix soon

priority: low

Low priority

priority: low

Nice to have

priority: medium

Medium priority

priority: medium

Fix when convenient

push-failure

File push failure requiring attention

python

Python code changes

regression

Regression from a previous working state

release-candidate

Release candidate build

security

Security-related changes

size/l

Large change (101-300 lines)

size/m

Medium change (31-100 lines)

size/s

Small change (11-30 lines)

size/xl

Extra large change (301-1000 lines)

size/xs

Extra small change (1-10 lines)

size/xxl

Extremely large change (1000+ lines)

standards-drift

Repository drifted from MokoStandards

standards-update

MokoStandards sync update

standards-violation

Standards compliance failure

status: blocked

Blocked by another issue or dependency

status: in-progress

Currently being worked on

status: needs-review

Awaiting code review

status: on-hold

Temporarily on hold

status: pending

Pending action or decision

status: wontfix

This will not be worked on

sync-failure

Bulk sync failure requiring attention

sync-report

Bulk sync run report

template-validation-failure

Template workflow validation failure

test-failure

Automated test failure

testing

Manual testing tasks

tests

Test suite changes

type: bug

Something isn't working

type: chore

Maintenance tasks

type: enhancement

Enhancement to existing feature

type: feature

New feature or request

type: refactor

Code refactoring

type: release

Release preparation or tracking

type: test

Test suite additions or changes

type: version

Version-related change

typescript

TypeScript code changes

version

Version bump or release

version-branch

Version branch related

version-drift

Version mismatch detected

work-in-progress

Work in progress, not ready for merge

bug

Something is not working

chore

Maintenance and housekeeping

documentation

Documentation improvements

enhancement

Improvement to existing functionality

feature

New feature or request

pending: dependency

Blocked by another issue or external dependency

pending: deployment

Tested and approved, awaiting deployment to production

pending: design

Needs UI/UX or architecture design before implementation

pending: documentation

Feature works, needs documentation/wiki update

pending: feedback

Awaiting feedback or decision from stakeholder

pending: review

Implementation complete, awaiting code review

pending: testing

Feature implemented but not yet tested

priority: critical

Must fix immediately

priority: high

Should fix soon

priority: low

Nice to have

priority: medium

Fix when convenient

refactor

Code restructuring without behavior change

roadmap

Planned feature or enhancement tracked on the roadmap

scope: client

Client-specific work

scope: dolibarr

Dolibarr modules and customizations

scope: infrastructure

Server, CI, backups, monitoring

scope: joomla

Joomla templates and extensions

scope: waas

MokoWaaS platform

security

Security vulnerability or hardening

status: blocked

Waiting on external dependency

status: duplicate

Duplicate of another issue

status: in-progress

Being worked on

status: needs-review

Ready for review

status: wontfix

Will not be addressed

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoJoomTOS#109