MokoConsulting/MokoJoomTOS
1
0
Fork 0
Code Issues 20 Pull Requests Releases 3 Wiki Activity

bug: plugin non-functional when SEF URLs are disabled #91

New Issue
Closed
opened 2026-05-22 03:29:25 +00:00 by jmiller · 1 comment
jmiller commented 2026-05-22 03:29:25 +00:00
Owner
Copy Link
Copy Source

Description

The slug matching logic in MokoJoomTOS.php operates on Uri::getInstance()->getPath(), which returns the SEF path (e.g., /terms-of-service). When SEF URLs are disabled, Joomla serves requests as index.php?option=com_content&view=article&id=1, making the path just index.php -- which will never match any configured slug.

Impact

The plugin silently fails when SEF is disabled. Legal pages are inaccessible during offline mode.

Fix

Add a fallback check using Joomla input parameters (e.g., Itemid against menu item IDs for configured slugs) when SEF is disabled.

Files

  • src/src/Extension/MokoJoomTOS.php:95-128 - slug matching logic
  • src/mokojoomtos.php:79-112 - legacy duplicate (dead code under Joomla 5)
## Description The slug matching logic in `MokoJoomTOS.php` operates on `Uri::getInstance()->getPath()`, which returns the SEF path (e.g., `/terms-of-service`). When SEF URLs are disabled, Joomla serves requests as `index.php?option=com_content&view=article&id=1`, making the path just `index.php` -- which will never match any configured slug. ## Impact The plugin silently fails when SEF is disabled. Legal pages are inaccessible during offline mode. ## Fix Add a fallback check using Joomla input parameters (e.g., `Itemid` against menu item IDs for configured slugs) when SEF is disabled. ## Files - `src/src/Extension/MokoJoomTOS.php:95-128` - slug matching logic - `src/mokojoomtos.php:79-112` - legacy duplicate (dead code under Joomla 5)
jmiller added the joomlapriority: criticalbug labels 2026-05-22 03:29:25 +00:00
jmiller commented 2026-05-22 03:38:43 +00:00
Author
Owner
Copy Link
Copy Source

Testing Steps -- Non-SEF URL fallback

Setup

  1. Install the plugin on a Joomla 5.x site
  2. Configure the plugin with slug terms-of-service
  3. Verify the Terms of Service article and menu item exist

Test A: SEF enabled (baseline)

  1. Go to System > Global Configuration > SEO -- ensure Search Engine Friendly URLs = Yes
  2. Set Site Offline = Yes
  3. In an incognito browser, visit yoursite.com/terms-of-service
  4. Expected: Article content displays (no template chrome)

Test B: SEF disabled (the fix)

  1. Go to System > Global Configuration > SEO -- set Search Engine Friendly URLs = No
  2. Set Site Offline = Yes
  3. Find the menu item ID for Terms of Service (check in Menus > Legal)
  4. In an incognito browser, visit yoursite.com/index.php?Itemid=XX (replace XX with the menu item ID)
  5. Expected: Article content displays (no template chrome)
  6. Visit yoursite.com/index.php?Itemid=999 (non-matching ID)
  7. Expected: Offline page is shown

Test C: SEF disabled, no Itemid

  1. With SEF off and site offline, visit yoursite.com/index.php
  2. Expected: Offline page is shown (no bypass without valid Itemid)

Pass criteria

  • SEF enabled: slug matching works as before
  • SEF disabled: Itemid-based matching bypasses offline mode
  • SEF disabled: non-matching Itemid shows offline page
  • SEF disabled: no Itemid shows offline page
## Testing Steps -- Non-SEF URL fallback ### Setup 1. Install the plugin on a Joomla 5.x site 2. Configure the plugin with slug `terms-of-service` 3. Verify the Terms of Service article and menu item exist ### Test A: SEF enabled (baseline) 1. Go to **System > Global Configuration > SEO** -- ensure **Search Engine Friendly URLs = Yes** 2. Set **Site Offline = Yes** 3. In an incognito browser, visit `yoursite.com/terms-of-service` 4. **Expected:** Article content displays (no template chrome) ### Test B: SEF disabled (the fix) 1. Go to **System > Global Configuration > SEO** -- set **Search Engine Friendly URLs = No** 2. Set **Site Offline = Yes** 3. Find the menu item ID for Terms of Service (check in **Menus > Legal**) 4. In an incognito browser, visit `yoursite.com/index.php?Itemid=XX` (replace XX with the menu item ID) 5. **Expected:** Article content displays (no template chrome) 6. Visit `yoursite.com/index.php?Itemid=999` (non-matching ID) 7. **Expected:** Offline page is shown ### Test C: SEF disabled, no Itemid 1. With SEF off and site offline, visit `yoursite.com/index.php` 2. **Expected:** Offline page is shown (no bypass without valid Itemid) ### Pass criteria - [ ] SEF enabled: slug matching works as before - [ ] SEF disabled: Itemid-based matching bypasses offline mode - [ ] SEF disabled: non-matching Itemid shows offline page - [ ] SEF disabled: no Itemid shows offline page
Sign in to join this conversation.
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 bug
Something is broken
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 code-quality
Code standards and cleanup
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 enhancement
New feature or improvement
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 major-release
Major version release (breaking changes)
 minor-release
Minor version release (XX.YY.00)
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 needs-testing
Requires manual or automated testing
 patch-release
Patch version release (XX.YY.ZZ)
 pending: testing
Closed without testing proof - needs verification before closing
 php
PHP code changes
 priority: critical
Must fix before any release
 priority: critical
Critical priority, must be addressed immediately
 priority: high
High priority
 priority: high
Should fix soon
 priority: low
Low priority
 priority: low
Nice to have
 priority: medium
Medium priority
 priority: medium
Fix when convenient
 push-failure
File push failure requiring attention
 python
Python code changes
 regression
Regression from a previous working state
 release-candidate
Release candidate build
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 standards-violation
Standards compliance failure
 status: blocked
Blocked by another issue or dependency
 status: in-progress
Currently being worked on
 status: needs-review
Awaiting code review
 status: on-hold
Temporarily on hold
 status: pending
Pending action or decision
 status: wontfix
This will not be worked on
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 test-failure
Automated test failure
 testing
Manual testing tasks
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: release
Release preparation or tracking
 type: test
Test suite additions or changes
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-branch
Version branch related
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
bug
Something is not working
 chore
Maintenance and housekeeping
 documentation
Documentation improvements
 enhancement
Improvement to existing functionality
 feature
New feature or request
 pending: dependency
Blocked by another issue or external dependency
 pending: deployment
Tested and approved, awaiting deployment to production
 pending: design
Needs UI/UX or architecture design before implementation
 pending: documentation
Feature works, needs documentation/wiki update
 pending: feedback
Awaiting feedback or decision from stakeholder
 pending: review
Implementation complete, awaiting code review
 pending: testing
Feature implemented but not yet tested
 priority: critical
Must fix immediately
 priority: high
Should fix soon
 priority: low
Nice to have
 priority: medium
Fix when convenient
 refactor
Code restructuring without behavior change
 roadmap
Planned feature or enhancement tracked on the roadmap
 scope: client
Client-specific work
 scope: dolibarr
Dolibarr modules and customizations
 scope: infrastructure
Server, CI, backups, monitoring
 scope: joomla
Joomla templates and extensions
 scope: waas
MokoWaaS platform
 security
Security vulnerability or hardening
 status: blocked
Waiting on external dependency
 status: duplicate
Duplicate of another issue
 status: in-progress
Being worked on
 status: needs-review
Ready for review
 status: wontfix
Will not be addressed
No labels bug joomla priority: critical
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoJoomTOS#91
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?