fix: package_build.php Joomla package builds + PHPStan level 2 #95

Merged

jmiller merged 2 commits from dev into main 2026-05-26 00:39:25 +00:00

Conversation 0 Commits 2 Files Changed 2

+226 -163

jmiller commented 2026-05-26 00:39:16 +00:00

Owner

Copy Link

Copy Source

Summary

• package_build.php: fix 0-byte ZIP for Joomla package extensions (closes #92)
  • Sub-zips in packages/ subdir, no double pkg_ prefix, includes language/
• PHPStan: level 0 to 2, 67 type errors fixed

Test plan

• Trigger RC pre-release on MokoJoomGallery
• Verify ZIP is non-zero with correct structure

## Summary - package_build.php: fix 0-byte ZIP for Joomla package extensions (closes #92) - Sub-zips in packages/ subdir, no double pkg_ prefix, includes language/ - PHPStan: level 0 to 2, 67 type errors fixed ## Test plan - [ ] Trigger RC pre-release on MokoJoomGallery - [ ] Verify ZIP is non-zero with correct structure

jmiller added 2 commits 2026-05-26 00:39:16 +00:00

Merge pull request 'chore: cascade main → dev (11bd5e8) [skip ci]' (#94) from main into dev ... 2cfc0a61e9

chore: cascade main → dev [skip ci]

fix: package_build.php — correct Joomla package extension builds ... 989e84c44c

Two bugs fixed:
1. Double prefix: pkg_pkg_mokogallery → pkg_mokogallery (strip prefix
   from element name when it already matches the type prefix)
2. Package structure: sub-extension ZIPs now placed in packages/ subdir
   (was putting them in root), language/ directory now included

Correct ZIP structure:
  pkg_mokogallery-XX.XX.XX.zip
    pkg_mokogallery.xml
    script.php
    language/
    packages/
      com_mokogallery.zip
      mod_mokogallery.zip
      plg_*.zip

Closes #92

Authored-by: Moko Consulting
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jmiller merged commit ea2dcd7d96 into main 2026-05-26 00:39:25 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

automation

Automated processes or scripts

breaking-change

Breaking API or functionality change

build

Build system changes

ci-cd

CI/CD pipeline changes

config

Configuration file changes

css

CSS/styling changes

dependencies

Dependency updates

deploy-failure

Automated deploy failure tracking

docker

Docker configuration changes

documentation

Documentation changes

dolibarr

Dolibarr module or extension

generic

Generic project or library

good first issue

Good for newcomers

health-check

Repository health check results

health: excellent

Health score 90-100

health: fair

Health score 50-69

health: good

Health score 70-89

health: poor

Health score below 50

help wanted

Extra attention needed

html

HTML template changes

javascript

JavaScript code changes

joomla

Joomla extension or component

mokostandards

MokoStandards compliance

needs-review

Awaiting code review

php

PHP code changes

push-failure

File push failure requiring attention

python

Python code changes

security

Security-related changes

size/l

Large change (101-300 lines)

size/m

Medium change (31-100 lines)

size/s

Small change (11-30 lines)

size/xl

Extra large change (301-1000 lines)

size/xs

Extra small change (1-10 lines)

size/xxl

Extremely large change (1000+ lines)

standards-drift

Repository drifted from MokoStandards

standards-update

MokoStandards sync update

sync-failure

Bulk sync failure requiring attention

sync-report

Bulk sync run report

template-validation-failure

Template workflow validation failure

tests

Test suite changes

type: bug

Something isn't working

type: chore

Maintenance tasks

type: enhancement

Enhancement to existing feature

type: feature

New feature or request

type: refactor

Code refactoring

type: version

Version-related change

typescript

TypeScript code changes

version

Version bump or release

version-drift

Version mismatch detected

work-in-progress

Work in progress, not ready for merge

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/mokoplatform#95