Merge pull request 'fix(installer): gate update() + enqueueMessage for success (og-com tidy)' (#122) from fix/og-installer-tidy into dev

Mirrors the install() smart-check on update() and replaces echo with a proper
Joomla message for consistency.

Claude-Session: https://claude.ai/code/session_01MrxXW9iyuDda5yDZrjZMbF

.mokogitea/workflows/issue-branch.yml

@@ -5,7 +5,7 @@
 # FILE INFORMATION
 # DEFGROUP: Gitea.Workflow
 # INGROUP: mokocli.Automation
-# VERSION: 01.07.06
+# VERSION: 01.07.05
 # BRIEF: Auto-create feature branch when an issue is opened
 
 name: "Universal: Issue Branch"

CHANGELOG.md

@@ -4,13 +4,10 @@ All notable changes to MokoSuiteOpenGraph will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
-<!-- VERSION: 01.07.06 -->
+<!-- VERSION: 01.07.05 -->
 
 ## [Unreleased]
 
-### Fixed
-- **Honest install success** — the installer no longer claims success or shows the license message when the install partially failed. The package postflight verifies every child extension declared in the manifest registered in `#__extensions`; the `com_mokoog` component script verifies its declared tables exist before echoing the success message. Both checks fail open, so a transient DB/IO glitch never fakes a failure.
-
 ### Added
 - OG coverage **dashboard** as the default admin view — SVG donut gauge, coverage by content type, and a list of articles missing OG tags with a batch-generate shortcut (#94)
 - Single OG tag **create/edit screen** in the admin (the tag manager was previously read-only) (#98)

CODE_OF_CONDUCT.md

@@ -14,7 +14,7 @@
 	DEFGROUP: Template-Joomla
 	INGROUP: Template-Joomla.Documentation
 	REPO: https://github.com/mokoconsulting-tech/Template-Joomla/
-  VERSION: 01.07.06
+  VERSION: 01.07.05
   PATH: ./CODE_OF_CONDUCT.md
   BRIEF: Community expectations and enforcement guidelines
   NOTE: Adapted with attribution from the Contributor Covenant v2.1

GOVERNANCE.md

@@ -19,7 +19,7 @@
  DEFGROUP: mokoconsulting-tech.Template-Joomla
  INGROUP: MokoStandards.Governance
  REPO: https://github.com/mokoconsulting-tech/Template-Joomla
- VERSION: 01.07.06
+ VERSION: 01.07.05
  PATH: /GOVERNANCE.md
  BRIEF: Project governance rules, roles, and decision process for Template-Joomla
 -->

README.md

@@ -1,6 +1,6 @@
 # MokoSuiteOpenGraph
 
-<!-- VERSION: 01.07.06 -->
+<!-- VERSION: 01.07.05 -->
 
 Open Graph, Twitter Card, and social sharing meta tag management for Joomla 6 and higher.
 

SECURITY.md

@@ -23,7 +23,7 @@ DEFGROUP: Template-Joomla
 INGROUP: Template-Joomla.Documentation
 REPO: https://git.mokoconsulting.tech/MokoConsulting/Template-Joomla
 PATH: /SECURITY.md
-VERSION: 01.07.06
+VERSION: 01.07.05
 BRIEF: Security vulnerability reporting and handling policy
 -->
 

source/packages/com_mokoog/mokoog.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="component" method="upgrade">
     <name>com_mokoog</name>
-    <version>01.07.06</version>
+    <version>01.07.05</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/com_mokoog/script.php

@@ -1,119 +1,119 @@
-<?php
-
-/**
- * @package     MokoSuiteOpenGraph
- * @subpackage  com_mokoog
- * @author      Moko Consulting <hello@mokoconsulting.tech>
- * @copyright   Copyright (C) 2026 Moko Consulting. All rights reserved.
- * @license     GNU General Public License version 3 or later; see LICENSE
- */
-
-defined('_JEXEC') or die;
-
-use Joomla\CMS\Factory;
-use Joomla\CMS\Installer\InstallerAdapter;
-use Joomla\Database\DatabaseInterface;
-
-class Com_MokoOGInstallerScript
-{
-    /**
-     * Called after install.
-     *
-     * @param   InstallerAdapter  $parent  Installer adapter
-     *
-     * @return  void
-     */
-    public function install(InstallerAdapter $parent): void
-    {
-        // Be honest about success: don't claim a clean install if the component's
-        // own tables never landed. Fails open (see missingTables) so a query/IO
-        // glitch never fakes a failure.
-        $missing = $this->missingTables();
-
-        if (!empty($missing))
-        {
-            echo '<p>MokoSuiteOpenGraph component did not install correctly. '
-                . 'Missing database table(s): '
-                . htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '.</p>';
-
-            return;
-        }
-
-        echo '<p>MokoSuiteOpenGraph component installed successfully.</p>';
-    }
-
-    /**
-     * Called after update.
-     *
-     * @param   InstallerAdapter  $parent  Installer adapter
-     *
-     * @return  void
-     */
-    public function update(InstallerAdapter $parent): void
-    {
-        $missing = $this->missingTables();
-
-        if (!empty($missing))
-        {
-            echo '<p>MokoSuiteOpenGraph component did not update correctly. '
-                . 'Missing database table(s): '
-                . htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '.</p>';
-
-            return;
-        }
-
-        echo '<p>MokoSuiteOpenGraph component updated successfully.</p>';
-    }
-
-    /**
-     * Verify the component's declared tables actually exist. Reads the shipped
-     * install SQL, extracts every CREATE TABLE #__name, resolves the live prefix,
-     * and checks each against the database's table list (case-insensitive).
-     *
-     * FAILS OPEN: any error (unreadable SQL, query failure) returns [] so a
-     * transient glitch never turns a good install into a false failure.
-     *
-     * @return  string[]  Prefixed names of any missing tables.
-     */
-    private function missingTables(): array
-    {
-        try
-        {
-            $sqlFile = JPATH_ADMINISTRATOR . '/components/com_mokoog/sql/install.mysql.sql';
-
-            if (!is_file($sqlFile))
-            {
-                return [];
-            }
-
-            $sql = (string) file_get_contents($sqlFile);
-
-            if ($sql === '' || !preg_match_all('/CREATE\s+TABLE\s+(?:IF\s+NOT\s+EXISTS\s+)?[`"\']?(#__[A-Za-z0-9_]+)/i', $sql, $m))
-            {
-                return [];
-            }
-
-            $db       = Factory::getContainer()->get(DatabaseInterface::class);
-            $prefix   = $db->getPrefix();
-            $existing = array_map('strtolower', (array) $db->getTableList());
-            $missing  = [];
-
-            foreach (array_unique($m[1]) as $table)
-            {
-                $real = str_replace('#__', $prefix, $table);
-
-                if (!in_array(strtolower($real), $existing, true))
-                {
-                    $missing[] = $real;
-                }
-            }
-
-            return $missing;
-        }
-        catch (\Throwable $e)
-        {
-            // Fail open — never fake a failure on a glitch.
-            return [];
-        }
-    }
-}
+<?php
+
+/**
+ * @package     MokoSuiteOpenGraph
+ * @subpackage  com_mokoog
+ * @author      Moko Consulting <hello@mokoconsulting.tech>
+ * @copyright   Copyright (C) 2026 Moko Consulting. All rights reserved.
+ * @license     GNU General Public License version 3 or later; see LICENSE
+ */
+
+defined('_JEXEC') or die;
+
+use Joomla\CMS\Factory;
+use Joomla\CMS\Installer\InstallerAdapter;
+
+class Com_MokoOGInstallerScript
+{
+    /**
+     * Called after install.
+     *
+     * @param   InstallerAdapter  $parent  Installer adapter
+     *
+     * @return  void
+     */
+    public function install(InstallerAdapter $parent): void
+    {
+        // Be smart: verify EVERY table the component's own install SQL declares is
+        // actually present. If any are missing the install did not complete — say
+        // so instead of showing "installed successfully".
+        $missing = $this->missingTables();
+
+        if ($missing !== []) {
+            $detail = count($missing) > 6
+                ? count($missing) . ' expected database tables are missing'
+                : 'missing tables: ' . htmlspecialchars(implode(', ', $missing), ENT_QUOTES, 'UTF-8');
+
+            Factory::getApplication()->enqueueMessage(
+                '<strong>MokoSuiteOpenGraph did not install correctly.</strong> ' . $detail
+                . ' — review the errors above, then reinstall.',
+                'error'
+            );
+
+            return;
+        }
+
+        Factory::getApplication()->enqueueMessage('<h4>MokoSuiteOpenGraph installed successfully!</h4>', 'info');
+    }
+
+    /**
+     * Called after update.
+     *
+     * @param   InstallerAdapter  $parent  Installer adapter
+     *
+     * @return  void
+     */
+    public function update(InstallerAdapter $parent): void
+    {
+        // Same smart check on update: only report success if the schema is intact.
+        $missing = $this->missingTables();
+
+        if ($missing !== []) {
+            $detail = count($missing) > 6
+                ? count($missing) . ' expected database tables are missing'
+                : 'missing tables: ' . htmlspecialchars(implode(', ', $missing), ENT_QUOTES, 'UTF-8');
+
+            Factory::getApplication()->enqueueMessage(
+                '<strong>MokoSuiteOpenGraph did not update correctly.</strong> ' . $detail
+                . ' — review the errors above.',
+                'error'
+            );
+
+            return;
+        }
+
+        Factory::getApplication()->enqueueMessage('MokoSuiteOpenGraph updated successfully.', 'info');
+    }
+
+    /**
+     * Smart schema check: parse the component's own installed install SQL for every
+     * CREATE TABLE, then return the ones missing from the database. An empty array
+     * means the full schema installed. Fails open (returns []) if the SQL can't be
+     * read, so a good install is never flagged as failed.
+     *
+     * @return  string[]  Names (without the #__ prefix) of missing tables.
+     */
+    private function missingTables(): array
+    {
+        try {
+            $sqlFile = JPATH_ADMINISTRATOR . '/components/com_mokoog/sql/install.mysql.sql';
+
+            if (!is_file($sqlFile)) {
+                return [];
+            }
+
+            $sql = file_get_contents($sqlFile);
+
+            if ($sql === false
+                || !preg_match_all('/CREATE\s+TABLE\s+(?:IF\s+NOT\s+EXISTS\s+)?[`"\']?(#__[A-Za-z0-9_]+)/i', $sql, $m)) {
+                return [];
+            }
+
+            $db      = Factory::getDbo();
+            $prefix  = strtolower($db->getPrefix());
+            $have    = array_map('strtolower', $db->getTableList());
+            $missing = [];
+
+            foreach (array_unique($m[1]) as $decl) {
+                $bare = substr($decl, 3);                    // strip "#__"
+                if (!in_array($prefix . strtolower($bare), $have, true)) {
+                    $missing[] = $bare;
+                }
+            }
+
+            return $missing;
+        } catch (\Throwable $e) {
+            return [];
+        }
+    }
+}

source/packages/com_mokoog/sql/updates/mysql/01.07.05.sql

@@ -0,0 +1 @@
+/* 01.07.05 — no schema changes */

source/packages/com_mokoog/sql/updates/mysql/01.07.06.sql

@@ -1 +0,0 @@
-/* 01.07.06 — no schema changes */

source/packages/plg_content_mokoog/mokoog.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="plugin" group="content" method="upgrade">
     <name>Content - MokoSuiteOpenGraph</name>
-    <version>01.07.06</version>
+    <version>01.07.05</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_system_mokoog/mokoog.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="plugin" group="system" method="upgrade">
     <name>System - MokoSuiteOpenGraph</name>
-    <version>01.07.06</version>
+    <version>01.07.05</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_webservices_mokoog/mokoog.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="plugin" group="webservices" method="upgrade">
     <name>Web Services - MokoSuiteOpenGraph</name>
-    <version>01.07.06</version>
+    <version>01.07.05</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/pkg_mokoog.xml

@@ -8,7 +8,7 @@
 <extension type="package" method="upgrade">
     <name>Package - MokoSuiteOpenGraph</name>
     <packagename>mokoog</packagename>
-    <version>01.07.06</version>
+    <version>01.07.05</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/script.php

@@ -50,9 +50,10 @@ class Pkg_MokoOGInstallerScript
 
 	public function postflight(string $type, InstallerAdapter $parent): void
 	{
+		// The download key must be restored regardless of the install outcome.
 		$this->restoreDownloadKey();
 
-		// Enable plugins after first install (unconditional module/plugin setup)
+		// Housekeeping: ensure the bundled plugins are enabled after a fresh install.
 		if ($type === 'install')
 		{
 			$db = Factory::getContainer()->get(\Joomla\Database\DatabaseInterface::class);
@@ -70,19 +71,18 @@ class Pkg_MokoOGInstallerScript
 			}
 		}
 
-		// Be honest about success. Joomla's package installer only LOGS a failed child
-		// sub-install but still runs this postflight, so don't show the license /
-		// next-steps message if a bundled extension is actually missing. Fails open
-		// (see missingChildExtensions) so a query/IO glitch never fakes a failure.
+		// Be smart: only run the success path (the licence notice, which implies a
+		// completed install) when every child extension declared in the package
+		// manifest actually registered. If any are missing, the package did NOT
+		// install successfully — surface that instead of implying success.
 		$missing = $this->missingChildExtensions($parent);
 
-		if (!empty($missing))
+		if ($missing !== [])
 		{
 			Factory::getApplication()->enqueueMessage(
-				'<h4>MokoSuiteOpenGraph did not install correctly.</h4>'
-				. '<p>The following bundled extensions are missing: '
-				. htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '</p>'
-				. '<p>Please uninstall MokoSuiteOpenGraph and reinstall the full package.</p>',
+				'<strong>MokoSuiteOpenGraph did not install completely.</strong> '
+				. 'The following extension(s) failed to install: ' . htmlspecialchars(implode(', ', $missing), ENT_QUOTES, 'UTF-8') . '. '
+				. 'Resolve the errors shown above, then uninstall and reinstall the package.',
 				'error'
 			);
 
@@ -93,15 +93,22 @@ class Pkg_MokoOGInstallerScript
 	}
 
 	/**
-	 * Verify every child extension declared in the package manifest actually landed
-	 * in #__extensions. Returns readable labels of any that are missing.
+	 * Compare the child extensions the package manifest declares against what is
+	 * actually registered in #__extensions after the install/update. Returns the
+	 * label of each declared extension that is missing (i.e. failed to install);
+	 * an empty array means every child installed and the package succeeded.
 	 *
-	 * element = <file> "id", EXCEPT plugins strip a leading plg_<group>_; plugins also
-	 * match folder = <file> "group". FAILS OPEN — any error returns [] so a transient
-	 * glitch never turns a good install into a false failure.
+	 * Fails open: any error returns [] so a query problem can never turn a good
+	 * install into a false "did not install completely" warning.
+	 *
+	 * @param   InstallerAdapter  $parent  Installer adapter
+	 *
+	 * @return  string[]
 	 */
-	private function missingChildExtensions($parent): array
+	private function missingChildExtensions(InstallerAdapter $parent): array
 	{
+		$missing = [];
+
 		try
 		{
 			$manifest = $parent->getParent()->getManifest();
@@ -111,59 +118,49 @@ class Pkg_MokoOGInstallerScript
 				return [];
 			}
 
-			$db      = Factory::getContainer()->get(\Joomla\Database\DatabaseInterface::class);
-			$missing = [];
+			$db = Factory::getContainer()->get(\Joomla\Database\DatabaseInterface::class);
 
 			foreach ($manifest->files->file as $file)
 			{
-				$attrs  = $file->attributes();
-				$id     = isset($attrs['id']) ? (string) $attrs['id'] : '';
-				$exType = isset($attrs['type']) ? (string) $attrs['type'] : '';
+				$childType = (string) $file['type'];
+				$element   = (string) $file['id'];
+				$group     = (string) $file['group'];
 
-				if ($id === '' || $exType === '')
+				if ($element === '')
 				{
 					continue;
 				}
 
-				$group   = isset($attrs['group']) ? (string) $attrs['group'] : '';
-				$element = $id;
-
-				// Plugin element in #__extensions is the id minus any leading plg_<group>_.
-				if ($exType === 'plugin' && $group !== '')
-				{
-					$prefix = 'plg_' . $group . '_';
-
-					if (strpos($element, $prefix) === 0)
-					{
-						$element = substr($element, \strlen($prefix));
-					}
-				}
-
 				$query = $db->getQuery(true)
 					->select('COUNT(*)')
 					->from($db->quoteName('#__extensions'))
-					->where($db->quoteName('element') . ' = ' . $db->quote($element))
-					->where($db->quoteName('type') . ' = ' . $db->quote($exType));
+					->where($db->quoteName('element') . ' = ' . $db->quote($element));
 
-				if ($exType === 'plugin' && $group !== '')
+				if ($childType !== '')
+				{
+					$query->where($db->quoteName('type') . ' = ' . $db->quote($childType));
+				}
+
+				// Plugins are only unique by element + folder (the manifest "group").
+				if ($childType === 'plugin' && $group !== '')
 				{
 					$query->where($db->quoteName('folder') . ' = ' . $db->quote($group));
 				}
 
-				if ((int) $db->setQuery($query)->loadResult() === 0)
+				$db->setQuery($query);
+
+				if ((int) $db->loadResult() === 0)
 				{
-					$label     = trim((string) $file);
-					$missing[] = $label !== '' ? preg_replace('/\.zip$/i', '', $label) : $id;
+					$missing[] = $element . ($group !== '' ? ' (' . $group . ')' : '');
 				}
 			}
-
-			return $missing;
 		}
 		catch (\Throwable $e)
 		{
-			// Fail open — never fake a failure on a glitch.
 			return [];
 		}
+
+		return $missing;
 	}