chore(version): pre-release bump to 01.07.06-dev [skip ci]

Gate the installer success/license/next-steps message behind a fail-open
verifier so the installer never reports success when the install failed or
only partially completed.

- Package scripts: verify every child extension declared in the manifest
  actually registered in #__extensions before showing the license message.
- com_mokoog component script: verify the declared SQL tables exist before
  echoing the success message.

Mirrors MokoSuiteHQ PR #72 and MokoSuiteClient PR #300. Both checks are wrapped
in try/catch and fail open, so a transient DB/IO glitch never fakes a failure.

Claude-Session: https://claude.ai/code/session_01B9aZHSWbiiZykJD88pYx8R

.mokogitea/workflows/issue-branch.yml

@@ -5,7 +5,7 @@
 # FILE INFORMATION
 # DEFGROUP: Gitea.Workflow
 # INGROUP: mokocli.Automation
-# VERSION: 01.07.05
+# VERSION: 01.07.06
 # BRIEF: Auto-create feature branch when an issue is opened
 
 name: "Universal: Issue Branch"

CHANGELOG.md

@@ -4,10 +4,13 @@ All notable changes to MokoSuiteOpenGraph will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
-<!-- VERSION: 01.07.05 -->
+<!-- VERSION: 01.07.06 -->
 
 ## [Unreleased]
 
+### Fixed
+- **Honest install success** — the installer no longer claims success or shows the license message when the install partially failed. The package postflight verifies every child extension declared in the manifest registered in `#__extensions`; the `com_mokoog` component script verifies its declared tables exist before echoing the success message. Both checks fail open, so a transient DB/IO glitch never fakes a failure.
+
 ### Added
 - OG coverage **dashboard** as the default admin view — SVG donut gauge, coverage by content type, and a list of articles missing OG tags with a batch-generate shortcut (#94)
 - Single OG tag **create/edit screen** in the admin (the tag manager was previously read-only) (#98)

CODE_OF_CONDUCT.md

@@ -14,7 +14,7 @@
 	DEFGROUP: Template-Joomla
 	INGROUP: Template-Joomla.Documentation
 	REPO: https://github.com/mokoconsulting-tech/Template-Joomla/
-  VERSION: 01.07.05
+  VERSION: 01.07.06
   PATH: ./CODE_OF_CONDUCT.md
   BRIEF: Community expectations and enforcement guidelines
   NOTE: Adapted with attribution from the Contributor Covenant v2.1

GOVERNANCE.md

@@ -19,7 +19,7 @@
  DEFGROUP: mokoconsulting-tech.Template-Joomla
  INGROUP: MokoStandards.Governance
  REPO: https://github.com/mokoconsulting-tech/Template-Joomla
- VERSION: 01.07.05
+ VERSION: 01.07.06
  PATH: /GOVERNANCE.md
  BRIEF: Project governance rules, roles, and decision process for Template-Joomla
 -->

README.md

@@ -1,6 +1,6 @@
 # MokoSuiteOpenGraph
 
-<!-- VERSION: 01.07.05 -->
+<!-- VERSION: 01.07.06 -->
 
 Open Graph, Twitter Card, and social sharing meta tag management for Joomla 6 and higher.
 

SECURITY.md

@@ -23,7 +23,7 @@ DEFGROUP: Template-Joomla
 INGROUP: Template-Joomla.Documentation
 REPO: https://git.mokoconsulting.tech/MokoConsulting/Template-Joomla
 PATH: /SECURITY.md
-VERSION: 01.07.05
+VERSION: 01.07.06
 BRIEF: Security vulnerability reporting and handling policy
 -->
 

source/packages/com_mokoog/mokoog.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="component" method="upgrade">
     <name>com_mokoog</name>
-    <version>01.07.05</version>
+    <version>01.07.06</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/com_mokoog/script.php

@@ -1,119 +1,119 @@
-<?php
+<?php
-
+
-/**
+/**
- * @package     MokoSuiteOpenGraph
+ * @package     MokoSuiteOpenGraph
- * @subpackage  com_mokoog
+ * @subpackage  com_mokoog
- * @author      Moko Consulting <hello@mokoconsulting.tech>
+ * @author      Moko Consulting <hello@mokoconsulting.tech>
- * @copyright   Copyright (C) 2026 Moko Consulting. All rights reserved.
+ * @copyright   Copyright (C) 2026 Moko Consulting. All rights reserved.
- * @license     GNU General Public License version 3 or later; see LICENSE
+ * @license     GNU General Public License version 3 or later; see LICENSE
- */
+ */
-
+
-defined('_JEXEC') or die;
+defined('_JEXEC') or die;
-
+
-use Joomla\CMS\Factory;
+use Joomla\CMS\Factory;
-use Joomla\CMS\Installer\InstallerAdapter;
+use Joomla\CMS\Installer\InstallerAdapter;
-
+use Joomla\Database\DatabaseInterface;
-class Com_MokoOGInstallerScript
+
-{
+class Com_MokoOGInstallerScript
-    /**
+{
-     * Called after install.
+    /**
-     *
+     * Called after install.
-     * @param   InstallerAdapter  $parent  Installer adapter
+     *
-     *
+     * @param   InstallerAdapter  $parent  Installer adapter
-     * @return  void
+     *
-     */
+     * @return  void
-    public function install(InstallerAdapter $parent): void
+     */
-    {
+    public function install(InstallerAdapter $parent): void
-        // Be smart: verify EVERY table the component's own install SQL declares is
+    {
-        // actually present. If any are missing the install did not complete — say
+        // Be honest about success: don't claim a clean install if the component's
-        // so instead of showing "installed successfully".
+        // own tables never landed. Fails open (see missingTables) so a query/IO
-        $missing = $this->missingTables();
+        // glitch never fakes a failure.
-
+        $missing = $this->missingTables();
-        if ($missing !== []) {
+
-            $detail = count($missing) > 6
+        if (!empty($missing))
-                ? count($missing) . ' expected database tables are missing'
+        {
-                : 'missing tables: ' . htmlspecialchars(implode(', ', $missing), ENT_QUOTES, 'UTF-8');
+            echo '<p>MokoSuiteOpenGraph component did not install correctly. '
-
+                . 'Missing database table(s): '
-            Factory::getApplication()->enqueueMessage(
+                . htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '.</p>';
-                '<strong>MokoSuiteOpenGraph did not install correctly.</strong> ' . $detail
+
-                . ' — review the errors above, then reinstall.',
+            return;
-                'error'
+        }
-            );
+
-
+        echo '<p>MokoSuiteOpenGraph component installed successfully.</p>';
-            return;
+    }
-        }
+
-
+    /**
-        Factory::getApplication()->enqueueMessage('<h4>MokoSuiteOpenGraph installed successfully!</h4>', 'info');
+     * Called after update.
-    }
+     *
-
+     * @param   InstallerAdapter  $parent  Installer adapter
-    /**
+     *
-     * Called after update.
+     * @return  void
-     *
+     */
-     * @param   InstallerAdapter  $parent  Installer adapter
+    public function update(InstallerAdapter $parent): void
-     *
+    {
-     * @return  void
+        $missing = $this->missingTables();
-     */
+
-    public function update(InstallerAdapter $parent): void
+        if (!empty($missing))
-    {
+        {
-        // Same smart check on update: only report success if the schema is intact.
+            echo '<p>MokoSuiteOpenGraph component did not update correctly. '
-        $missing = $this->missingTables();
+                . 'Missing database table(s): '
-
+                . htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '.</p>';
-        if ($missing !== []) {
+
-            $detail = count($missing) > 6
+            return;
-                ? count($missing) . ' expected database tables are missing'
+        }
-                : 'missing tables: ' . htmlspecialchars(implode(', ', $missing), ENT_QUOTES, 'UTF-8');
+
-
+        echo '<p>MokoSuiteOpenGraph component updated successfully.</p>';
-            Factory::getApplication()->enqueueMessage(
+    }
-                '<strong>MokoSuiteOpenGraph did not update correctly.</strong> ' . $detail
+
-                . ' — review the errors above.',
+    /**
-                'error'
+     * Verify the component's declared tables actually exist. Reads the shipped
-            );
+     * install SQL, extracts every CREATE TABLE #__name, resolves the live prefix,
-
+     * and checks each against the database's table list (case-insensitive).
-            return;
+     *
-        }
+     * FAILS OPEN: any error (unreadable SQL, query failure) returns [] so a
-
+     * transient glitch never turns a good install into a false failure.
-        Factory::getApplication()->enqueueMessage('MokoSuiteOpenGraph updated successfully.', 'info');
+     *
-    }
+     * @return  string[]  Prefixed names of any missing tables.
-
+     */
-    /**
+    private function missingTables(): array
-     * Smart schema check: parse the component's own installed install SQL for every
+    {
-     * CREATE TABLE, then return the ones missing from the database. An empty array
+        try
-     * means the full schema installed. Fails open (returns []) if the SQL can't be
+        {
-     * read, so a good install is never flagged as failed.
+            $sqlFile = JPATH_ADMINISTRATOR . '/components/com_mokoog/sql/install.mysql.sql';
-     *
+
-     * @return  string[]  Names (without the #__ prefix) of missing tables.
+            if (!is_file($sqlFile))
-     */
+            {
-    private function missingTables(): array
+                return [];
-    {
+            }
-        try {
+
-            $sqlFile = JPATH_ADMINISTRATOR . '/components/com_mokoog/sql/install.mysql.sql';
+            $sql = (string) file_get_contents($sqlFile);
-
+
-            if (!is_file($sqlFile)) {
+            if ($sql === '' || !preg_match_all('/CREATE\s+TABLE\s+(?:IF\s+NOT\s+EXISTS\s+)?[`"\']?(#__[A-Za-z0-9_]+)/i', $sql, $m))
-                return [];
+            {
-            }
+                return [];
-
+            }
-            $sql = file_get_contents($sqlFile);
+
-
+            $db       = Factory::getContainer()->get(DatabaseInterface::class);
-            if ($sql === false
+            $prefix   = $db->getPrefix();
-                || !preg_match_all('/CREATE\s+TABLE\s+(?:IF\s+NOT\s+EXISTS\s+)?[`"\']?(#__[A-Za-z0-9_]+)/i', $sql, $m)) {
+            $existing = array_map('strtolower', (array) $db->getTableList());
-                return [];
+            $missing  = [];
-            }
+
-
+            foreach (array_unique($m[1]) as $table)
-            $db      = Factory::getDbo();
+            {
-            $prefix  = strtolower($db->getPrefix());
+                $real = str_replace('#__', $prefix, $table);
-            $have    = array_map('strtolower', $db->getTableList());
+
-            $missing = [];
+                if (!in_array(strtolower($real), $existing, true))
-
+                {
-            foreach (array_unique($m[1]) as $decl) {
+                    $missing[] = $real;
-                $bare = substr($decl, 3);                    // strip "#__"
+                }
-                if (!in_array($prefix . strtolower($bare), $have, true)) {
+            }
-                    $missing[] = $bare;
+
-                }
+            return $missing;
-            }
+        }
-
+        catch (\Throwable $e)
-            return $missing;
+        {
-        } catch (\Throwable $e) {
+            // Fail open — never fake a failure on a glitch.
-            return [];
+            return [];
-        }
+        }
-    }
+    }
-}
+}

source/packages/com_mokoog/sql/updates/mysql/01.07.05.sql

@@ -1 +0,0 @@
-/* 01.07.05 — no schema changes */

source/packages/com_mokoog/sql/updates/mysql/01.07.06.sql

@@ -0,0 +1 @@
+/* 01.07.06 — no schema changes */

source/packages/plg_content_mokoog/mokoog.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="plugin" group="content" method="upgrade">
     <name>Content - MokoSuiteOpenGraph</name>
-    <version>01.07.05</version>
+    <version>01.07.06</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_system_mokoog/mokoog.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="plugin" group="system" method="upgrade">
     <name>System - MokoSuiteOpenGraph</name>
-    <version>01.07.05</version>
+    <version>01.07.06</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_webservices_mokoog/mokoog.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="plugin" group="webservices" method="upgrade">
     <name>Web Services - MokoSuiteOpenGraph</name>
-    <version>01.07.05</version>
+    <version>01.07.06</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/pkg_mokoog.xml

@@ -8,7 +8,7 @@
 <extension type="package" method="upgrade">
     <name>Package - MokoSuiteOpenGraph</name>
     <packagename>mokoog</packagename>
-    <version>01.07.05</version>
+    <version>01.07.06</version>
     <creationDate>2026-05-23</creationDate>
     <author>Moko Consulting</author>
     <authorEmail>hello@mokoconsulting.tech</authorEmail>

source/script.php

@@ -50,10 +50,9 @@ class Pkg_MokoOGInstallerScript
 
 	public function postflight(string $type, InstallerAdapter $parent): void
 	{
-		// The download key must be restored regardless of the install outcome.
 		$this->restoreDownloadKey();
 
-		// Housekeeping: ensure the bundled plugins are enabled after a fresh install.
+		// Enable plugins after first install (unconditional module/plugin setup)
 		if ($type === 'install')
 		{
 			$db = Factory::getContainer()->get(\Joomla\Database\DatabaseInterface::class);
@@ -71,18 +70,19 @@ class Pkg_MokoOGInstallerScript
 			}
 		}
 
-		// Be smart: only run the success path (the licence notice, which implies a
+		// Be honest about success. Joomla's package installer only LOGS a failed child
-		// completed install) when every child extension declared in the package
+		// sub-install but still runs this postflight, so don't show the license /
-		// manifest actually registered. If any are missing, the package did NOT
+		// next-steps message if a bundled extension is actually missing. Fails open
-		// install successfully — surface that instead of implying success.
+		// (see missingChildExtensions) so a query/IO glitch never fakes a failure.
 		$missing = $this->missingChildExtensions($parent);
 
-		if ($missing !== [])
+		if (!empty($missing))
 		{
 			Factory::getApplication()->enqueueMessage(
-				'<strong>MokoSuiteOpenGraph did not install completely.</strong> '
+				'<h4>MokoSuiteOpenGraph did not install correctly.</h4>'
-				. 'The following extension(s) failed to install: ' . htmlspecialchars(implode(', ', $missing), ENT_QUOTES, 'UTF-8') . '. '
+				. '<p>The following bundled extensions are missing: '
-				. 'Resolve the errors shown above, then uninstall and reinstall the package.',
+				. htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '</p>'
+				. '<p>Please uninstall MokoSuiteOpenGraph and reinstall the full package.</p>',
 				'error'
 			);
 
@@ -93,22 +93,15 @@ class Pkg_MokoOGInstallerScript
 	}
 
 	/**
-	 * Compare the child extensions the package manifest declares against what is
+	 * Verify every child extension declared in the package manifest actually landed
-	 * actually registered in #__extensions after the install/update. Returns the
+	 * in #__extensions. Returns readable labels of any that are missing.
-	 * label of each declared extension that is missing (i.e. failed to install);
-	 * an empty array means every child installed and the package succeeded.
 	 *
-	 * Fails open: any error returns [] so a query problem can never turn a good
+	 * element = <file> "id", EXCEPT plugins strip a leading plg_<group>_; plugins also
-	 * install into a false "did not install completely" warning.
+	 * match folder = <file> "group". FAILS OPEN — any error returns [] so a transient
-	 *
+	 * glitch never turns a good install into a false failure.
-	 * @param   InstallerAdapter  $parent  Installer adapter
-	 *
-	 * @return  string[]
 	 */
-	private function missingChildExtensions(InstallerAdapter $parent): array
+	private function missingChildExtensions($parent): array
 	{
-		$missing = [];
-
 		try
 		{
 			$manifest = $parent->getParent()->getManifest();
@@ -118,49 +111,59 @@ class Pkg_MokoOGInstallerScript
 				return [];
 			}
 
-			$db = Factory::getContainer()->get(\Joomla\Database\DatabaseInterface::class);
+			$db      = Factory::getContainer()->get(\Joomla\Database\DatabaseInterface::class);
+			$missing = [];
 
 			foreach ($manifest->files->file as $file)
 			{
-				$childType = (string) $file['type'];
+				$attrs  = $file->attributes();
-				$element   = (string) $file['id'];
+				$id     = isset($attrs['id']) ? (string) $attrs['id'] : '';
-				$group     = (string) $file['group'];
+				$exType = isset($attrs['type']) ? (string) $attrs['type'] : '';
 
-				if ($element === '')
+				if ($id === '' || $exType === '')
 				{
 					continue;
 				}
 
+				$group   = isset($attrs['group']) ? (string) $attrs['group'] : '';
+				$element = $id;
+
+				// Plugin element in #__extensions is the id minus any leading plg_<group>_.
+				if ($exType === 'plugin' && $group !== '')
+				{
+					$prefix = 'plg_' . $group . '_';
+
+					if (strpos($element, $prefix) === 0)
+					{
+						$element = substr($element, \strlen($prefix));
+					}
+				}
+
 				$query = $db->getQuery(true)
 					->select('COUNT(*)')
 					->from($db->quoteName('#__extensions'))
-					->where($db->quoteName('element') . ' = ' . $db->quote($element));
+					->where($db->quoteName('element') . ' = ' . $db->quote($element))
+					->where($db->quoteName('type') . ' = ' . $db->quote($exType));
 
-				if ($childType !== '')
+				if ($exType === 'plugin' && $group !== '')
-				{
-					$query->where($db->quoteName('type') . ' = ' . $db->quote($childType));
-				}
-
-				// Plugins are only unique by element + folder (the manifest "group").
-				if ($childType === 'plugin' && $group !== '')
 				{
 					$query->where($db->quoteName('folder') . ' = ' . $db->quote($group));
 				}
 
-				$db->setQuery($query);
+				if ((int) $db->setQuery($query)->loadResult() === 0)
-
-				if ((int) $db->loadResult() === 0)
 				{
-					$missing[] = $element . ($group !== '' ? ' (' . $group . ')' : '');
+					$label     = trim((string) $file);
+					$missing[] = $label !== '' ? preg_replace('/\.zip$/i', '', $label) : $id;
 				}
 			}
+
+			return $missing;
 		}
 		catch (\Throwable $e)
 		{
+			// Fail open — never fake a failure on a glitch.
 			return [];
 		}
-
-		return $missing;
 	}