Compare commits

..

6 Commits

Author SHA1 Message Date
jmiller f341c086a2 refactor(installer): replace hardcoded extension list with dynamic manifest verification
Universal: PR Check / Branch Policy (pull_request) Successful in 2s
Universal: PR Check / Secret Scan (pull_request) Successful in 8s
Universal: PR Check / Validate PR (pull_request) Failing after 8s
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 36s
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Read package manifest via $adapter->getParent()->getManifest() to discover
children dynamically instead of maintaining a hardcoded EXPECTED_EXTENSIONS
array. Fail-open pattern wraps verification in try/catch. Only the success
path (plugin enables, license warning) is gated; unconditional housekeeping
(DLID restore) runs regardless.

Claude-Session: https://claude.ai/code/session_01CwLGvFJPjoPTp9BEnSjtJf
2026-07-06 10:45:59 -05:00
jmiller 36cc6ee4b2 feat: add post-install verification to detect failed sub-extensions
Universal: PR Check / Branch Policy (pull_request) Successful in 2s
Universal: PR Check / Validate PR (pull_request) Failing after 6s
Universal: PR Check / Secret Scan (pull_request) Successful in 6s
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 12s
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Checks that all expected component and plugins registered in
#__extensions after install. Disables the package entry and shows
an error if any sub-extension failed to install.

Claude-Session: https://claude.ai/code/session_01CwLGvFJPjoPTp9BEnSjtJf
2026-07-05 22:32:21 -05:00
gitea-actions[bot] 07c80b8e5d chore(version): pre-release bump to 06.00.19-dev [skip ci] 2026-06-30 18:30:39 +00:00
jmiller 09bc1c96b0 Merge pull request 'chore: cleanup workflows, add manual dispatch to pre-release' (#40) from chore/cleanup-workflows into dev
Universal: Auto Version Bump / Version Bump (push) Has been skipped
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 13s
2026-06-30 18:29:26 +00:00
gitea-actions[bot] 96ae9d9fc7 chore(version): pre-release bump to 06.00.15-dev [skip ci]
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Branch Cleanup / Delete merged branch (pull_request) Successful in 2s
2026-06-30 18:15:13 +00:00
jmiller 4ba500f6d5 chore: cleanup workflows, add manual dispatch to pre-release
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 10s
- Remove old build.yaml (hardcoded, references updates.xml)
- Remove duplicate build-release.yml
- Add pre-release.yml with workflow_dispatch for manual triggering
- All releases marked as pre-release until stable testing complete
2026-06-30 13:15:00 -05:00
8 changed files with 243 additions and 44 deletions
-33
View File
@@ -1,33 +0,0 @@
name: Build Package
on:
push:
tags:
- 'v*'
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: recursive
- name: Build package ZIP
run: |
cd source
# Create individual package ZIPs
for pkg_dir in packages/*/; do
pkg_name=$(basename "$pkg_dir")
cd "$pkg_dir"
zip -r "../../${pkg_name}.zip" . -x "*.git*"
cd ../..
done
# Create main package ZIP with all sub-packages + manifest
zip -j "pkg_mokosuitefield.zip" pkg_*.xml script.php updates.xml *.zip 2>/dev/null || true
ls -la *.zip
- name: Create Release
uses: softprops/action-gh-release@v1
with:
files: source/pkg_mokosuitefield.zip
generate_release_notes: true
+66
View File
@@ -0,0 +1,66 @@
name: Pre-Release Package
on:
push:
tags:
- "v*"
workflow_dispatch:
inputs:
version:
description: "Version (e.g. 1.0.0-alpha.1)"
required: true
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Determine version
id: version
run: |
if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
echo "VERSION=${{ github.event.inputs.version }}" >> $GITHUB_OUTPUT
echo "TAG=v${{ github.event.inputs.version }}" >> $GITHUB_OUTPUT
else
VERSION="${GITHUB_REF#refs/tags/v}"
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
echo "TAG=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT
fi
- name: Build package zip
run: |
cd source
for dir in packages/*/; do
pkg_name=$(basename "$dir")
cd "$dir"
zip -r "../../${pkg_name}.zip" . -x "*.git*"
cd ../..
done
mkdir -p pkg_build
mv *.zip pkg_build/
cp pkg_*.xml pkg_build/ 2>/dev/null || true
cp script.php pkg_build/ 2>/dev/null || true
cd pkg_build
zip -r "../${{ github.event.repository.name }}-${{ steps.version.outputs.VERSION }}.zip" .
- name: Create Pre-Release
uses: actions/create-release@v1
id: create_release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ steps.version.outputs.TAG }}
release_name: "${{ github.event.repository.name }} ${{ steps.version.outputs.TAG }}"
draft: false
prerelease: true
- name: Upload Release Asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: ./source/${{ github.event.repository.name }}-${{ steps.version.outputs.VERSION }}.zip
asset_name: ${{ github.event.repository.name }}-${{ steps.version.outputs.VERSION }}.zip
asset_content_type: application/zip
+1 -1
View File
@@ -5,7 +5,7 @@
# FILE INFORMATION
# DEFGROUP: Gitea.Workflow
# INGROUP: mokocli.Automation
# VERSION: 06.00.20
# VERSION: 06.00.19
# BRIEF: Auto-create feature branch when an issue is opened
name: "Universal: Issue Branch"
@@ -5,7 +5,7 @@
<creationDate>2026-06-27</creationDate>
<copyright>Copyright (C) 2026 Moko Consulting.</copyright>
<license>GPL-3.0-or-later</license>
<version>06.00.20</version>
<version>06.00.19</version>
<namespace path="src">Moko\Component\MokoSuiteField</namespace>
<administration>
<files folder="admin"><folder>services</folder><folder>src</folder><folder>tmpl</folder></files>
@@ -8,7 +8,7 @@
<license>GPL-3.0-or-later</license>
<authorEmail>hello@mokoconsulting.tech</authorEmail>
<authorUrl>https://mokoconsulting.tech</authorUrl>
<version>06.00.20</version>
<version>06.00.19</version>
<php_minimum>8.3</php_minimum>
<description>PLG_SYSTEM_MOKOSUITEFIELD_DESC</description>
<namespace path="src">Moko\Plugin\System\MokoSuiteField</namespace>
@@ -3,7 +3,7 @@
<name>Web Services - MokoSuite Field</name>
<element>mokosuitefield</element>
<author>Moko Consulting</author>
<version>06.00.20</version>
<version>06.00.19</version>
<license>GPL-3.0-or-later</license>
<namespace path="src">Moko\Plugin\WebServices\MokoSuiteField</namespace>
<files><folder>src</folder><folder>services</folder></files>
+2 -2
View File
@@ -2,7 +2,7 @@
<extension type="package" method="upgrade">
<name>Package - MokoSuite Field</name>
<packagename>mokosuitefield</packagename>
<version>06.00.20</version>
<version>06.00.19</version>
<creationDate>2026-06-27</creationDate>
<author>Moko Consulting</author>
<authorEmail>hello@mokoconsulting.tech</authorEmail>
@@ -18,6 +18,6 @@
<file type="plugin" id="plg_system_mokosuitefield" group="system">plg_system_mokosuitefield.zip</file>
</files>
<updateservers>
<server type="extension" name="MokoSuiteField Updates">https://git.mokoconsulting.tech/api/packages/MokoConsulting/generic/MokoSuiteField/updates.xml</server>
<server type="extension" name="MokoSuiteField Updates">https://git.mokoconsulting.tech/api/packages/MokoConsulting/generic/MokoSuiteField/latest/updates.xml</server>
</updateservers>
</extension>
+171 -5
View File
@@ -1,9 +1,10 @@
<?php
/**
* @package MokoSuiteField
* @subpackage pkg_mokosuitefield
* MokoSuite Field Package Install Script
*
* @package MokoSuite Field
* @copyright Copyright (C) 2026 Moko Consulting. All rights reserved.
* @license GNU General Public License version 3 or later; see LICENSE
* @license GPL-3.0-or-later
*/
defined('_JEXEC') or die;
@@ -11,19 +12,185 @@ defined('_JEXEC') or die;
use Joomla\CMS\Factory;
use Joomla\CMS\Installer\InstallerAdapter;
use Joomla\CMS\Log\Log;
use Joomla\Database\DatabaseInterface;
class Pkg_MokoSuiteFieldInstallerScript
{
private string $savedDlid = '';
public function preflight(string $type, InstallerAdapter $adapter): bool
{
if ($type === 'update')
{
$this->savedDlid = $this->getExistingDlid();
}
return true;
}
public function postflight(string $type, InstallerAdapter $adapter): void
{
if ($this->savedDlid)
{
$this->restoreDlid($this->savedDlid);
}
if ($type === 'install')
{
$missing = $this->verifyChildren($adapter);
if (!empty($missing))
{
Factory::getApplication()->enqueueMessage(
'<strong>MokoSuite Field — Incomplete Installation</strong><br>'
. 'The following extensions failed to install: '
. implode(', ', $missing)
. '.<br>Please check file permissions and server logs, then reinstall the package.',
'error'
);
return;
}
$this->enablePlugin('system', 'mokosuitefield');
$this->enablePlugin('webservices', 'mokosuitefield');
}
$this->warnMissingLicenseKey();
}
private function verifyChildren(InstallerAdapter $adapter): array
{
try
{
$manifest = $adapter->getParent()->getManifest();
$files = $manifest->files->file ?? [];
if (!$files)
{
return [];
}
$db = Factory::getContainer()->get(DatabaseInterface::class);
$missing = [];
foreach ($files as $file)
{
$type = (string) ($file['type'] ?? '');
$id = (string) ($file['id'] ?? '');
$group = (string) ($file['group'] ?? '');
if ($type === '' || $id === '')
{
continue;
}
$element = ($type === 'plugin' && $group !== '')
? preg_replace('/^plg_' . preg_quote($group, '/') . '_/', '', $id)
: $id;
$query = $db->getQuery(true)
->select('COUNT(*)')
->from($db->quoteName('#__extensions'))
->where($db->quoteName('element') . ' = ' . $db->quote($element))
->where($db->quoteName('type') . ' = ' . $db->quote($type));
if ($type === 'plugin' && $group !== '')
{
$query->where($db->quoteName('folder') . ' = ' . $db->quote($group));
}
$db->setQuery($query);
if ((int) $db->loadResult() === 0)
{
$missing[] = htmlspecialchars($type . ': ' . $id, ENT_QUOTES, 'UTF-8');
}
}
return $missing;
}
catch (\Throwable $e)
{
return [];
}
}
private function getExistingDlid(): string
{
try
{
$db = Factory::getContainer()->get(DatabaseInterface::class);
$db->setQuery(
$db->getQuery(true)
->select($db->quoteName('extra_query'))
->from($db->quoteName('#__update_sites'))
->where('(' . $db->quoteName('name') . ' LIKE ' . $db->quote('%MokoSuiteField%')
. ' OR ' . $db->quoteName('location') . ' LIKE ' . $db->quote('%MokoSuiteField%') . ')')
->setLimit(1)
);
$extraQuery = $db->loadResult() ?? '';
if (preg_match('/dlid=([a-zA-Z0-9]+)/', $extraQuery, $matches))
{
return $matches[1];
}
}
catch (\Throwable $e)
{
Log::add('Field install: failed to read DLID — ' . $e->getMessage(), Log::WARNING, 'mokosuite.field');
}
return '';
}
private function restoreDlid(string $dlid): void
{
try
{
$db = Factory::getContainer()->get(DatabaseInterface::class);
$db->setQuery(
$db->getQuery(true)
->update($db->quoteName('#__update_sites'))
->set($db->quoteName('extra_query') . ' = ' . $db->quote('dlid=' . $dlid))
->where('(' . $db->quoteName('name') . ' LIKE ' . $db->quote('%MokoSuiteField%')
. ' OR ' . $db->quoteName('location') . ' LIKE ' . $db->quote('%MokoSuiteField%') . ')')
);
$db->execute();
}
catch (\Throwable $e)
{
Log::add('Field install: failed to restore DLID — ' . $e->getMessage(), Log::WARNING, 'mokosuite.field');
}
}
private function enablePlugin(string $group, string $element): void
{
try
{
$db = Factory::getContainer()->get(DatabaseInterface::class);
$db->setQuery(
$db->getQuery(true)
->update($db->quoteName('#__extensions'))
->set($db->quoteName('enabled') . ' = 1')
->where($db->quoteName('type') . ' = ' . $db->quote('plugin'))
->where($db->quoteName('folder') . ' = ' . $db->quote($group))
->where($db->quoteName('element') . ' = ' . $db->quote($element))
);
$db->execute();
}
catch (\Throwable $e)
{
Log::add('Field install: failed to enable ' . $group . '/' . $element . ' — ' . $e->getMessage(), Log::WARNING, 'mokosuite.field');
}
}
private function warnMissingLicenseKey(): void
{
try
{
$db = Factory::getDbo();
$db = Factory::getContainer()->get(DatabaseInterface::class);
$app = Factory::getApplication();
$query = $db->getQuery(true)
@@ -65,7 +232,6 @@ class Pkg_MokoSuiteFieldInstallerScript
}
catch (\Throwable $e)
{
// Silent — avoid breaking install if update_sites query fails
}
}
}