MokoConsulting/MokoSuiteCross
1
0
Fork 0
Code Issues 27 Pull Requests 2 Releases 5 Wiki Activity

fix(installer): verify install success before showing success #256

Merged
jmiller merged 2 commits from fix/installer-success-detection into dev 2026-07-06 16:15:35 +00:00
Conversation 0 Commits 2 Files Changed 54
+217 -52

2 Commits

Author SHA1 Message Date
gitea-actions[bot] e7b0cf15cc chore(version): pre-release bump to 01.13.06-dev [skip ci]
Branch Cleanup / Delete merged branch (pull_request) Successful in 1s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
2026-07-06 03:56:08 +00:00
jmiller 60a9d81e22 fix(installer): verify install success before showing success
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 30s
Details 
Gate the success/license path in both installer scripts so a partial
install can no longer report success.

- Package script (pkg_mokosuitecross): add missingChildExtensions(),
  which reads the package manifest via getParent()->getManifest() and
  verifies each declared <file> child is registered in #__extensions
  (matching element+type, plus folder=group for plugins). If any are
  missing, enqueue an error and return before warnMissingLicenseKey().
  Housekeeping (download-key restore, core-plugin enable, PerfectPublisher
  migration detection) still runs unconditionally.
- Component script (com_mokosuitecross): postflight was empty. Add
  missingTables(), which parses the installed sql/install.mysql.sql for
  every CREATE TABLE and verifies each exists (prefix-substituted,
  case-insensitive). On any missing tables, enqueue an error and return
  before the success message; otherwise show install-success/license notice.

Both checks fail open (try/catch returning []/true) so a glitch never turns
a good install into a false failure. Extension names are htmlspecialchars'd.

Claude-Session: https://claude.ai/code/session_01MrxXW9iyuDda5yDZrjZMbF
 2026-07-05 22:55:42 -05:00