fix(health): return error on exceptions, fix MokoSuiteBackup detection
Platform: moko-platform CI / Gate 2: Unit Tests (8.1) (push) Blocked by required conditions
Platform: moko-platform CI / Gate 2: Unit Tests (8.2) (push) Blocked by required conditions
Platform: moko-platform CI / Gate 2: Unit Tests (8.3) (push) Blocked by required conditions
Platform: moko-platform CI / Gate 3: Self-Health Check (push) Blocked by required conditions
Generic: Project CI / Tests (pull_request) Blocked by required conditions
Platform: moko-platform CI / Gate 4: Governance (push) Blocked by required conditions
Platform: moko-platform CI / Gate 5: Template Integrity (push) Blocked by required conditions
Platform: moko-platform CI / CI Summary (push) Blocked by required conditions
Joomla: Extension CI / Tests (PHP 8.2) (pull_request) Blocked by required conditions
Joomla: Extension CI / Tests (PHP 8.3) (pull_request) Blocked by required conditions
Joomla: Extension CI / PHPStan Analysis (pull_request) Blocked by required conditions
Joomla: Extension CI / Build RC Pre-Release (pull_request) Blocked by required conditions
Platform: moko-platform CI / Gate 2: Unit Tests (8.1) (pull_request) Blocked by required conditions
Platform: moko-platform CI / Gate 2: Unit Tests (8.2) (pull_request) Blocked by required conditions
Platform: moko-platform CI / Gate 2: Unit Tests (8.3) (pull_request) Blocked by required conditions
Platform: moko-platform CI / Gate 3: Self-Health Check (pull_request) Blocked by required conditions
Platform: moko-platform CI / Gate 4: Governance (pull_request) Blocked by required conditions
Platform: moko-platform CI / Gate 5: Template Integrity (pull_request) Blocked by required conditions
Platform: moko-platform CI / CI Summary (pull_request) Blocked by required conditions
Universal: PR Check / Build RC Package (pull_request) Blocked by required conditions
Universal: PR Check / Report Issues (pull_request) Blocked by required conditions
Generic: Repo Health / Scripts governance (pull_request) Blocked by required conditions
Generic: Repo Health / Repository health (pull_request) Blocked by required conditions
Generic: Repo Health / Report Issues (pull_request) Blocked by required conditions
Joomla: Extension CI / Release Readiness Check (pull_request) Failing after 7s
Universal: PR Check / Branch Policy (pull_request) Successful in 2s
Universal: Secret Scanning / Gitleaks Secret Scan (pull_request) Successful in 7s
Universal: Auto Version Bump / Version Bump (push) Successful in 11s
Universal: PR Check / Validate PR (pull_request) Failing after 7s
Generic: Repo Health / Access control (pull_request) Successful in 1s
Generic: Repo Health / Site Health (pull_request) Has been skipped
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 11s
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 19s
Platform: moko-platform CI / Gate 1: Code Quality (push) Failing after 37s
Generic: Project CI / Lint & Validate (pull_request) Successful in 38s
Joomla: Extension CI / Lint & Validate (pull_request) Failing after 41s
Platform: moko-platform CI / Gate 1: Code Quality (pull_request) Failing after 41s

- Health check catch blocks now return status:error with message
- MokoSuiteBackup detection returns early and queries correct table
- Added checkMokoSuiteBackup() method for mokosuitebackup_records
This commit is contained in:
Jonathan Miller
2026-06-21 11:43:09 -05:00
parent 2d52cd9b05
commit b62fe22244
@@ -977,9 +977,12 @@ class MokoSuiteClient extends CMSPlugin implements BootableExtensionInterface
'message' => 'No backup solution installed (Akeeba Backup or MokoSuiteBackup)',
];
}
// MokoSuiteBackup is installed — query its table
return $this->checkMokoSuiteBackup($db);
}
// Get the most recent backup
// Get the most recent Akeeba Backup
$query = $db->getQuery(true)
->select([
$db->quoteName('id'),
@@ -1055,13 +1058,53 @@ class MokoSuiteClient extends CMSPlugin implements BootableExtensionInterface
}
catch (\Exception $e)
{
\Joomla\CMS\Log\Log::add('Backup check failed: ' . $e->getMessage(), \Joomla\CMS\Log\Log::WARNING, 'mokosuiteclient');
return [
'status' => 'ok',
'installed' => false,
'status' => 'error',
'message' => 'Backup check failed: ' . $e->getMessage(),
];
}
}
/**
* Query MokoSuiteBackup tables for backup status.
*/
protected function checkMokoSuiteBackup($db): array
{
$db->setQuery(
$db->getQuery(true)
->select(['id', 'description', 'status', 'backupstart', 'backupend', 'total_size'])
->from($db->quoteName('#__mokosuitebackup_records'))
->order($db->quoteName('id') . ' DESC'),
0, 1
);
$latest = $db->loadObject();
if (!$latest)
{
return ['status' => 'degraded', 'installed' => true, 'message' => 'MokoSuiteBackup installed but no backups found'];
}
$daysSince = 999;
if (!empty($latest->backupstart) && $latest->backupstart !== '0000-00-00 00:00:00')
{
$daysSince = (int) ((time() - strtotime($latest->backupstart)) / 86400);
}
$status = ($latest->status === 'complete' && $daysSince <= 7) ? 'ok' : 'degraded';
return [
'status' => $status,
'installed' => true,
'last_backup' => $latest->backupstart,
'last_status' => $latest->status,
'days_since' => $daysSince,
'message' => 'MokoSuiteBackup: last backup ' . $daysSince . 'd ago (' . $latest->status . ')',
];
}
/**
* Check Admin Tools status — WAF status, security exceptions.
*
@@ -1195,7 +1238,7 @@ class MokoSuiteClient extends CMSPlugin implements BootableExtensionInterface
}
catch (\Exception $e)
{
return ['status' => 'ok', 'https' => false];
return ['status' => 'error', 'message' => 'SSL check failed: ' . $e->getMessage()];
}
}
@@ -1280,7 +1323,7 @@ class MokoSuiteClient extends CMSPlugin implements BootableExtensionInterface
}
catch (\Exception $e)
{
return ['status' => 'ok', 'available' => false];
return ['status' => 'error', 'message' => 'Scheduler check failed: ' . $e->getMessage()];
}
}