MokoConsulting/MokoSuiteBackup
1
0
Fork 0
Code Issues 4 Pull Requests Packages Releases 5 Wiki Activity

fix: SFTP fields not showing when SFTP selected #99

Merged
jmiller merged 5 commits from fix/sftp-key-upload into main 2026-06-23 15:40:44 +00:00
Conversation 0 Commits 5 Files Changed 6
+1314 -1319
jmiller commented 2026-06-23 15:38:05 +00:00
Owner
Copy Link
Copy Source

Summary

Two fixes for SFTP profile configuration:

  1. Key file upload — SshKeyField with FileReader API, base64 encoding, sentinel-based key preservation
  2. Auth type dropdown — password / key / key+passphrase with conditional showon
  3. Remove required from showon fields — Joomla validates required server-side regardless of visibility, blocking profile save when not using SFTP

Also removes insecure FTP from the dropdown.

Test Plan

  • Save profile with remote_storage=None — no validation errors
  • Save profile with remote_storage=SFTP — fields visible
  • Upload key file → save → reopen → key shows as loaded
  • Select auth type Password → password field visible, key hidden
## Summary Two fixes for SFTP profile configuration: 1. **Key file upload** — SshKeyField with FileReader API, base64 encoding, sentinel-based key preservation 2. **Auth type dropdown** — password / key / key+passphrase with conditional showon 3. **Remove `required` from showon fields** — Joomla validates required server-side regardless of visibility, blocking profile save when not using SFTP Also removes insecure FTP from the dropdown. ## Test Plan - [ ] Save profile with remote_storage=None — no validation errors - [ ] Save profile with remote_storage=SFTP — fields visible - [ ] Upload key file → save → reopen → key shows as loaded - [ ] Select auth type Password → password field visible, key hidden
jmiller added the component: admincomponent: remote labels 2026-06-23 15:38:05 +00:00
jmiller added 2 commits 2026-06-23 15:38:06 +00:00
fix: remove required attr from SFTP showon fields — blocks save when not SFTP
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 22s
Details
1e9c8d54f4 
Joomla validates required fields server-side regardless of showon
visibility. SFTP fields with required="true" block saving when
remote_storage is set to None or S3/GDrive because the hidden
fields submit empty values. Validation should be done in
ProfileTable::check() conditionally instead.
chore(version): pre-release bump to 01.35.04-dev [skip ci]
Publish to Composer / Publish Package (release) Failing after 32s
Details
5785e9fd1e
jmiller added 3 commits 2026-06-23 15:40:29 +00:00
Merge remote-tracking branch 'origin/main' into fix/sftp-key-upload 5b9351e5f0
chore: normalize workflows e327f9cf5c
Merge branch 'fix/sftp-key-upload' of https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteBackup into fix/sftp-key-upload
Joomla: Extension CI / Tests (PHP 8.2) (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / Tests (PHP 8.3) (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / PHPStan Analysis (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / Build RC Pre-Release (pull_request) Blocked by required conditions
Details
Universal: PR Check / Build RC Package (pull_request) Blocked by required conditions
Details
Universal: PR Check / Report Issues (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Scripts governance (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Repository health (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Report Issues (pull_request) Blocked by required conditions
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 1s
Details
Generic: Repo Health / Access control (pull_request) Successful in 2s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Joomla: Extension CI / Release Readiness Check (pull_request) Failing after 5s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 4s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 5s
Details
Joomla: Extension CI / Lint & Validate (pull_request) Failing after 9s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 2s
Details
Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Failing after 5s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 38s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 44s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Successful in 21s
Details
bda4b0a23d 
# Conflicts:
#	.mokogitea/workflows/issue-branch.yml
#	README.md
#	source/packages/com_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml
#	source/pkg_mokosuitebackup.xml
jmiller merged commit bc06657317 into main 2026-06-23 15:40:44 +00:00
jmiller deleted branch fix/sftp-key-upload 2026-06-23 15:40:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
component: admin
Admin UI and views
 component: api
REST API
 component: engine
Backup/restore engine
 component: remote
Remote storage (FTP/GDrive)
 component: scheduler
Scheduled tasks
No labels component: admin component: remote
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#99
Delete Branch "fix/sftp-key-upload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?