MokoConsulting/MokoSuiteBackup

fix: installer postflight is honest about a partial/failed install #239

Merged

jmiller merged 2 commits from fix/installer-honesty into dev

2026-07-06 15:50:35 +00:00

Author	SHA1	Message	Date
mokogitea-actions[bot]	38160e9ae9	chore(version): pre-release bump to 02.58.15-dev [skip ci] Branch Cleanup / Delete merged branch (pull_request) Successful in 1s Details RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped Details	2026-07-06 15:50:17 +00:00
jmiller	6b4f98869a	fix: installer postflight honest about partial/failed install Universal: PR Check / Require Docs Update (pull_request) Has been skipped Details Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped Details Universal: PR Check / Branch Policy (pull_request) Successful in 2s Details Universal: PR Check / Secret Scan (pull_request) Successful in 8s Details Universal: Pre-Release / Build Pre-Release (${{ inputs.stability \|\| github.ref_name }}) (push) Successful in 37s Details Generic: Project CI / Lint & Validate (pull_request) Successful in 33s Details Universal: PR Check / Validate PR (pull_request) Failing after 28s Details Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 32s Details Generic: Project CI / Tests (pull_request) Has been cancelled Details Universal: PR Check / Build RC Package (pull_request) Has been cancelled Details Universal: PR Check / Report Issues (pull_request) Has been cancelled Details Joomla logs a failed child extension but still runs the package postflight, so the 'installed successfully' message could appear on a broken install. In postflight, before the success/next-steps messages: - verify every bundled child declared in the package manifest actually registered in #__extensions (match element+type, and folder=group for plugins), and - verify the component's schema tables (parsed dynamically from the installed install.mysql.sql) exist in the DB. If anything is missing, enqueue an error listing it and RETURN before the success message. Fail-open (try/catch -> nothing missing) so a transient manifest/DB/IO glitch can't fail a good install. Unconditional housekeeping (download-key restore, menu fixes) still runs regardless. Names escaped with htmlspecialchars; table/child lists derived dynamically, never hard-coded. Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i	2026-07-06 10:49:49 -05:00