MokoConsulting/MokoSuiteBackup
1
0
Fork 0
Code Issues 18 Pull Requests Releases 2 Wiki Activity

fix(restore): surface DatabaseImporter errors + quote-aware split #294

Merged
jmiller merged 1 commits from fix/databaseimporter-surface-errors into dev 2026-07-16 18:06:57 +00:00
Conversation 0 Commits 1 Files Changed 3
+87 -22
jmiller commented 2026-07-16 17:01:29 +00:00
Owner
Copy Link
Copy Source

Closes #188. RestoreEngine ignored DatabaseImporter::hasErrors(), so a non-stepped restore reported success even with failed SQL statements. It now logs the failures and returns a warning. DatabaseImporter also gets the quote/backtick/escape-aware statement splitter (a ; or newline inside a value no longer splits a statement; comments only skipped between statements), matching the stepped-engine fix (#291/#292).

https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Closes #188. RestoreEngine ignored DatabaseImporter::hasErrors(), so a non-stepped restore reported success even with failed SQL statements. It now logs the failures and returns a warning. DatabaseImporter also gets the quote/backtick/escape-aware statement splitter (a ; or newline inside a value no longer splits a statement; comments only skipped between statements), matching the stepped-engine fix (#291/#292). https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
jmiller added 1 commit 2026-07-16 18:06:53 +00:00
fix(restore): surface DatabaseImporter errors + quote-aware split (#188)
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Failing after 7s
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 2s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 8s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 12s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 15s
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 1s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 12s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
028e1c7e80 
RestoreEngine ignored DatabaseImporter::hasErrors(), so the non-stepped
restore always reported success even when SQL statements failed. It now
logs the failures and returns a warning ("database may be incomplete").
DatabaseImporter's splitter is also quote/backtick/escape-aware so a ; or
newline inside a value no longer splits a statement, and comments are only
skipped between statements — matching the stepped-engine fix (#291).

Closes #188.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
jmiller force-pushed fix/databaseimporter-surface-errors from b244c9f353 to 028e1c7e80 2026-07-16 18:06:53 +00:00 Compare
jmiller merged commit f3bcf9d79e into dev 2026-07-16 18:06:57 +00:00
jmiller deleted branch fix/databaseimporter-surface-errors 2026-07-16 18:06:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
component: admin
Admin UI and views
 component: api
REST API
 component: engine
Backup/restore engine
 component: remote
Remote storage (FTP/GDrive)
 component: scheduler
Scheduled tasks
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#294
Delete Branch "fix/databaseimporter-surface-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?