chore: sync pr-check.yml from Template-Generic [skip ci]

.mokogitea/workflows/auto-release.yml

@@ -380,13 +380,10 @@ jobs:
           import sys
           version, date = sys.argv[1], sys.argv[2]
           content = open('CHANGELOG.md').read()
-          marker = f'## [{version}]'
-          # Idempotent: only promote when this version header isn't already present,
-          # otherwise re-runs (or same-version builds) create empty duplicate headers.
-          if marker not in content:
-              new = f'## [Unreleased]\n\n{marker} --- {date}'
-              content = content.replace('## [Unreleased]', new, 1)
-              open('CHANGELOG.md', 'w').write(content)
+          old = '## [Unreleased]'
+          new = f'## [Unreleased]\n\n## [{version}] --- {date}'
+          content = content if ('## [' + version + ']') in content else content.replace(old, new, 1)
+          open('CHANGELOG.md', 'w').write(content)
           " "$VERSION" "$DATE"
             git add CHANGELOG.md
             git commit -m "chore: promote changelog [Unreleased] → [${VERSION}]" || true

.mokogitea/workflows/ci-generic.yml

@@ -131,10 +131,11 @@ jobs:
   test:
     name: Tests
     runs-on: ubuntu-latest
-    needs: lint
-    # Run only when lint succeeded; always() forces evaluation so a skipped
-    # lint (e.g. template repos) skips this job cleanly instead of hanging.
-    if: ${{ always() && needs.lint.result == 'success' }}
+    # Independent job (no `needs: lint`): the Gitea Actions scheduler does not
+    # offer the dependent 2nd job of a needs-chain to runners, so it stalls in
+    # "waiting" and is reaped by ABANDONED_JOB_TIMEOUT. Guard template repos
+    # directly (same condition lint uses) instead of gating on lint's result.
+    if: ${{ !startsWith(github.event.repository.name, 'Template-') }}
 
     steps:
       - name: Checkout

.mokogitea/workflows/issue-branch.yml

@@ -5,7 +5,7 @@
 # FILE INFORMATION
 # DEFGROUP: MokoGitea.Workflow
 # INGROUP: mokocli.Automation
-# VERSION: 02.58.09
+# VERSION: 01.00.00
 # BRIEF: Auto-create feature branch when an issue is opened
 
 name: "Universal: Issue Branch"

.mokogitea/workflows/pr-check.yml

@@ -210,7 +210,7 @@ jobs:
 
       - name: Check for merge conflict markers
         run: |
-          CONFLICTS=$(grep -rn '<<<<<<< \|>>>>>>> \|^=======$' --include='*.php' --include='*.xml' --include='*.css' --include='*.js' --include='*.json' --include='*.md' --include='*.yml' --include='*.yaml' --include='*.ini' --include='*.txt' . 2>/dev/null | grep -v '.git/' || true)
+          CONFLICTS=$(grep -rn '<<<<<<< \|>>>>>>> \|^=======$' --exclude-dir='.git' --exclude-dir='.mokogitea' --include='*.php' --include='*.xml' --include='*.css' --include='*.js' --include='*.json' --include='*.md' --include='*.yml' --include='*.yaml' --include='*.ini' --include='*.txt' . 2>/dev/null | grep -v '.git/' || true)
           if [ -n "$CONFLICTS" ]; then
             echo "::error::Merge conflict markers found in source files"
             echo "## Conflict Markers Found" >> $GITHUB_STEP_SUMMARY

CHANGELOG.md

@@ -2,20 +2,6 @@
 
 ## [Unreleased]
 
-### Added
-- Pre-update backup **notice + live-progress modal** on the admin update pages (Joomla Update and Extensions → Update). Because the server-side `onExtensionBeforeUpdate` backup runs synchronously and can't drive a browser modal, the system plugin now injects a "back up before you update" notice with a **Back up now** button that runs the same stepped backup as the dashboard and shows a live progress bar. On success it pings a new `ajax.preupdateAck` endpoint, which arms the same throttle the server-side hook checks — so clicking Joomla's Update afterwards won't run a duplicate backup. Gated by the existing `show_update_notice` + `backup_before_update` params. (#196)
-- Pre-update modal **phase 2 — "Auto-run on Update click"** (new opt-in param `preupdate_auto_intercept`, off by default). When enabled, clicking the toolbar **Update** button on the Joomla Update / Extensions-update page first pops the backup progress modal, runs the pre-update backup, then automatically continues the update. Implemented by wrapping `Joomla.submitbutton` for the `update.update` / `update.install` tasks only (Find Updates / Clear Cache are untouched); the manual "Back up now" notice remains as a fallback for any flow that doesn't route through `submitbutton`. (#196)
-- Retention now prunes **remote** copies too: when a backup is pruned by age/count, its archive is deleted from every enabled remote destination (SFTP / FTP / S3 / Google Drive), not just the local copy. Each uploader gained an idempotent `delete()` method (already-absent file = success), and removal is best-effort — a failing destination is logged but never blocks local pruning. The shared standalone `restore.php` is intentionally left in place (every backup overwrites it, so newer backups still depend on it). (#229)
-
-### Changed
-- Consolidated backup plumbing into shared helpers (#230):
-  - New `RemoteUploaderFactory` replaces the `createUploaderFromParams()` copy that was duplicated in `BackupEngine` and `SteppedBackupEngine`.
-  - `RetentionManager` is now the single retention authority — it takes the global `max_age_days`/`max_backups` fallback and gained `pruneOrphans()`; the system plugin's hourly cleanup delegates to it and its duplicate `deleteBackupRecord()` logic is removed.
-  - The backend controller, Web Services API controller, and legacy `cli/mokosuitebackup.php` now run backups through the shared `BackupRunner` (gaining the normalized complete/warning/fail status) instead of instantiating `BackupEngine` directly.
-
-### Fixed
-- Standalone restore script generation no longer aborts backups with `str_replace() expects at least 3 arguments, 2 given`. `MokoRestore::generateStandaloneScript()` had a `str_replace()` call (the "Backup Archive" pre-check rewrite) that was missing its `$php` subject argument, so **every** standalone-mode backup fatally errored while "Generating standalone restore.php…" — the archive still finalized and uploaded, but no `restore.php` was ever produced (the true root cause behind #226). (#226)
-- Remote upload: the standalone restore script upload is no longer silent — its result is now checked and logged, and a failed restore-script upload marks the backup as `warning` (previously the result was discarded, so a missing restore script on the remote went unreported while the archive still showed success). (#226)
 
 ## [02.58.00] --- 2026-07-06
 

SECURITY.md

@@ -23,7 +23,7 @@ DEFGROUP: Template-Joomla
 INGROUP: Template-Joomla.Documentation
 REPO: https://git.mokoconsulting.tech/MokoConsulting/Template-Joomla
 PATH: /SECURITY.md
-VERSION: 02.58.09
+VERSION: 02.58.00
 BRIEF: Security vulnerability reporting and handling policy
 -->
 

source/packages/com_mokosuitebackup/api/src/Controller/BackupsController.php

@@ -13,7 +13,7 @@ namespace Joomla\Component\MokoSuiteBackup\Api\Controller;
 defined('_JEXEC') or die;
 
 use Joomla\CMS\MVC\Controller\ApiController;
-use Joomla\Component\MokoSuiteBackup\Administrator\Service\BackupRunner;
+use Joomla\Component\MokoSuiteBackup\Administrator\Engine\BackupEngine;
 
 class BackupsController extends ApiController
 {
@@ -38,7 +38,8 @@ class BackupsController extends ApiController
 		$profileId   = (int) ($data['profile'] ?? 1);
 		$description = $data['description'] ?? 'API backup ' . date('Y-m-d H:i:s');
 
-		$result = (new BackupRunner())->run($profileId, $description, 'api');
+		$engine = new BackupEngine();
+		$result = $engine->run($profileId, $description, 'api');
 
 		if ($result['success']) {
 			$this->app->setHeader('status', 200);

source/packages/com_mokosuitebackup/cli/mokosuitebackup.php

@@ -30,7 +30,7 @@ if (!defined('JPATH_BASE')) {
 require_once JPATH_BASE . '/includes/framework.php';
 
 use Joomla\CMS\Factory;
-use Joomla\Component\MokoSuiteBackup\Administrator\Service\BackupRunner;
+use Joomla\Component\MokoSuiteBackup\Administrator\Engine\BackupEngine;
 
 // Parse CLI arguments
 $profileId   = 1;
@@ -56,7 +56,8 @@ echo "Profile: {$profileId}\n";
 echo "Description: {$description}\n";
 echo "Starting backup...\n\n";
 
-$result = (new BackupRunner())->run($profileId, $description, 'cli');
+$engine = new BackupEngine();
+$result = $engine->run($profileId, $description, 'cli');
 
 if ($result['success']) {
 	echo "SUCCESS: " . $result['message'] . "\n";

source/packages/com_mokosuitebackup/config.xml

@@ -151,18 +151,6 @@
 			<option value="1">JYES</option>
 			<option value="0">JNO</option>
 		</field>
-		<field
-			name="preupdate_auto_intercept"
-			type="radio"
-			label="COM_MOKOJOOMBACKUP_CONFIG_PREUPDATE_AUTO_INTERCEPT"
-			description="COM_MOKOJOOMBACKUP_CONFIG_PREUPDATE_AUTO_INTERCEPT_DESC"
-			default="0"
-			class="btn-group"
-			showon="backup_before_update:1"
-		>
-			<option value="1">JYES</option>
-			<option value="0">JNO</option>
-		</field>
 		<field
 			name="backup_before_uninstall"
 			type="radio"

source/packages/com_mokosuitebackup/language/en-GB/com_mokosuitebackup.ini

@@ -331,8 +331,6 @@ COM_MOKOJOOMBACKUP_CONFIG_SHOW_UPDATE_NOTICE_DESC="Display the update site confi
 COM_MOKOJOOMBACKUP_CONFIG_PREACTION="Pre-action Backups"
 COM_MOKOJOOMBACKUP_CONFIG_BACKUP_BEFORE_UPDATE="Backup Before Extension Update"
 COM_MOKOJOOMBACKUP_CONFIG_BACKUP_BEFORE_UPDATE_DESC="Automatically run a full backup before any extension is updated. Uses the default profile. Throttled to once per 10 minutes to prevent duplicate backups during batch updates."
-COM_MOKOJOOMBACKUP_CONFIG_PREUPDATE_AUTO_INTERCEPT="Auto-run on Update click"
-COM_MOKOJOOMBACKUP_CONFIG_PREUPDATE_AUTO_INTERCEPT_DESC="When enabled, clicking the Update button on the Joomla Update or Extensions update page first pops the backup progress modal, runs the pre-update backup, then automatically continues the update. When disabled, a notice with a manual 'Back up now' button is shown instead."
 COM_MOKOJOOMBACKUP_CONFIG_BACKUP_BEFORE_UNINSTALL="Backup Before Extension Uninstall"
 COM_MOKOJOOMBACKUP_CONFIG_BACKUP_BEFORE_UNINSTALL_DESC="Automatically run a full backup before any extension is uninstalled. Uses the default profile. Throttled to once per 10 minutes."
 

source/packages/com_mokosuitebackup/language/en-US/com_mokosuitebackup.ini

@@ -53,8 +53,6 @@ COM_MOKOJOOMBACKUP_CONFIG_SHOW_UPDATE_NOTICE_DESC="Display the update site confi
 COM_MOKOJOOMBACKUP_CONFIG_PREACTION="Pre-action Backups"
 COM_MOKOJOOMBACKUP_CONFIG_BACKUP_BEFORE_UPDATE="Backup Before Extension Update"
 COM_MOKOJOOMBACKUP_CONFIG_BACKUP_BEFORE_UPDATE_DESC="Automatically run a full backup before any extension is updated. Uses the default profile. Throttled to once per 10 minutes to prevent duplicate backups during batch updates."
-COM_MOKOJOOMBACKUP_CONFIG_PREUPDATE_AUTO_INTERCEPT="Auto-run on Update click"
-COM_MOKOJOOMBACKUP_CONFIG_PREUPDATE_AUTO_INTERCEPT_DESC="When enabled, clicking the Update button on the Joomla Update or Extensions update page first pops the backup progress modal, runs the pre-update backup, then automatically continues the update. When disabled, a notice with a manual 'Back up now' button is shown instead."
 COM_MOKOJOOMBACKUP_CONFIG_BACKUP_BEFORE_UNINSTALL="Backup Before Extension Uninstall"
 COM_MOKOJOOMBACKUP_CONFIG_BACKUP_BEFORE_UNINSTALL_DESC="Automatically run a full backup before any extension is uninstalled. Uses the default profile. Throttled to once per 10 minutes."
 

source/packages/com_mokosuitebackup/mokosuitebackup.xml

@@ -17,7 +17,7 @@
 		display label there.
 	-->
 	<name>MokoSuiteBackup</name>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/com_mokosuitebackup/sql/updates/mysql/02.58.01.sql

@@ -1 +0,0 @@
-/* 02.58.01 — no schema changes */

source/packages/com_mokosuitebackup/sql/updates/mysql/02.58.02.sql

@@ -1 +0,0 @@
-/* 02.58.02 — no schema changes */

source/packages/com_mokosuitebackup/sql/updates/mysql/02.58.03.sql

@@ -1 +0,0 @@
-/* 02.58.03 — no schema changes */

source/packages/com_mokosuitebackup/sql/updates/mysql/02.58.04.sql

@@ -1 +0,0 @@
-/* 02.58.04 — no schema changes */

source/packages/com_mokosuitebackup/sql/updates/mysql/02.58.05.sql

@@ -1 +0,0 @@
-/* 02.58.05 — no schema changes */

source/packages/com_mokosuitebackup/sql/updates/mysql/02.58.06.sql

@@ -1 +0,0 @@
-/* 02.58.06 — no schema changes */

source/packages/com_mokosuitebackup/sql/updates/mysql/02.58.07.sql

@@ -1 +0,0 @@
-/* 02.58.07 — no schema changes */

source/packages/com_mokosuitebackup/sql/updates/mysql/02.58.08.sql

@@ -1 +0,0 @@
-/* 02.58.08 — no schema changes */

source/packages/com_mokosuitebackup/sql/updates/mysql/02.58.09.sql

@@ -1 +0,0 @@
-/* 02.58.09 — no schema changes */

source/packages/com_mokosuitebackup/src/Controller/AjaxController.php

@@ -84,35 +84,6 @@ class AjaxController extends BaseController
 		$this->sendJson($result);
 	}
 
-	/**
-	 * Mark the pre-update backup as satisfied for this session.
-	 *
-	 * Called by the update-page modal after a successful on-demand backup so the
-	 * imminent server-side onExtensionBeforeUpdate backup is skipped — it sets
-	 * the same 10-minute throttle key the system plugin checks, preventing a
-	 * duplicate backup when the admin then clicks Joomla's Update button.
-	 * POST: task=ajax.preupdateAck
-	 */
-	public function preupdateAck(): void
-	{
-		if (!Session::checkToken('get') && !Session::checkToken('post')) {
-			$this->sendJson(['error' => true, 'message' => 'Invalid token'], 403);
-
-			return;
-		}
-
-		if (!$this->app->getIdentity()->authorise('mokosuitebackup.backup.run', 'com_mokosuitebackup')) {
-			$this->sendJson(['error' => true, 'message' => 'Access denied'], 403);
-
-			return;
-		}
-
-		// Same key + semantics as plg_system_mokosuitebackup::runPreActionBackup().
-		Factory::getSession()->set('mokosuitebackup.preaction_backup_before_update', time());
-
-		$this->sendJson(['error' => false, 'message' => 'Pre-update backup acknowledged']);
-	}
-
 	/**
 	 * Cancel a backup record stuck in "running" status.
 	 * POST: task=ajax.cancelBackup&id=123

source/packages/com_mokosuitebackup/src/Controller/BackupsController.php

@@ -16,8 +16,8 @@ use Joomla\CMS\Language\Text;
 use Joomla\CMS\MVC\Controller\AdminController;
 use Joomla\CMS\Router\Route;
 use Joomla\CMS\Session\Session;
+use Joomla\Component\MokoSuiteBackup\Administrator\Engine\BackupEngine;
 use Joomla\Component\MokoSuiteBackup\Administrator\Engine\RestoreEngine;
-use Joomla\Component\MokoSuiteBackup\Administrator\Service\BackupRunner;
 
 class BackupsController extends AdminController
 {
@@ -54,7 +54,8 @@ class BackupsController extends AdminController
 		$profileId   = $this->input->getInt('profile_id', 1);
 		$description = $this->input->getString('description', '');
 
-		$result = (new BackupRunner())->run($profileId, $description, 'backend');
+		$engine = new BackupEngine();
+		$result = $engine->run($profileId, $description, 'backend');
 
 		// Surface preflight warnings as Joomla messages
 		if (!empty($result['warnings'])) {

source/packages/com_mokosuitebackup/src/Engine/BackupEngine.php

@@ -304,18 +304,7 @@ class BackupEngine
 							$this->log('  Upload complete: ' . $result['message']);
 
 							if (!empty($restoreScriptPath) && is_file($restoreScriptPath)) {
-								$scriptName = basename($restoreScriptPath);
-								$this->log('  Uploading restore script: ' . $scriptName . '...');
-								$scriptResult = $uploader->upload($restoreScriptPath, $scriptName);
-
-								if (!empty($scriptResult['success'])) {
-									$this->log('  Restore script uploaded: ' . ($scriptResult['message'] ?? $scriptName));
-								} else {
-									/* Never silent: a missing restore script makes the archive
-									   much harder to restore, so surface it as a warning. */
-									$uploadFailed = true;
-									$this->log('  WARNING: Restore script upload failed: ' . ($scriptResult['message'] ?? 'unknown error'));
-								}
+								$uploader->upload($restoreScriptPath, basename($restoreScriptPath));
 							}
 						} else {
 							$uploadFailed = true;
@@ -511,7 +500,24 @@ class BackupEngine
 	 */
 	private function createUploaderFromParams(string $type, array $params): RemoteUploaderInterface
 	{
-		return RemoteUploaderFactory::create($type, $params);
+		$prefixMap = ['ftp' => 'ftp_', 'sftp' => 'sftp_', 's3' => 's3_', 'google_drive' => 'gdrive_'];
+		$prefix    = $prefixMap[$type] ?? '';
+
+		$prefixed = [];
+
+		foreach ($params as $key => $value) {
+			$prefixed[$prefix . $key] = $value;
+		}
+
+		$fake = (object) $prefixed;
+
+		return match ($type) {
+			'ftp'          => new FtpUploader($fake),
+			'sftp'         => new SftpUploader($fake),
+			'google_drive' => new GoogleDriveUploader($fake),
+			's3'           => new S3Uploader($fake),
+			default        => throw new \InvalidArgumentException('Unknown remote storage type: ' . $type),
+		};
 	}
 
 	/**

source/packages/com_mokosuitebackup/src/Engine/FtpUploader.php

@@ -89,52 +89,6 @@ class FtpUploader implements RemoteUploaderInterface
 		}
 	}
 
-	public function delete(string $remoteName): array
-	{
-		if (!extension_loaded('ftp')) {
-			return ['success' => false, 'message' => 'PHP ext-ftp is required for FTP deletes. Enable it in php.ini.'];
-		}
-
-		if (empty($this->host)) {
-			return ['success' => false, 'message' => 'FTP host is not configured'];
-		}
-
-		$conn = $this->connect();
-
-		if (!$conn) {
-			return ['success' => false, 'message' => 'Failed to connect to FTP server ' . $this->host . ':' . $this->port];
-		}
-
-		try {
-			if (!@ftp_login($conn, $this->username, $this->password)) {
-				throw new \RuntimeException('FTP login failed for user: ' . $this->username);
-			}
-
-			if ($this->passive) {
-				ftp_pasv($conn, true);
-			}
-
-			$remoteFile = $this->remotePath . '/' . $remoteName;
-
-			/* Already-absent files: ftp_delete returns false, but if the file
-			   isn't there the retention goal is already met, so probe size to
-			   decide. ftp_size returns -1 when the file does not exist. */
-			if (@ftp_size($conn, $remoteFile) < 0) {
-				return ['success' => true, 'message' => 'FTP: nothing to delete (' . $remoteFile . ')'];
-			}
-
-			if (!@ftp_delete($conn, $remoteFile)) {
-				throw new \RuntimeException('ftp_delete failed for: ' . $remoteFile);
-			}
-
-			return ['success' => true, 'message' => 'Deleted from FTP: ' . $remoteFile];
-		} catch (\Throwable $e) {
-			return ['success' => false, 'message' => 'FTP delete failed: ' . $e->getMessage()];
-		} finally {
-			@ftp_close($conn);
-		}
-	}
-
 	public function testConnection(): array
 	{
 		if (empty($this->host)) {

source/packages/com_mokosuitebackup/src/Engine/GoogleDriveUploader.php

@@ -81,59 +81,6 @@ class GoogleDriveUploader implements RemoteUploaderInterface
 		}
 	}
 
-	public function delete(string $remoteName): array
-	{
-		if (!extension_loaded('curl')) {
-			return ['success' => false, 'message' => 'PHP ext-curl is required for Google Drive deletes. Enable it in php.ini.'];
-		}
-
-		if (empty($this->clientId) || empty($this->refreshToken)) {
-			return ['success' => false, 'message' => 'Google Drive credentials not configured'];
-		}
-
-		try {
-			$accessToken = $this->getAccessToken();
-
-			/* Drive has no path addressing — resolve the file id(s) by name
-			   within the configured folder, then delete each match. */
-			$q = "name = '" . str_replace("'", "\\'", $remoteName) . "' and trashed = false";
-
-			if (!empty($this->folderId)) {
-				$q .= " and '" . $this->folderId . "' in parents";
-			}
-
-			$listUrl  = self::API_URL . '/files?q=' . rawurlencode($q) . '&fields=' . rawurlencode('files(id,name)') . '&pageSize=25';
-			$response = $this->curlRequest('GET', $listUrl, null, [
-				'Authorization: Bearer ' . $accessToken,
-			]);
-
-			if ($response['code'] !== 200) {
-				throw new \RuntimeException('Drive file lookup failed (HTTP ' . $response['code'] . ')');
-			}
-
-			$files = json_decode($response['body'], true)['files'] ?? [];
-
-			if (empty($files)) {
-				return ['success' => true, 'message' => 'Google Drive: nothing to delete (' . $remoteName . ')'];
-			}
-
-			foreach ($files as $file) {
-				$del = $this->curlRequest('DELETE', self::API_URL . '/files/' . rawurlencode($file['id']), null, [
-					'Authorization: Bearer ' . $accessToken,
-				]);
-
-				/* 204 = deleted, 404 = already gone — both acceptable. */
-				if ($del['code'] !== 204 && $del['code'] !== 200 && $del['code'] !== 404) {
-					return ['success' => false, 'message' => 'Google Drive delete failed for ' . $remoteName . ' (HTTP ' . $del['code'] . ')'];
-				}
-			}
-
-			return ['success' => true, 'message' => 'Deleted from Google Drive: ' . $remoteName];
-		} catch (\Throwable $e) {
-			return ['success' => false, 'message' => 'Google Drive delete failed: ' . $e->getMessage()];
-		}
-	}
-
 	public function testConnection(): array
 	{
 		if (empty($this->clientId) || empty($this->refreshToken)) {

source/packages/com_mokosuitebackup/src/Engine/MokoRestore.php

@@ -204,8 +204,7 @@ ORIG,
         'ok'    => $backupCount > 0,
         'hint'  => 'Place one or more backup ZIP files in the same directory as ' . basename($_SERVER['SCRIPT_NAME']),
     ];
-REPL,
-			$php
+REPL
 		);
 
 		/* Modify remaining pre-checks to use getSelectedBackupFile() */

source/packages/com_mokosuitebackup/src/Engine/RemoteUploaderFactory.php

@@ -1,69 +0,0 @@
-<?php
-
-/**
- * @package     MokoSuiteBackup
- * @subpackage  com_mokosuitebackup
- * @author      Moko Consulting <hello@mokoconsulting.tech>
- * @copyright   Copyright (C) 2026 Moko Consulting. All rights reserved.
- * @license     GNU General Public License version 3 or later; see LICENSE
- */
-
-namespace Joomla\Component\MokoSuiteBackup\Administrator\Engine;
-
-defined('_JEXEC') or die;
-
-/**
- * Builds a remote uploader from a `#__mokosuitebackup_remotes` row.
- *
- * This was previously a private method duplicated in both BackupEngine and
- * SteppedBackupEngine (and needed a third time by RetentionManager for remote
- * deletion). It is centralised here so the type→class map and the param
- * key-prefixing convention live in exactly one place.
- *
- * The remotes table stores per-type settings as a flat JSON object with
- * un-prefixed keys (e.g. `{"host":"…","path":"/backups"}`). The concrete
- * uploaders, however, read prefixed keys off a profile-shaped object
- * (e.g. `sftp_host`, `s3_bucket`). This factory bridges the two.
- */
-final class RemoteUploaderFactory
-{
-	/**
-	 * Map of remote type → the key prefix its uploader expects.
-	 */
-	private const PREFIX_MAP = [
-		'ftp'          => 'ftp_',
-		'sftp'         => 'sftp_',
-		's3'           => 's3_',
-		'google_drive' => 'gdrive_',
-	];
-
-	/**
-	 * Create an uploader for the given remote type from decoded JSON params.
-	 *
-	 * @param   string  $type    Remote type: ftp, sftp, s3, google_drive
-	 * @param   array   $params  Key-value params decoded from the remote's JSON
-	 *
-	 * @return  RemoteUploaderInterface
-	 *
-	 * @throws  \InvalidArgumentException  On an unknown remote type
-	 */
-	public static function create(string $type, array $params): RemoteUploaderInterface
-	{
-		$prefix   = self::PREFIX_MAP[$type] ?? '';
-		$prefixed = [];
-
-		foreach ($params as $key => $value) {
-			$prefixed[$prefix . $key] = $value;
-		}
-
-		$fake = (object) $prefixed;
-
-		return match ($type) {
-			'ftp'          => new FtpUploader($fake),
-			'sftp'         => new SftpUploader($fake),
-			'google_drive' => new GoogleDriveUploader($fake),
-			's3'           => new S3Uploader($fake),
-			default        => throw new \InvalidArgumentException('Unknown remote storage type: ' . $type),
-		};
-	}
-}

source/packages/com_mokosuitebackup/src/Engine/RemoteUploaderInterface.php

@@ -24,21 +24,6 @@ interface RemoteUploaderInterface
 	 */
 	public function upload(string $localPath, string $remoteName): array;
 
-	/**
-	 * Delete a previously-uploaded file from remote storage.
-	 *
-	 * Used by retention pruning so that expiring a local backup also removes
-	 * its archive from every remote destination. Implementations should treat
-	 * an already-absent remote file as success (idempotent delete), so a
-	 * partially-cleaned destination never blocks pruning.
-	 *
-	 * @param   string  $remoteName  Filename on the remote end (the same
-	 *                               $remoteName that was passed to upload())
-	 *
-	 * @return  array{success: bool, message: string}
-	 */
-	public function delete(string $remoteName): array;
-
 	/**
 	 * Test the connection / credentials without uploading.
 	 *

source/packages/com_mokosuitebackup/src/Engine/RetentionManager.php

@@ -15,54 +15,32 @@ defined('_JEXEC') or die;
 use Joomla\Component\MokoSuiteBackup\Administrator\Utility\BackupDirectory;
 
 /**
- * Enforces per-profile backup retention — the single retention authority.
+ * Enforces per-profile backup retention.
  *
  * A profile may cap retained backups by age (retention_days) and/or by
- * number of copies (retention_count). When a profile leaves a rule at 0 the
- * caller-supplied global default is used instead. A backup is pruned when
- * EITHER rule matches: it is older than the effective days OR it falls outside
- * the newest effective count of copies.
- *
- * Pruning a record removes, in this order:
- *   1. the DB row (#__mokosuitebackup_records),
- *   2. the local archive + its .log file, and
- *   3. the archive copy on every enabled remote destination for the profile.
- *
- * The standalone restore script (restore.php) is intentionally NOT deleted
- * from remotes: it is a single, fixed-name file that every backup overwrites,
- * so newer backups still depend on it — removing it while pruning an old
- * archive would break restore for the copies that remain.
- *
- * Because records do not store which destinations they were uploaded to,
- * remote deletion targets the profile's *currently enabled* remotes. Remote
- * deletes are idempotent (an already-absent file counts as success) and
- * best-effort: a failing remote is logged but never blocks local pruning.
+ * number of copies (retention_count). A backup is pruned when EITHER rule
+ * matches: it is older than retention_days OR it falls outside the newest
+ * retention_count copies. Deleting a record also removes its archive and
+ * log file, mirroring the Backup table's delete().
  */
 final class RetentionManager
 {
 	/**
 	 * Prune old backups for a profile according to its retention settings.
 	 *
-	 * Called after a backup completes and from the periodic admin-side cleanup.
-	 * Only 'complete' and 'warning' records are considered — pending/running/
-	 * failed records are never pruned here.
+	 * Called after a backup completes. Only 'complete' and 'warning' records
+	 * are considered — pending/running/failed records are never pruned here.
 	 *
-	 * @param   object  $db           Database driver
-	 * @param   object  $profile      Profile row (needs id, retention_days, retention_count)
-	 * @param   int     $globalDays   Fallback max age (days) when the profile's is 0
-	 * @param   int     $globalCount  Fallback max copies when the profile's is 0
+	 * @param   object  $db       Database driver
+	 * @param   object  $profile  Profile row (needs id, retention_days, retention_count)
 	 *
 	 * @return  int  Number of backup records deleted
 	 */
-	public static function prune(object $db, object $profile, int $globalDays = 0, int $globalCount = 0): int
+	public static function prune(object $db, object $profile): int
 	{
 		$days  = (int) ($profile->retention_days ?? 0);
 		$count = (int) ($profile->retention_count ?? 0);
 
-		// A profile value of 0 means "use the global default".
-		$days  = $days > 0 ? $days : $globalDays;
-		$count = $count > 0 ? $count : $globalCount;
-
 		// No retention configured — nothing to do.
 		if ($days <= 0 && $count <= 0) {
 			return 0;
@@ -70,7 +48,7 @@ final class RetentionManager
 
 		// Newest first, so the index is the copy's position from the top.
 		$query = $db->getQuery(true)
-			->select($db->quoteName(['id', 'archivename', 'absolute_path', 'backupstart']))
+			->select($db->quoteName(['id', 'absolute_path', 'backupstart']))
 			->from($db->quoteName('#__mokosuitebackup_records'))
 			->where($db->quoteName('profile_id') . ' = ' . (int) $profile->id)
 			->where($db->quoteName('status') . ' IN (' . implode(',', array_map([$db, 'quote'], ['complete', 'warning'])) . ')')
@@ -83,7 +61,6 @@ final class RetentionManager
 		}
 
 		$cutoffTs = $days > 0 ? (time() - ($days * 86400)) : null;
-		$remotes  = self::loadEnabledRemotes($db, (int) $profile->id);
 		$deleted  = 0;
 
 		foreach ($records as $index => $record) {
@@ -95,7 +72,7 @@ final class RetentionManager
 				continue;
 			}
 
-			if (self::deleteRecord($db, $record, $remotes)) {
+			if (self::deleteRecord($db, $record)) {
 				$deleted++;
 			}
 		}
@@ -104,54 +81,12 @@ final class RetentionManager
 	}
 
 	/**
-	 * Delete backup records whose profile no longer exists.
+	 * Delete a single backup record and its on-disk archive + log file.
 	 *
-	 * Orphans have no owning profile and therefore no remote destinations to
-	 * reconcile, so only the local archive/log and DB row are removed.
-	 *
-	 * @param   object  $db  Database driver
-	 *
-	 * @return  int  Number of orphaned records deleted
-	 */
-	public static function pruneOrphans(object $db): int
-	{
-		$query = $db->getQuery(true)
-			->select($db->quoteName(['r.id', 'r.archivename', 'r.absolute_path'], ['id', 'archivename', 'absolute_path']))
-			->from($db->quoteName('#__mokosuitebackup_records', 'r'))
-			->join(
-				'LEFT',
-				$db->quoteName('#__mokosuitebackup_profiles', 'p')
-				. ' ON ' . $db->quoteName('p.id') . ' = ' . $db->quoteName('r.profile_id')
-			)
-			->where($db->quoteName('p.id') . ' IS NULL')
-			->where($db->quoteName('r.status') . ' IN (' . implode(',', array_map([$db, 'quote'], ['complete', 'warning'])) . ')');
-		$db->setQuery($query);
-		$orphans = $db->loadObjectList() ?: [];
-
-		$deleted = 0;
-
-		foreach ($orphans as $record) {
-			if (self::deleteRecord($db, $record, [])) {
-				$deleted++;
-			}
-		}
-
-		return $deleted;
-	}
-
-	/**
-	 * Delete a single backup record, its on-disk archive + log file, and the
-	 * archive copy on each enabled remote destination.
-	 *
-	 * The DB row is removed first; the local files are only unlinked if that
+	 * The DB row is removed first; the files are only unlinked if that
 	 * succeeds, so a failed delete never orphans the record from its files.
-	 * Remote deletion is best-effort and runs regardless.
-	 *
-	 * @param   object    $db       Database driver
-	 * @param   object    $record   Record row (needs id, archivename, absolute_path)
-	 * @param   object[]  $remotes  Enabled remote rows (type, params) for the profile
 	 */
-	private static function deleteRecord(object $db, object $record, array $remotes): bool
+	private static function deleteRecord(object $db, object $record): bool
 	{
 		$query = $db->getQuery(true)
 			->delete($db->quoteName('#__mokosuitebackup_records'))
@@ -178,69 +113,6 @@ final class RetentionManager
 			}
 		}
 
-		self::deleteFromRemotes($record, $remotes);
-
 		return true;
 	}
-
-	/**
-	 * Remove the record's archive from every enabled remote destination.
-	 *
-	 * Best-effort: each remote is tried independently and failures are logged,
-	 * never thrown, so one unreachable destination can't stall retention.
-	 *
-	 * @param   object    $record   Record row (needs archivename)
-	 * @param   object[]  $remotes  Enabled remote rows (type, params)
-	 */
-	private static function deleteFromRemotes(object $record, array $remotes): void
-	{
-		$archiveName = (string) ($record->archivename ?? '');
-
-		if ($archiveName === '' || empty($remotes)) {
-			return;
-		}
-
-		foreach ($remotes as $remote) {
-			try {
-				$params   = json_decode((string) ($remote->params ?? ''), true) ?: [];
-				$uploader = RemoteUploaderFactory::create((string) $remote->type, $params);
-				$result   = $uploader->delete($archiveName);
-
-				if (empty($result['success'])) {
-					error_log(
-						'MokoSuiteBackup: retention could not delete ' . $archiveName
-						. ' from ' . $remote->type . ' remote: ' . ($result['message'] ?? 'unknown error')
-					);
-				}
-			} catch (\Throwable $e) {
-				error_log(
-					'MokoSuiteBackup: retention remote-delete error for ' . $archiveName
-					. ' (' . ($remote->type ?? '?') . '): ' . $e->getMessage()
-				);
-			}
-		}
-	}
-
-	/**
-	 * Load the profile's enabled remote destinations (type + params only).
-	 *
-	 * Returns an empty array if the remotes table is missing (very old installs)
-	 * or the profile has none, so callers can iterate unconditionally.
-	 */
-	private static function loadEnabledRemotes(object $db, int $profileId): array
-	{
-		try {
-			$query = $db->getQuery(true)
-				->select($db->quoteName(['type', 'params']))
-				->from($db->quoteName('#__mokosuitebackup_remotes'))
-				->where($db->quoteName('profile_id') . ' = ' . $profileId)
-				->where($db->quoteName('enabled') . ' = 1')
-				->order($db->quoteName('ordering') . ' ASC');
-			$db->setQuery($query);
-
-			return $db->loadObjectList() ?: [];
-		} catch (\Throwable $e) {
-			return [];
-		}
-	}
 }

source/packages/com_mokosuitebackup/src/Engine/S3Uploader.php

@@ -75,54 +75,6 @@ class S3Uploader implements RemoteUploaderInterface
 		}
 	}
 
-	public function delete(string $remoteName): array
-	{
-		if (!extension_loaded('curl')) {
-			return ['success' => false, 'message' => 'PHP ext-curl is required for S3 deletes. Enable it in php.ini.'];
-		}
-
-		if (empty($this->accessKey) || empty($this->secretKey) || empty($this->bucket)) {
-			return ['success' => false, 'message' => 'S3 credentials or bucket not configured'];
-		}
-
-		try {
-			$objectKey = ($this->path ? $this->path . '/' : '') . $remoteName;
-			$url       = $this->getObjectUrl($objectKey);
-			$headers   = $this->signRequest('DELETE', $url, hash('sha256', ''));
-
-			$ch = curl_init();
-			curl_setopt_array($ch, [
-				CURLOPT_URL            => $url,
-				CURLOPT_CUSTOMREQUEST  => 'DELETE',
-				CURLOPT_RETURNTRANSFER => true,
-				CURLOPT_HTTPHEADER     => $headers,
-				CURLOPT_TIMEOUT        => 60,
-			]);
-
-			$response = curl_exec($ch);
-			$code     = curl_getinfo($ch, CURLINFO_HTTP_CODE);
-
-			if (curl_errno($ch)) {
-				$error = curl_error($ch);
-				curl_close($ch);
-
-				throw new \RuntimeException('cURL error: ' . $error);
-			}
-
-			curl_close($ch);
-
-			/* S3 DELETE returns 204 on success and — by design — also 204 when
-			   the key never existed. 404 is treated as already-gone too. */
-			if ($code === 204 || $code === 200 || $code === 404) {
-				return ['success' => true, 'message' => 'Deleted from S3: s3://' . $this->bucket . '/' . $objectKey];
-			}
-
-			return ['success' => false, 'message' => 'S3 DELETE failed (HTTP ' . $code . '): ' . substr((string) $response, 0, 300)];
-		} catch (\Throwable $e) {
-			return ['success' => false, 'message' => 'S3 delete failed: ' . $e->getMessage()];
-		}
-	}
-
 	public function testConnection(): array
 	{
 		if (empty($this->accessKey) || empty($this->secretKey) || empty($this->bucket)) {

source/packages/com_mokosuitebackup/src/Engine/SftpUploader.php

@@ -100,40 +100,6 @@ class SftpUploader implements RemoteUploaderInterface
 		}
 	}
 
-	public function delete(string $remoteName): array
-	{
-		if (empty($this->host) || empty($this->username)) {
-			return ['success' => false, 'message' => 'SFTP is not configured'];
-		}
-
-		$keyFile = null;
-
-		try {
-			if (!empty($this->keyData)) {
-				$keyFile = $this->writeTempKey();
-			}
-
-			/* rm -f exits 0 even when the file is already gone, so an
-			   already-deleted remote archive is treated as success. */
-			$remoteFile = $this->remotePath . '/' . $remoteName;
-			$cmd = $this->buildSshCommand('rm -f ' . escapeshellarg($remoteFile), $keyFile);
-
-			$output   = [];
-			$exitCode = 0;
-			exec($cmd . ' 2>&1', $output, $exitCode);
-
-			if ($exitCode !== 0) {
-				return ['success' => false, 'message' => 'SFTP delete failed: ' . implode(' ', $output)];
-			}
-
-			return ['success' => true, 'message' => 'Deleted from SFTP: ' . $remoteFile];
-		} catch (\Throwable $e) {
-			return ['success' => false, 'message' => 'SFTP delete failed: ' . $e->getMessage()];
-		} finally {
-			$this->cleanupTempKey($keyFile);
-		}
-	}
-
 	public function testConnection(): array
 	{
 		if (empty($this->host)) {

source/packages/com_mokosuitebackup/src/Engine/SteppedBackupEngine.php

@@ -806,7 +806,24 @@ class SteppedBackupEngine
 	 */
 	private function createUploaderFromParams(string $type, array $params): RemoteUploaderInterface
 	{
-		return RemoteUploaderFactory::create($type, $params);
+		$prefixMap = ['ftp' => 'ftp_', 'sftp' => 'sftp_', 's3' => 's3_', 'google_drive' => 'gdrive_'];
+		$prefix    = $prefixMap[$type] ?? '';
+
+		$prefixed = [];
+
+		foreach ($params as $key => $value) {
+			$prefixed[$prefix . $key] = $value;
+		}
+
+		$fake = (object) $prefixed;
+
+		return match ($type) {
+			'ftp'          => new FtpUploader($fake),
+			'sftp'         => new SftpUploader($fake),
+			'google_drive' => new GoogleDriveUploader($fake),
+			's3'           => new S3Uploader($fake),
+			default        => throw new \InvalidArgumentException('Unknown remote storage type: ' . $type),
+		};
 	}
 
 }

source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml

@@ -8,7 +8,7 @@
  -->
 <extension type="module" client="administrator" method="upgrade">
 	<name>Module - MokoSuiteBackup - cPanel</name>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-23</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="actionlog" method="upgrade">
 	<name>Action Log - MokoSuiteBackup</name>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="console" method="upgrade">
 	<name>Console - MokoSuiteBackup</name>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="content" method="upgrade">
 	<name>Content - MokoSuiteBackup</name>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <extension type="plugin" group="quickicon" method="upgrade">
 	<name>Quick Icon - MokoSuiteBackup</name>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_system_mokosuitebackup/language/en-GB/plg_system_mokosuitebackup.ini

@@ -7,10 +7,3 @@ PLG_SYSTEM_MOKOJOOMBACKUP_FIELD_MAX_AGE="Max Backup Age (days)"
 PLG_SYSTEM_MOKOJOOMBACKUP_FIELD_MAX_AGE_DESC="Delete backup records older than this many days."
 PLG_SYSTEM_MOKOJOOMBACKUP_FIELD_MAX_BACKUPS="Max Backup Count"
 PLG_SYSTEM_MOKOJOOMBACKUP_FIELD_MAX_BACKUPS_DESC="Keep at most this many completed backup records."
-PLG_SYSTEM_MOKOJOOMBACKUP_UPDATE_NOTICE="MokoSuiteBackup: a full-site backup is recommended before you update."
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_NOW="Back up now"
-PLG_SYSTEM_MOKOJOOMBACKUP_DISMISS="Dismiss"
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKING_UP="Backing up…"
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_COMPLETE="Backup complete — safe to update."
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_FAILED="Backup failed"
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_STARTING="Starting backup…"

source/packages/plg_system_mokosuitebackup/language/en-US/plg_system_mokosuitebackup.ini

@@ -7,10 +7,3 @@ PLG_SYSTEM_MOKOJOOMBACKUP_FIELD_MAX_AGE="Max Backup Age (days)"
 PLG_SYSTEM_MOKOJOOMBACKUP_FIELD_MAX_AGE_DESC="Delete backup records older than this many days."
 PLG_SYSTEM_MOKOJOOMBACKUP_FIELD_MAX_BACKUPS="Max Backup Count"
 PLG_SYSTEM_MOKOJOOMBACKUP_FIELD_MAX_BACKUPS_DESC="Keep at most this many completed backup records."
-PLG_SYSTEM_MOKOJOOMBACKUP_UPDATE_NOTICE="MokoSuiteBackup: a full-site backup is recommended before you update."
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_NOW="Back up now"
-PLG_SYSTEM_MOKOJOOMBACKUP_DISMISS="Dismiss"
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKING_UP="Backing up…"
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_COMPLETE="Backup complete — safe to update."
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_FAILED="Backup failed"
-PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_STARTING="Starting backup…"

source/packages/plg_system_mokosuitebackup/media/js/update-backup.js

@@ -1,261 +0,0 @@
-/**
- * MokoSuiteBackup — pre-update backup notice + live-progress modal.
- *
- * Injected by plg_system_mokosuitebackup on the Joomla core-update
- * (com_joomlaupdate) and extensions-update (com_installer&view=update) pages.
- *
- * Why a client-side modal: the server-side onExtensionBeforeUpdate backup runs
- * synchronously mid-request and cannot drive a browser modal. This offers an
- * on-demand "Back up now" button that runs the same stepped backup the
- * dashboard uses (ajax.init then a loop of ajax.step) and shows live progress.
- * On success it pings ajax.preupdateAck so the imminent server-side pre-update
- * backup is skipped (no duplicate backup) when the admin clicks Update.
- *
- * Config comes from Joomla.getOptions('plg_system_mokosuitebackup.preupdate').
- */
-(function () {
-	'use strict';
-
-	var cfg = (window.Joomla && Joomla.getOptions)
-		? Joomla.getOptions('plg_system_mokosuitebackup.preupdate', null)
-		: null;
-
-	if (!cfg || !cfg.ajaxUrl || !cfg.token) {
-		return;
-	}
-
-	var L = cfg.labels || {};
-	var running = false;
-	var backedUp = false;
-
-	document.addEventListener('DOMContentLoaded', function () {
-		injectNotice();
-	});
-
-	if (cfg.autoIntercept) {
-		setupInterception();
-	}
-
-	/* ── Phase 2: auto-run on the Update click ──────────────────────────────
-	 * Wrap window.Joomla.submitbutton so clicking the toolbar Update button
-	 * first runs the backup modal, then continues the original update once the
-	 * backup succeeds. submitbutton is synchronous, so we can't pause it — we
-	 * swallow the update task, run the async backup, and re-issue the original
-	 * task ourselves on success. The notice's "Back up now" button remains a
-	 * fallback for any flow that doesn't route through submitbutton. */
-	function setupInterception() {
-		if (!wrapSubmit()) {
-			document.addEventListener('DOMContentLoaded', wrapSubmit);
-		}
-	}
-
-	function wrapSubmit() {
-		var J = window.Joomla;
-
-		if (!J || typeof J.submitbutton !== 'function' || J.submitbutton.__msbWrapped) {
-			return !!(J && J.submitbutton && J.submitbutton.__msbWrapped);
-		}
-
-		var original = J.submitbutton;
-
-		var wrapped = function (task) {
-			if (!backedUp && !running && isUpdateTask(task)) {
-				var args = arguments;
-				runBackup().then(function (ok) {
-					if (ok) {
-						original.apply(window.Joomla, args);
-					}
-				});
-
-				return;
-			}
-
-			return original.apply(window.Joomla, arguments);
-		};
-
-		wrapped.__msbWrapped = true;
-		J.submitbutton = wrapped;
-
-		return true;
-	}
-
-	/* Only the actual "apply the update" tasks — never Find Updates / Clear
-	 * Cache (update.find / update.purge) which also start with "update". */
-	function isUpdateTask(task) {
-		return task === 'update.update' || task === 'update.install';
-	}
-
-	function injectNotice() {
-		var host = document.querySelector('main') || document.querySelector('#content') || document.body;
-
-		if (!host || document.getElementById('msb-preupdate-notice')) {
-			return;
-		}
-
-		var bar = document.createElement('div');
-		bar.id = 'msb-preupdate-notice';
-		bar.setAttribute('role', 'status');
-		bar.style.cssText = 'display:flex;align-items:center;gap:1rem;flex-wrap:wrap;'
-			+ 'margin:0 0 1rem 0;padding:.75rem 1rem;border:1px solid #f0c36d;'
-			+ 'background:#fcf8e3;border-radius:.35rem;color:#8a6d3b;font-size:.95rem;';
-
-		var text = document.createElement('span');
-		text.style.cssText = 'flex:1 1 auto;';
-		text.textContent = L.notice || 'A full-site backup is recommended before you update.';
-
-		var btn = document.createElement('button');
-		btn.type = 'button';
-		btn.id = 'msb-preupdate-run';
-		btn.className = 'btn btn-warning btn-sm';
-		btn.textContent = L.backupNow || 'Back up now';
-		btn.addEventListener('click', runBackup);
-
-		var dismiss = document.createElement('button');
-		dismiss.type = 'button';
-		dismiss.className = 'btn btn-link btn-sm';
-		dismiss.style.cssText = 'color:#8a6d3b;';
-		dismiss.textContent = L.dismiss || 'Dismiss';
-		dismiss.addEventListener('click', function () { bar.remove(); });
-
-		bar.appendChild(text);
-		bar.appendChild(btn);
-		bar.appendChild(dismiss);
-		host.insertBefore(bar, host.firstChild);
-	}
-
-	/* ── The live-progress overlay (dependency-free, mirrors the dashboard) ── */
-
-	function buildOverlay() {
-		var overlay = document.createElement('div');
-		overlay.id = 'msb-preupdate-overlay';
-		overlay.style.cssText = 'position:fixed;inset:0;z-index:10000;display:flex;'
-			+ 'align-items:center;justify-content:center;background:rgba(0,0,0,.5);';
-
-		var box = document.createElement('div');
-		box.style.cssText = 'width:min(480px,92vw);background:#fff;border-radius:.5rem;'
-			+ 'padding:1.5rem;box-shadow:0 10px 40px rgba(0,0,0,.3);';
-
-		var title = document.createElement('h3');
-		title.id = 'msb-pu-title';
-		title.style.cssText = 'margin:0 0 1rem 0;font-size:1.15rem;';
-		title.textContent = L.backingUp || 'Backing up…';
-
-		var track = document.createElement('div');
-		track.style.cssText = 'height:1.25rem;background:#e9ecef;border-radius:.35rem;overflow:hidden;';
-
-		var barfill = document.createElement('div');
-		barfill.id = 'msb-pu-bar';
-		barfill.style.cssText = 'height:100%;width:0;background:#198754;transition:width .3s ease;';
-		track.appendChild(barfill);
-
-		var status = document.createElement('div');
-		status.id = 'msb-pu-status';
-		status.style.cssText = 'margin-top:.75rem;font-size:.9rem;color:#555;';
-		status.textContent = L.starting || 'Starting backup…';
-
-		box.appendChild(title);
-		box.appendChild(track);
-		box.appendChild(status);
-		overlay.appendChild(box);
-		document.body.appendChild(overlay);
-
-		return { overlay: overlay, title: title, bar: barfill, status: status };
-	}
-
-	function setProgress(ui, progress, message) {
-		var pct = Math.max(0, Math.min(100, parseInt(progress, 10) || 0));
-		ui.bar.style.width = pct + '%';
-
-		if (message) {
-			ui.status.textContent = message;
-		}
-	}
-
-	function post(params) {
-		var body = new URLSearchParams();
-		body.append(cfg.token, '1');
-
-		Object.keys(params).forEach(function (k) {
-			body.append(k, params[k]);
-		});
-
-		return fetch(cfg.ajaxUrl, {
-			method: 'POST',
-			body: body,
-			headers: { 'X-Requested-With': 'XMLHttpRequest' }
-		}).then(function (r) { return r.json(); });
-	}
-
-	async function runBackup() {
-		if (running) {
-			return;
-		}
-
-		running = true;
-
-		var runBtn = document.getElementById('msb-preupdate-run');
-
-		if (runBtn) {
-			runBtn.disabled = true;
-		}
-
-		var ui = buildOverlay();
-		var guard = function (e) { e.preventDefault(); e.returnValue = ''; };
-		window.addEventListener('beforeunload', guard);
-
-		try {
-			var init = await post({ task: 'ajax.init', profile_id: cfg.profileId });
-
-			if (!init || init.error || !init.session_id) {
-				throw new Error((init && init.message) || 'Could not start backup');
-			}
-
-			setProgress(ui, init.progress, init.message);
-
-			var done = false;
-
-			while (!done) {
-				var step = await post({ task: 'ajax.step', session_id: init.session_id });
-
-				if (!step || step.error) {
-					throw new Error((step && step.message) || 'Backup step failed');
-				}
-
-				setProgress(ui, step.progress, step.message);
-				done = step.done || false;
-			}
-
-			/* Tell the server the pre-update backup is satisfied so the
-			   synchronous onExtensionBeforeUpdate backup is skipped. */
-			try { await post({ task: 'ajax.preupdateAck' }); } catch (ignore) {}
-
-			backedUp = true;
-			ui.title.textContent = L.complete || 'Backup complete — safe to update.';
-			setProgress(ui, 100, '');
-
-			var notice = document.getElementById('msb-preupdate-notice');
-
-			if (notice) {
-				notice.style.background = '#d1e7dd';
-				notice.style.borderColor = '#badbcc';
-				notice.style.color = '#0f5132';
-			}
-
-			setTimeout(function () { ui.overlay.remove(); }, 1500);
-
-			return true;
-		} catch (err) {
-			ui.title.textContent = (L.failed || 'Backup failed') + ': ' + err.message;
-			ui.bar.style.background = '#dc3545';
-
-			if (runBtn) {
-				runBtn.disabled = false;
-			}
-
-			return false;
-		} finally {
-			running = false;
-			window.removeEventListener('beforeunload', guard);
-		}
-	}
-})();

source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="system" method="upgrade">
 	<name>System - MokoSuiteBackup</name>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
@@ -29,10 +29,6 @@
 		<language tag="en-GB">language/en-GB/plg_system_mokosuitebackup.sys.ini</language>
 	</languages>
 
-	<media destination="plg_system_mokosuitebackup" folder="media">
-		<folder>js</folder>
-	</media>
-
 	<config>
 		<fields name="params">
 			<fieldset name="basic">

source/packages/plg_system_mokosuitebackup/src/Extension/MokoSuiteBackup.php

@@ -13,14 +13,8 @@ namespace Joomla\Plugin\System\MokoSuiteBackup\Extension;
 defined('_JEXEC') or die;
 
 use Joomla\CMS\Component\ComponentHelper;
-use Joomla\CMS\Document\HtmlDocument;
 use Joomla\CMS\Factory;
-use Joomla\CMS\Language\Text;
 use Joomla\CMS\Plugin\CMSPlugin;
-use Joomla\CMS\Router\Route;
-use Joomla\CMS\Session\Session;
-use Joomla\CMS\Uri\Uri;
-use Joomla\Component\MokoSuiteBackup\Administrator\Engine\RetentionManager;
 use Joomla\Component\MokoSuiteBackup\Administrator\Service\BackupRunner;
 use Joomla\Event\Event;
 use Joomla\Event\SubscriberInterface;
@@ -34,7 +28,6 @@ final class MokoSuiteBackup extends CMSPlugin implements SubscriberInterface
 		return [
 			'onAfterInitialise'        => 'onAfterInitialise',
 			'onAfterRoute'             => 'onAfterRoute',
-			'onBeforeCompileHead'      => 'onBeforeCompileHead',
 			'onExtensionBeforeUpdate'  => 'onExtensionBeforeUpdate',
 			'onExtensionBeforeUninstall' => 'onExtensionBeforeUninstall',
 		];
@@ -145,77 +138,6 @@ final class MokoSuiteBackup extends CMSPlugin implements SubscriberInterface
 		$this->cleanupOldSnapshots();
 	}
 
-	/**
-	 * Inject the pre-update backup notice + live-progress modal on the admin
-	 * update pages (com_joomlaupdate and com_installer's update view).
-	 *
-	 * The server-side onExtensionBeforeUpdate backup runs synchronously and
-	 * cannot drive a browser modal, so this offers an on-demand "Back up now"
-	 * button that runs the same stepped backup as the dashboard and shows live
-	 * progress. On success the client pings ajax.preupdateAck, which arms the
-	 * same throttle key runPreActionBackup() checks — so the subsequent server
-	 * update does not run a duplicate backup.
-	 */
-	public function onBeforeCompileHead(Event $event): void
-	{
-		$app = $this->getApplication();
-
-		if (!$app->isClient('administrator')) {
-			return;
-		}
-
-		$input  = $app->getInput();
-		$option = $input->getCmd('option', '');
-		$view   = $input->getCmd('view', '');
-
-		$onUpdatePage = $option === 'com_joomlaupdate'
-			|| ($option === 'com_installer' && $view === 'update');
-
-		if (!$onUpdatePage) {
-			return;
-		}
-
-		$params = ComponentHelper::getParams('com_mokosuitebackup');
-
-		// Respect the notice toggle and the pre-update backup feature flag.
-		if (!(int) $params->get('show_update_notice', 1) || !(int) $params->get('backup_before_update', 0)) {
-			return;
-		}
-
-		// Already backed up this session (within the throttle window)? Stay quiet.
-		$lastRun = (int) Factory::getSession()->get('mokosuitebackup.preaction_backup_before_update', 0);
-
-		if ($lastRun > 0 && (time() - $lastRun) < 600) {
-			return;
-		}
-
-		$doc = $app->getDocument();
-
-		if (!$doc instanceof HtmlDocument) {
-			return;
-		}
-
-		$doc->getWebAssetManager()->useScript('core');
-
-		$doc->addScriptOptions('plg_system_mokosuitebackup.preupdate', [
-			'ajaxUrl'       => Route::_('index.php?option=com_mokosuitebackup&format=json', false),
-			'token'         => Session::getFormToken(),
-			'profileId'     => (int) $params->get('default_profile', 1),
-			'autoIntercept' => (bool) (int) $params->get('preupdate_auto_intercept', 0),
-			'labels'    => [
-				'notice'    => Text::_('PLG_SYSTEM_MOKOJOOMBACKUP_UPDATE_NOTICE'),
-				'backupNow' => Text::_('PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_NOW'),
-				'dismiss'   => Text::_('PLG_SYSTEM_MOKOJOOMBACKUP_DISMISS'),
-				'backingUp' => Text::_('PLG_SYSTEM_MOKOJOOMBACKUP_BACKING_UP'),
-				'starting'  => Text::_('PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_STARTING'),
-				'complete'  => Text::_('PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_COMPLETE'),
-				'failed'    => Text::_('PLG_SYSTEM_MOKOJOOMBACKUP_BACKUP_FAILED'),
-			],
-		]);
-
-		$doc->addScript(Uri::root(true) . '/media/plg_system_mokosuitebackup/js/update-backup.js', [], ['defer' => true]);
-	}
-
 	/**
 	 * Remove backup records and files per profile retention settings.
 	 * Each profile can override the global max_age_days and max_backups.
@@ -319,28 +241,108 @@ final class MokoSuiteBackup extends CMSPlugin implements SubscriberInterface
 
 	private function doCleanup(): void
 	{
-		$db             = Factory::getDbo();
-		$params         = ComponentHelper::getParams('com_mokosuitebackup');
-		$globalMaxAge   = (int) $params->get('max_age_days', 30);
-		$globalMaxCount = (int) $params->get('max_backups', 10);
+		$db              = Factory::getDbo();
+		$globalMaxAge    = (int) ComponentHelper::getParams('com_mokosuitebackup')->get('max_age_days', 30);
+		$globalMaxCount  = (int) ComponentHelper::getParams('com_mokosuitebackup')->get('max_backups', 10);
 
-		// Load all published profiles with their retention settings.
+		// Load all published profiles with their retention settings
 		$query = $db->getQuery(true)
-			->select($db->quoteName(['id', 'retention_days', 'retention_count']))
+			->select([$db->quoteName('id'), $db->quoteName('retention_days'), $db->quoteName('retention_count')])
 			->from($db->quoteName('#__mokosuitebackup_profiles'))
 			->where($db->quoteName('published') . ' = 1');
 		$db->setQuery($query);
-		$profiles = $db->loadObjectList() ?: [];
+		$profiles = $db->loadObjectList();
 
-		// Delegate to the single retention authority. RetentionManager prunes by
-		// age OR count (with these globals as the per-profile fallback) and also
-		// removes each pruned archive from the profile's remote destinations.
 		foreach ($profiles as $profile) {
-			RetentionManager::prune($db, $profile, $globalMaxAge, $globalMaxCount);
+			$maxAge   = (int) $profile->retention_days > 0 ? (int) $profile->retention_days : $globalMaxAge;
+			$maxCount = (int) $profile->retention_count > 0 ? (int) $profile->retention_count : $globalMaxCount;
+			$pid      = (int) $profile->id;
+
+			// Delete by age for this profile
+			$cutoff = date('Y-m-d H:i:s', strtotime("-{$maxAge} days"));
+			$query  = $db->getQuery(true)
+				->select('id, absolute_path')
+				->from($db->quoteName('#__mokosuitebackup_records'))
+				->where($db->quoteName('profile_id') . ' = ' . $pid)
+				->where($db->quoteName('backupstart') . ' < ' . $db->quote($cutoff))
+				->where($db->quoteName('status') . ' = ' . $db->quote('complete'));
+			$db->setQuery($query);
+			$expired = $db->loadObjectList();
+
+			foreach ($expired as $record) {
+				$this->deleteBackupRecord($db, $record);
+			}
+
+			// Enforce max count for this profile (keep newest)
+			$query = $db->getQuery(true)
+				->select('COUNT(*)')
+				->from($db->quoteName('#__mokosuitebackup_records'))
+				->where($db->quoteName('profile_id') . ' = ' . $pid)
+				->where($db->quoteName('status') . ' = ' . $db->quote('complete'));
+			$db->setQuery($query);
+			$totalCount = (int) $db->loadResult();
+
+			if ($totalCount > $maxCount) {
+				$excess = $totalCount - $maxCount;
+				$query  = $db->getQuery(true)
+					->select('id, absolute_path')
+					->from($db->quoteName('#__mokosuitebackup_records'))
+					->where($db->quoteName('profile_id') . ' = ' . $pid)
+					->where($db->quoteName('status') . ' = ' . $db->quote('complete'))
+					->order($db->quoteName('backupstart') . ' ASC');
+				$db->setQuery($query, 0, $excess);
+				$oldest = $db->loadObjectList();
+
+				foreach ($oldest as $record) {
+					$this->deleteBackupRecord($db, $record);
+				}
+			}
 		}
 
-		// Records whose profile was deleted (local files + DB row only).
-		RetentionManager::pruneOrphans($db);
+		// Also clean up orphaned records (profile deleted but records remain)
+		$query = $db->getQuery(true)
+			->select('r.id, r.absolute_path')
+			->from($db->quoteName('#__mokosuitebackup_records', 'r'))
+			->join('LEFT', $db->quoteName('#__mokosuitebackup_profiles', 'p') . ' ON p.id = r.profile_id')
+			->where('p.id IS NULL')
+			->where($db->quoteName('r.status') . ' = ' . $db->quote('complete'));
+		$db->setQuery($query);
+		$orphans = $db->loadObjectList();
+
+		foreach ($orphans as $record) {
+			$this->deleteBackupRecord($db, $record);
+		}
+	}
+
+	/**
+	 * Delete a backup record and its archive file.
+	 */
+	private function deleteBackupRecord(object $db, object $record): void
+	{
+		if (!empty($record->absolute_path) && is_file($record->absolute_path)) {
+			if (!@unlink($record->absolute_path)) {
+				error_log('MokoSuiteBackup: Could not delete backup file (id=' . $record->id . '): ' . $record->absolute_path);
+
+				return;
+			}
+
+			$logPath = preg_replace('/\.(zip|tar\.gz)$/i', '.log', $record->absolute_path);
+
+			if (is_file($logPath)) {
+				@unlink($logPath);
+			}
+		}
+
+		try {
+			$db->setQuery(
+				$db->getQuery(true)
+					->delete($db->quoteName('#__mokosuitebackup_records'))
+					->where($db->quoteName('id') . ' = ' . (int) $record->id)
+			);
+			$db->execute();
+		} catch (\Exception $e) {
+			error_log('MokoSuiteBackup: Could not delete backup record ' . $record->id . ': ' . $e->getMessage());
+		}
 	}
 
 	/**

source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="task" method="upgrade">
 	<name>Task - MokoSuiteBackup</name>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml

@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="webservices" method="upgrade">
 	<name>Web Services - MokoSuiteBackup</name>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>

source/pkg_mokosuitebackup.xml

@@ -8,7 +8,7 @@
 <extension type="package" method="upgrade">
 	<name>Package - MokoSuiteBackup</name>
 	<packagename>mokosuitebackup</packagename>
-	<version>02.58.09</version>
+	<version>02.58.00</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>