356 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Jonathan Miller	9990240d2d	fix: remaining audit findings — OOM, security, error handling (#81) ... CRITICAL: - #73: S3Uploader now streams file via CURLOPT_PUT/INFILE instead of loading entire file into RAM with file_get_contents - #74: DatabaseDumper gains dumpToFile() that streams SQL to disk; BackupEngine uses addFile() instead of addFromString() to avoid holding the entire dump in memory - #75: AkeebaImporter removes unserialize() — only uses json_decode, skips legacy serialized filter data to prevent object injection MEDIUM (also fixed): - BackupEngine: $archiveName initialized before try block (prevents undefined variable in catch) - BackupEngine: plaintext archive deleted on encryption failure - BackupEngine: temp SQL file cleaned up in both success and failure - BackupEngine: createArchiver() throws on unknown format instead of silently falling back to ZIP - TarGzArchiver: intermediate .tar cleaned up in finally block Closes #73, closes #74, closes #75 Ref #81	2026-06-21 18:16:46 -05:00
jmiller	418db394a4	Merge pull request 'chore: remove automation directory' (#82) from fix/remove-automation into main	2026-06-21 23:10:42 +00:00
jmiller	d939d8c9d7	Merge pull request 'fix: Critical and high audit findings (#81)' (#83) from fix/audit-critical-high into main	2026-06-21 23:10:19 +00:00
gitea-actions[bot]	6383e9b111	chore(version): pre-release bump to 01.27.03-dev [skip ci]	2026-06-21 23:10:10 +00:00
Jonathan Miller	2395a4eabc	fix: critical and high audit findings (#81) ... Fixes all critical and high severity issues from the codebase audit: CRITICAL: - #71: RestoreCommand passed wrong args to RestoreEngine (filepath instead of record ID) — CLI restore was completely broken - #72: JpaUnarchiver path traversal — added traversal rejection and realpath boundary check to prevent writes outside staging dir - #77: RestoreEngine staging path sanitized — $record->tag stripped of non-alphanumeric characters HIGH: - #75: (noted, AkeebaImporter unserialize needs separate refactor) - #76: BackupTable now deletes DB row before file — prevents data loss if DB delete fails - #78: API profiles endpoint now masks sensitive fields (passwords, keys, tokens) with '***' - #79: Webcron handler adds return after sendJsonResponse — prevents execution falling through on non-terminal close() - #80: BackupModel/ProfileModel loadFormData() now casts array to object — prevents TypeError on PHP 8.x form state restore PREFLIGHT HARDENING: - PreflightCheck::run() wrapped in try-catch for DB exceptions - mkdir() failure now includes actual error reason - Unresolved placeholders generate a warning instead of silent return Closes #71, closes #76, closes #77, closes #78, closes #79, closes #80 Ref #72, ref #81	2026-06-21 18:08:58 -05:00
Jonathan Miller	1ec8ec8f6d	chore: remove automation directory	2026-06-21 18:03:55 -05:00
jmiller	8df630c529	chore: sync repo-health.yml from Template-Generic [skip ci]	2026-06-21 22:56:04 +00:00
jmiller	5c8503e79e	chore: sync pr-check.yml from Template-Generic [skip ci]	2026-06-21 22:56:02 +00:00
jmiller	3a087d7859	chore: sync issue-branch.yml from Template-Generic [skip ci]	2026-06-21 22:56:01 +00:00
jmiller	58d3b812a7	chore: sync auto-bump.yml from Template-Generic [skip ci]	2026-06-21 22:55:58 +00:00
gitea-actions[bot]	ac3727f22f	chore: promote changelog [Unreleased] → [01.27.00]	2026-06-21 22:54:50 +00:00
gitea-actions[bot]	43a4e552ce	chore(release): build 01.27.00 [skip ci]	2026-06-21 22:54:47 +00:00
jmiller	a532e639ea	Merge pull request 'feat: Pre-flight checks before backup starts (#67)' (#70) from feature/67-preflight-checks into main	2026-06-21 22:54:34 +00:00
gitea-actions[bot]	f099ad8fe9	chore(version): auto-bump patch 01.26.02-dev [skip ci]	2026-06-21 22:54:29 +00:00
Jonathan Miller	dbed0d0da7	fix: address PR review — remove dead code, consistent warnings key ... - Remove dead checkRequiredExtensions() method (superseded by PreflightCheck) - Add 'warnings' key to ALL return paths in BackupEngine::run() and SteppedBackupEngine::init() to prevent undefined key access on PHP 8.x - Include preflight warnings in success, failure, and early-exit returns	2026-06-21 17:54:11 -05:00
gitea-actions[bot]	617c103055	chore(version): auto-bump patch 01.26.01-dev [skip ci]	2026-06-21 22:47:28 +00:00
Jonathan Miller	edb202071c	feat: add pre-flight checks before backup starts (#67) ... Validate backup prerequisites before creating any record, catching common issues early with clear messages instead of failing mid-backup. Pre-flight checks: - Required PHP extensions (zip, pdo, pdo_mysql, mbstring, curl) - Backup directory exists and is writable - Sufficient disk space (last backup size + 20% buffer, skipped if no previous backup exists) - No other backup already running for this profile - Excluded tables exist in database (warns on missing) - Remote storage credentials minimally configured (FTP/S3/GDrive) Errors block the backup; warnings are logged and displayed but allow the backup to proceed. Integrated into both BackupEngine::run() and SteppedBackupEngine::init() before any record is inserted. UI: AJAX init response includes warnings array, displayed in the stepped backup progress modal. Closes #67	2026-06-21 17:47:13 -05:00
gitea-actions[bot]	c5fa755006	chore: promote changelog [Unreleased] → [01.26.00]	2026-06-21 22:36:24 +00:00
gitea-actions[bot]	92e94ddc17	chore(release): build 01.26.00 [skip ci]	2026-06-21 22:36:22 +00:00
jmiller	0f88aa0055	Merge pull request 'feat: Content snapshots, restore UI, and config hardening (v01.25.00)' (#69) from feature/47-backup-status-helper into main	2026-06-21 22:34:53 +00:00
Jonathan Miller	0a4f896f31	Merge remote-tracking branch 'origin/feature/47-backup-status-helper' into feature/47-backup-status-helper	2026-06-21 17:32:53 -05:00
Jonathan Miller	8d67dfbc42	Merge remote-tracking branch 'origin/main' into feature/47-backup-status-helper ... # Conflicts: # .mokogitea/workflows/issue-branch.yml # .mokogitea/workflows/pr-check.yml # README.md # mokosuitebackup.xml # source/packages/com_mokosuitebackup/mokosuitebackup.xml # source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml # source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml # source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml # source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml # source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml # source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml # source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml # source/pkg_mokosuitebackup.xml	2026-06-21 17:29:58 -05:00
gitea-actions[bot]	c2a88a898d	chore(version): auto-bump patch 01.25.02-dev [skip ci]	2026-06-21 22:22:40 +00:00
Jonathan Miller	d5421738b7	fix: address PR review findings — error handling and safety ... Fixes from code review and silent failure audit: - SnapshotRestoreEngine: catch only duplicate key errors (MySQL 1062) in merge mode, re-throw all other exceptions instead of swallowing - SnapshotRestoreEngine: add json_last_error() check for better error messages on corrupt snapshot files - SnapshotRestoreEngine: log warnings when set_time_limit/ini_set fail - SnapshotEngine: use strlen($json) instead of filesize() to avoid race conditions; catch \Exception instead of \Throwable - SnapshotsController: remove @unlink suppression, add try-catch around delete loop with partial failure reporting - script.php: add user-facing warning when webcron secret generation fails (was silently swallowed, inconsistent with other catch blocks)	2026-06-21 17:21:55 -05:00
jmiller	1962e39032	chore: sync auto-release.yml from Template-Generic [skip ci]	2026-06-21 22:03:24 +00:00
Jonathan Miller	658ed77090	Merge remote-tracking branch 'origin/feature/47-backup-status-helper' into feature/47-backup-status-helper	2026-06-21 16:59:54 -05:00
Jonathan Miller	3bd103f0af	chore: normalize CRLF in workflow files	2026-06-21 16:59:54 -05:00
Jonathan Miller	854383a899	fix: scope module DELETE to snapshot IDs in replace mode ... The truncateFiltered() method ran unfiltered DELETE FROM #__modules in replace mode, which would wipe ALL site modules (admin toolbar, login, menus) — not just the ones in the snapshot. Now scoped to only delete modules whose IDs exist in the snapshot data. Also scopes #__modules_menu delete to snapshot module IDs, and adds defense-in-depth validation of restore_mode in the controller.	2026-06-21 15:50:41 -05:00
gitea-actions[bot]	43c73d20e8	chore(version): auto-bump patch 01.25.01-dev [skip ci]	2026-06-21 20:30:09 +00:00
Jonathan Miller	ef31713029	feat: content snapshots, restore UI, and config hardening (v01.25.00) ... Add content snapshot system for lightweight article/category/module versioning independent of full backups. Snapshots store as JSON files with replace or merge restore modes, wrapped in DB transactions. - SnapshotEngine: dumps articles, categories, modules + related tables (workflow_associations, tag maps, frontpage) to JSON - SnapshotRestoreEngine: replace (clean slate) or merge (upsert) mode - Full MVC: controller, models, view, template with create/restore modals - New ACL permission: mokosuitebackup.snapshot.manage - Submenu entry with camera icon, upgrade SQL for snapshots table Improve full-site restore UI with confirmation modal offering options for files, database, preserve config, and encryption password. Config improvements: - WebcronSecretField: CSPRNG generator, strength meter, rejects weak patterns (password, admin, secret), enforces min 16 chars - IpWhitelistField: table-based management, current IP detection with one-click "Add my IP" button - Default profile shows "Title (#ID)" format - Default backup dir uses [DEFAULT_DIR] placeholder - Install script generates random 32-char webcron secret - Dashboard quick actions: full-width dropdown with button below	2026-06-21 15:25:53 -05:00
jmiller	4c1615e337	chore: sync pre-release.yml from Template-Generic [skip ci]	2026-06-21 16:06:03 +00:00
jmiller	26a13ef692	chore: sync composer-publish.yml from Template-Generic [skip ci]	2026-06-21 06:35:25 +00:00
jmiller	f55836df0d	chore: sync workflow-sync-trigger.yml from Template-Generic [skip ci]	2026-06-21 01:29:19 +00:00
jmiller	680e242465	chore: sync auto-release.yml from Template-Generic [skip ci]	2026-06-21 01:29:18 +00:00
jmiller	e2b12ef313	ci: sync rc-revert.yml from Template-Joomla [skip ci]	2026-06-21 00:15:06 +00:00
jmiller	d1ca1d8e48	ci: sync issue-branch.yml from Template-Joomla [skip ci]	2026-06-21 00:14:37 +00:00
jmiller	b2f8ae8b1f	ci: sync ci-joomla.yml from Template-Joomla [skip ci]	2026-06-21 00:14:13 +00:00
jmiller	3d84e8079f	chore: sync repo-health.yml from Template-Generic [skip ci]	2026-06-20 23:47:05 +00:00
jmiller	cb68071155	chore: sync pr-check.yml from Template-Generic [skip ci]	2026-06-20 23:47:04 +00:00
jmiller	eeba315a0d	chore: sync issue-branch.yml from Template-Generic [skip ci]	2026-06-20 23:47:04 +00:00
jmiller	91bc675ea7	chore: sync gitleaks.yml from Template-Generic [skip ci]	2026-06-20 23:47:03 +00:00
jmiller	1b042311fb	chore: sync ci-generic.yml from Template-Generic [skip ci]	2026-06-20 23:47:02 +00:00
jmiller	b4927163a6	chore: sync auto-bump.yml from Template-Generic [skip ci]	2026-06-20 23:47:01 +00:00
gitea-actions[bot]	571c0a7143	chore: promote changelog [Unreleased] → [01.25.00]	2026-06-20 23:31:25 +00:00
gitea-actions[bot]	2d7359cefd	chore(release): build 01.25.00 [skip ci]	2026-06-20 23:31:22 +00:00
jmiller	c828c46a4b	Merge pull request 'feat: add BackupStatusHelper for bridge integration' (#53) from feature/47-backup-status-helper into main	2026-06-20 23:31:11 +00:00
gitea-actions[bot]	38a98e5ea3	chore(version): auto-bump patch 01.24.01-dev [skip ci]	2026-06-20 23:31:10 +00:00
Jonathan Miller	a5a2f48e7c	feat: add BackupStatusHelper for bridge integration (#47) ... Static helper class for external consumers (bridge plugins, MCP servers) to query backup status without bootstrapping the full component. Methods: - isInstalled(): check if MokoSuiteBackup is installed and enabled - getLatestRecord(): get the most recent completed/failed backup - getStatusSummary(): full heartbeat payload with latest status, all-time/7-day totals, and consecutive success streak	2026-06-20 18:30:54 -05:00
jmiller	70f25f6e79	chore: sync repo-health.yml from Template-Generic [skip ci]	2026-06-20 22:30:30 +00:00
jmiller	26dd5cf5c2	chore: sync rc-revert.yml from Template-Generic [skip ci]	2026-06-20 22:30:29 +00:00