Merge pull request 'fix(runbackup): failed pre-update backup blocks the update' (#272) from fix/no-update-on-error into dev

source/packages/com_mokosuitebackup/language/en-GB/com_mokosuitebackup.ini

@@ -356,6 +356,7 @@ COM_MOKOJOOMBACKUP_RUNBACKUP_CANCEL="Cancel backup"
 COM_MOKOJOOMBACKUP_RUNBACKUP_CANCEL_CONFIRM1="Cancel the backup that is in progress?"
 COM_MOKOJOOMBACKUP_RUNBACKUP_CANCEL_CONFIRM2="Are you sure? The backup will be stopped and the update will NOT continue."
 COM_MOKOJOOMBACKUP_RUNBACKUP_CANCELLING="Cancelling…"
+COM_MOKOJOOMBACKUP_RUNBACKUP_FAILED_NO_UPDATE="Backup failed — the update was not started. Retry the backup, or go back without updating."
 COM_MOKOJOOMBACKUP_RUNBACKUP_CONTINUE_UPDATE="Continue the update"
 
 COM_MOKOJOOMBACKUP_CONFIG_CLEANUP="Cleanup Defaults"

source/packages/com_mokosuitebackup/language/en-US/com_mokosuitebackup.ini

@@ -78,6 +78,7 @@ COM_MOKOJOOMBACKUP_RUNBACKUP_CANCEL="Cancel backup"
 COM_MOKOJOOMBACKUP_RUNBACKUP_CANCEL_CONFIRM1="Cancel the backup that is in progress?"
 COM_MOKOJOOMBACKUP_RUNBACKUP_CANCEL_CONFIRM2="Are you sure? The backup will be stopped and the update will NOT continue."
 COM_MOKOJOOMBACKUP_RUNBACKUP_CANCELLING="Cancelling…"
+COM_MOKOJOOMBACKUP_RUNBACKUP_FAILED_NO_UPDATE="Backup failed — the update was not started. Retry the backup, or go back without updating."
 COM_MOKOJOOMBACKUP_RUNBACKUP_CONTINUE_UPDATE="Continue the update"
 
 COM_MOKOJOOMBACKUP_CONFIG_CLEANUP="Cleanup Defaults"

source/packages/com_mokosuitebackup/tmpl/runbackup/default.php

@@ -90,6 +90,7 @@ $config = [
 		'cancelConfirm1' => Text::_('COM_MOKOJOOMBACKUP_RUNBACKUP_CANCEL_CONFIRM1'),
 		'cancelConfirm2' => Text::_('COM_MOKOJOOMBACKUP_RUNBACKUP_CANCEL_CONFIRM2'),
 		'cancelling'     => Text::_('COM_MOKOJOOMBACKUP_RUNBACKUP_CANCELLING'),
+		'failedNoUpdate' => Text::_('COM_MOKOJOOMBACKUP_RUNBACKUP_FAILED_NO_UPDATE'),
 	],
 ];
 
@@ -304,7 +305,10 @@ $this->getDocument()->addStyleSheet(Uri::root(true) . '/media/com_mokosuitebacku
 		el.bar.classList.add('is-danger');
 		if (el.warn) { el.warn.classList.add('d-none'); }
 		el.title.textContent = L.failed || 'Backup failed';
-		setStatus(message || 'Backup failed');
+		/* Pre-update/uninstall flow: the backup failed, so the update must NOT
+		   run. We deliberately do NOT offer a "continue without backup" option
+		   here — the only ways forward are to retry the backup or go back. */
+		setStatus(CFG.returnUrl ? (L.failedNoUpdate || 'Backup failed — the update was not started. Retry the backup, or go back without updating.') : (message || 'Backup failed'));
 		hideCancel();
 		showActions();
 
@@ -312,15 +316,11 @@ $this->getDocument()->addStyleSheet(Uri::root(true) . '/media/com_mokosuitebacku
 		el.retry.classList.remove('d-none');
 		el.retry.onclick = function () {
 			el.retry.classList.add('d-none');
-			el.continue.classList.add('d-none');
 			el.bar.classList.remove('is-danger');
 			el.bar.classList.add('is-animated');
 			run();
 		};
 
-		if (CFG.returnUrl) {
-			showBtn(el.continue, L.continue || 'Continue without backup', CFG.returnUrl);
-		}
 		showBtn(el.dashboard, L.dashboard || 'Back to dashboard', CFG.dashboardUrl);
 	}