@
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 21s
Generic: Project CI / Tests (pull_request) Failing after 5s
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Generic: Project CI / Lint & Validate (pull_request) Successful in 9s
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Universal: PR Check / Secret Scan (pull_request) Successful in 5s
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 8s
Branch Cleanup / Delete merged branch (pull_request) Successful in 1s
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Universal: PR Check / Validate PR (pull_request) Failing after 18s
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 21s
Generic: Project CI / Tests (pull_request) Failing after 5s
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Generic: Project CI / Lint & Validate (pull_request) Successful in 9s
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Universal: PR Check / Secret Scan (pull_request) Successful in 5s
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 8s
Branch Cleanup / Delete merged branch (pull_request) Successful in 1s
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Universal: PR Check / Validate PR (pull_request) Failing after 18s
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Universal: PR Check / Report Issues (pull_request) Has been cancelled
fix(installer): extension update now auto-continues after pre-update backup Two bugs in the client-side resume path made the extension update return to the selection screen (requiring a manual re-select + re-submit) instead of continuing after the backup: 1. The re-fire clicked the OUTER <joomla-toolbar-button> (which carries the task attr), but the web component binds its click handler to the INNER <button>. Clicking the wrapper did nothing. Now clicks the inner element. 2. list-selection toolbar buttons start DISABLED and only enable when boxchecked fires a `change` event. We set boxchecked.value but never dispatched change, so the button stayed disabled and executeTask() no-opd.
This commit is contained in:
@@ -131,20 +131,34 @@
|
||||
if (box) { box.checked = true; }
|
||||
});
|
||||
|
||||
/* Joomla's list-check reads boxchecked — set it so the re-fire passes. */
|
||||
/* Restore boxchecked AND fire its `change` event. Joomla's toolbar web
|
||||
component (joomla-toolbar-button) keeps a list-selection button
|
||||
DISABLED until boxchecked changes via a change event — setting the
|
||||
value alone leaves the button disabled, so executeTask() would no-op
|
||||
and the update never submits (it just returns to the list). */
|
||||
var bc = form.querySelector('input[name="boxchecked"]');
|
||||
if (bc) { bc.value = (data.cids || []).length; }
|
||||
if (bc) {
|
||||
bc.value = (data.cids || []).length;
|
||||
bc.dispatchEvent(new Event('change', { bubbles: true }));
|
||||
}
|
||||
}
|
||||
|
||||
window.__msbResuming = true;
|
||||
|
||||
var btn = document.querySelector('[task="' + data.task + '"]');
|
||||
/* Re-fire the toolbar action. The `task` attribute is on the OUTER
|
||||
<joomla-toolbar-button>, but its click handler is bound to the INNER
|
||||
<button>/<a>, so click that inner element (clicking the wrapper does
|
||||
nothing). Fall back to Joomla.submitbutton if the button isn't found. */
|
||||
window.setTimeout(function () {
|
||||
var wc = document.querySelector('[task="' + data.task + '"]');
|
||||
var inner = wc ? (wc.querySelector('button, a') || wc) : null;
|
||||
|
||||
if (btn) {
|
||||
window.setTimeout(function () { btn.click(); }, 300);
|
||||
} else if (window.Joomla && typeof Joomla.submitbutton === 'function') {
|
||||
Joomla.submitbutton(data.task);
|
||||
}
|
||||
if (inner) {
|
||||
inner.click();
|
||||
} else if (window.Joomla && typeof Joomla.submitbutton === 'function') {
|
||||
Joomla.submitbutton(data.task);
|
||||
}
|
||||
}, 300);
|
||||
}
|
||||
|
||||
if (document.readyState === 'loading') {
|
||||
|
||||
Reference in New Issue
Block a user