fix: restore missing subject arg in MokoRestore str_replace (standalone gen)
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 30s
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 30s
MokoRestore::generateStandaloneScript() rewrites the 'Backup Archive' pre-check via str_replace(ORIG, REPL) but was missing the third $php subject argument, so every standalone-mode backup fatally errored with 'str_replace() expects at least 3 arguments, 2 given' at the 'Generating standalone restore.php...' step. The archive still finalized and uploaded, but no restore.php was produced -- the underlying cause of #226 (restore script missing on the remote). Refs #226 Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
This commit is contained in:
@@ -3,6 +3,7 @@
|
||||
## [Unreleased]
|
||||
|
||||
### Fixed
|
||||
- Standalone restore script generation no longer aborts backups with `str_replace() expects at least 3 arguments, 2 given`. `MokoRestore::generateStandaloneScript()` had a `str_replace()` call (the "Backup Archive" pre-check rewrite) that was missing its `$php` subject argument, so **every** standalone-mode backup fatally errored while "Generating standalone restore.php…" — the archive still finalized and uploaded, but no `restore.php` was ever produced (the true root cause behind #226). (#226)
|
||||
- Remote upload: the standalone restore script upload is no longer silent — its result is now checked and logged, and a failed restore-script upload marks the backup as `warning` (previously the result was discarded, so a missing restore script on the remote went unreported while the archive still showed success). (#226)
|
||||
|
||||
## [02.58.00] --- 2026-07-06
|
||||
|
||||
@@ -204,7 +204,8 @@ ORIG,
|
||||
'ok' => $backupCount > 0,
|
||||
'hint' => 'Place one or more backup ZIP files in the same directory as ' . basename($_SERVER['SCRIPT_NAME']),
|
||||
];
|
||||
REPL
|
||||
REPL,
|
||||
$php
|
||||
);
|
||||
|
||||
/* Modify remaining pre-checks to use getSelectedBackupFile() */
|
||||
|
||||
Reference in New Issue
Block a user