MokoConsulting/MokoOnyx
1
0
Fork 0
Code Issues 7 Pull Requests 2 Releases 5 Wiki Activity

fix(template): sidebar/footer menu links invisible in light theme (.nav-link color leak) #181

Merged
jmiller merged 2 commits from fix/nav-link-color-leak into main 2026-07-19 09:29:18 +00:00
Conversation 1 Commits 2 Files Changed 8
+16 -9
jmiller commented 2026-07-19 08:05:22 +00:00
Owner
Copy Link
Copy Source

Problem

Menu links in light-background positions (sidebar, footer, bottom) render white-on-white / invisible in the light theme — reported on https://mokoconsulting.tech/legal/privacy-policy (right-hand Support menu).

Root cause

The global .nav-link rule set color: var(--nav-link-color), and the theme defines --nav-link-color: white for the dark header navbar. Any Joomla menu module using Bootstrap .nav-link (sidebar/footer/bottom) inherited that white on a light surface. Confirmed live via computed styles + CSS rule inspection.

Fix

Point the global .nav-link at --link-color (theme-aware: #224faa light, #8ab4f8 dark). The header navbar keeps white via its own higher-specificity .container-header .nav-link rule; the drawer (.offcanvas .mod-menu .nav-link) and topbar (.container-topbar a) have their own rules — all unaffected.

1-line CSS change + changelog. Verified regression-safe against header/drawer/topbar surfaces.

## Problem Menu links in light-background positions (sidebar, footer, bottom) render **white-on-white / invisible** in the light theme — reported on https://mokoconsulting.tech/legal/privacy-policy (right-hand Support menu). ## Root cause The global `.nav-link` rule set `color: var(--nav-link-color)`, and the theme defines `--nav-link-color: white` for the **dark header navbar**. Any Joomla menu module using Bootstrap `.nav-link` (sidebar/footer/bottom) inherited that white on a light surface. Confirmed live via computed styles + CSS rule inspection. ## Fix Point the global `.nav-link` at `--link-color` (theme-aware: `#224faa` light, `#8ab4f8` dark). The header navbar keeps white via its own higher-specificity `.container-header .nav-link` rule; the drawer (`.offcanvas .mod-menu .nav-link`) and topbar (`.container-topbar a`) have their own rules — all unaffected. 1-line CSS change + changelog. Verified regression-safe against header/drawer/topbar surfaces.
jmiller commented 2026-07-19 08:15:36 +00:00
Author
Owner
Copy Link
Copy Source

Wiki reminder: docs are wiki-first -- if this PR changes behavior, usage, config, or standards, please update the repo wiki before/after merge. (non-blocking)

<!-- wiki-reminder --> **Wiki reminder:** docs are wiki-first -- if this PR changes behavior, usage, config, or standards, please update the repo wiki before/after merge. _(non-blocking)_
jmiller added 1 commit 2026-07-19 09:29:04 +00:00
fix(template): stop header navbar white leaking into content menus (.nav-link)
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 16s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 12s
Details
Generic: Project CI / Tests (pull_request) Failing after 8s
Details
Joomla: Extension CI / Release Readiness Check (pull_request) Failing after 4s
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
Joomla: Extension CI / Lint & Validate (pull_request) Failing after 8s
Details
Universal: PR Check / Wiki Update Reminder (pull_request) Successful in 1s
Details
Universal: PR Check / Require Docs Update (pull_request) Failing after 4s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 4s
Details
Generic: Repo Health / Access control (pull_request) Successful in 1s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Standards Compliance / Secret Scanning (pull_request) Failing after 4s
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Failing after 8s
Details
Generic: Standards Compliance / License Header Validation (pull_request) Successful in 6s
Details
Universal: PR Check / Validate PR (pull_request) Successful in 16s
Details
Generic: Standards Compliance / Repository Structure Validation (pull_request) Successful in 10s
Details
Generic: Standards Compliance / Coding Standards Check (pull_request) Successful in 19s
Details
Generic: Standards Compliance / Workflow Configuration Check (pull_request) Failing after 9s
Details
Generic: Standards Compliance / Documentation Quality Check (pull_request) Successful in 4s
Details
Generic: Standards Compliance / README Completeness Check (pull_request) Failing after 4s
Details
Generic: Standards Compliance / Git Repository Hygiene (pull_request) Successful in 5s
Details
Generic: Standards Compliance / Script Integrity Validation (pull_request) Successful in 5s
Details
Generic: Standards Compliance / File Naming Standards (pull_request) Successful in 3s
Details
Generic: Standards Compliance / Line Length Check (pull_request) Successful in 4s
Details
Generic: Standards Compliance / Insecure Code Pattern Detection (pull_request) Successful in 3s
Details
Generic: Standards Compliance / Version Consistency Check (pull_request) Successful in 55s
Details
Generic: Standards Compliance / Dead Code Detection (pull_request) Successful in 16s
Details
Generic: Standards Compliance / File Size Limits (pull_request) Successful in 4s
Details
Generic: Standards Compliance / Binary File Detection (pull_request) Successful in 4s
Details
Generic: Standards Compliance / Code Complexity Analysis (pull_request) Successful in 50s
Details
Generic: Standards Compliance / TODO/FIXME Tracking (pull_request) Successful in 3s
Details
Generic: Standards Compliance / Code Duplication Detection (pull_request) Successful in 53s
Details
Generic: Standards Compliance / Broken Link Detection (pull_request) Successful in 4s
Details
Generic: Standards Compliance / API Documentation Coverage (pull_request) Successful in 3s
Details
Generic: Standards Compliance / Accessibility Check (pull_request) Successful in 4s
Details
Generic: Standards Compliance / Performance Metrics (pull_request) Successful in 5s
Details
Generic: Standards Compliance / Unused Dependencies Check (pull_request) Successful in 51s
Details
Generic: Standards Compliance / Dependency Vulnerability Scanning (pull_request) Successful in 53s
Details
Generic: Standards Compliance / Terraform Configuration Validation (pull_request) Successful in 6s
Details
Generic: Standards Compliance / Enterprise Readiness Check (pull_request) Failing after 51s
Details
Generic: Standards Compliance / Repository Health Check (pull_request) Failing after 43s
Details
Joomla: Extension CI / Tests (PHP 8.2) (pull_request) Has been cancelled
Details
Joomla: Extension CI / Tests (PHP 8.3) (pull_request) Has been cancelled
Details
Joomla: Extension CI / PHPStan Analysis (pull_request) Has been cancelled
Details
Joomla: Extension CI / Build RC Pre-Release (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled
Details
Generic: Standards Compliance / Compliance Summary (pull_request) Has been cancelled
Details
7870d1a5c0 
The global .nav-link rule colored links with --nav-link-color (the header
navbar's white), making sidebar/footer/bottom menu links invisible (white on
light background) in the light theme. Point the global rule at --link-color
(theme-aware). The header keeps white via its own .container-header .nav-link
rule (higher specificity); drawer (.offcanvas .mod-menu .nav-link) and topbar
have their own rules, so they're unaffected.
jmiller force-pushed fix/nav-link-color-leak from c38d41a8f0 to 7870d1a5c0 2026-07-19 09:29:04 +00:00 Compare
jmiller merged commit fe0c95afd3 into main 2026-07-19 09:29:18 +00:00
jmiller deleted branch fix/nav-link-color-leak 2026-07-19 09:29:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 major-release
Major version release
 minor-release
Minor version release
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 patch-release
Patch version release
 php
PHP code changes
 push-failure
File push failure requiring attention
 python
Python code changes
 release-candidate
Release candidate build
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoOnyx#181
Delete Branch "fix/nav-link-color-leak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?