MokoConsulting/MokoGitea-Fork
1
0
Fork 0
Code Issues 129 Pull Requests 2 Releases 96 Wiki Activity

fix: render org teams list and make issue type editable (#720, #721) #726

Merged
jmiller merged 1 commits from fix/team-list-and-issue-type-editable into main 2026-07-04 21:32:05 +00:00
Conversation 0 Commits 1 Files Changed 3
+4 -2
jmiller commented 2026-07-04 21:28:13 +00:00
Owner
Copy Link
Copy Source

Fixes two bug-labeled issues.

#720 — Org Teams page shows no teams

routers/web/org/teams.go populated ctx.Data["OrgListTeams"], but templates/org/team/teams.tmpl iterates {{range .Teams}}. That key is read nowhere else, so the list was always empty — page rendered header/nav but no teams, no error. Fixed by writing the canonical ctx.Data["Teams"] (same key org/home.go uses).

#721 — Issue type not editable after creation

templates/repo/issue/sidebar/issue_type.tmpl gated its edit form on {{$canModify := and .FieldEditFlags .FieldEditFlags.CustomFields}}, but no handler ever sets FieldEditFlags → always nil → the type was permanently read-only. Its twin issue_priority.tmpl correctly uses HasIssuesOrPullsWritePermission; aligned type to match.

Verified:

  • HasIssuesOrPullsWritePermission is set on the issue view (issue_view.go:450,495), so the dropdown now shows for writers.
  • The /{id}/custom-type POST is already protected by reqRepoIssuesOrPullsWriter (web.go:1456) and the handler validates the type belongs to the repo's org — so exposing the form to writers is safe.

Note: #721 also requested multi-select types and issue-template linking — those are enhancements beyond the "not editable" bug and are not included here.

Fixes two bug-labeled issues. ## #720 — Org Teams page shows no teams `routers/web/org/teams.go` populated `ctx.Data["OrgListTeams"]`, but `templates/org/team/teams.tmpl` iterates `{{range .Teams}}`. That key is read nowhere else, so the list was always empty — page rendered header/nav but no teams, no error. Fixed by writing the canonical `ctx.Data["Teams"]` (same key `org/home.go` uses). ## #721 — Issue type not editable after creation `templates/repo/issue/sidebar/issue_type.tmpl` gated its edit form on `{{$canModify := and .FieldEditFlags .FieldEditFlags.CustomFields}}`, but **no handler ever sets `FieldEditFlags`** → always nil → the type was permanently read-only. Its twin `issue_priority.tmpl` correctly uses `HasIssuesOrPullsWritePermission`; aligned type to match. Verified: - `HasIssuesOrPullsWritePermission` is set on the issue view (`issue_view.go:450,495`), so the dropdown now shows for writers. - The `/{id}/custom-type` POST is already protected by `reqRepoIssuesOrPullsWriter` (`web.go:1456`) and the handler validates the type belongs to the repo's org — so exposing the form to writers is safe. Note: #721 also requested multi-select types and issue-template linking — those are enhancements beyond the "not editable" bug and are not included here.
jmiller added 1 commit 2026-07-04 21:28:15 +00:00
fix: render org teams list and make issue type editable (#720, #721)
Universal: PR Check / Branch Policy (pull_request) Successful in 2s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Repo Health / Access control (pull_request) Successful in 2s
Details
Universal: PR Check / Validate PR (pull_request) Successful in 14s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 57s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 1m15s
Details
PR RC Release / Build RC Release (pull_request) Successful in 2m18s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 2m19s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 1s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Failing after 1m10s
Details
Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Failing after 9m20s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled
Details
0cc569aef6 
#720: org Teams page wrote ctx.Data["OrgListTeams"] but the template iterates .Teams, so no teams rendered. Use the canonical Teams key (matches org/home.go). #721: issue type sidebar gated editing on a FieldEditFlags data key that no handler sets (always nil -> always read-only). Use HasIssuesOrPullsWritePermission like the priority field; the /custom-type endpoint is already protected by reqRepoIssuesOrPullsWriter.
jmiller merged commit 5ffed39449 into main 2026-07-04 21:32:05 +00:00
jmiller deleted branch fix/team-list-and-issue-type-editable 2026-07-04 21:32:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 feature: wiki
Wiki system enhancements
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-Fork#726
Delete Branch "fix/team-list-and-issue-type-editable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?