MokoConsulting/MokoGitea-Fork

fix: support radio inputs in admin system config form #724

Merged

jmiller merged 5 commits from fix/admin-config-radio into main

2026-07-04 19:01:40 +00:00

Author	SHA1	Message	Date
jmiller	aea4370845	ci: no-op PR RC Release when updates.xml is absent Universal: PR Check / Branch Policy (pull_request) Successful in 1s Details Generic: Repo Health / Site Health (pull_request) Has been skipped Details Generic: Repo Health / Access control (pull_request) Successful in 1s Details Universal: PR Check / Validate PR (pull_request) Successful in 11s Details Generic: Project CI / Lint & Validate (pull_request) Successful in 33s Details Universal: Pre-Release / Build Pre-Release (${{ inputs.stability \|\| github.ref_name }}) (push) Successful in 49s Details PR RC Release / Build RC Release (pull_request) Successful in 1m34s Details Universal: PR Check / Secret Scan (pull_request) Successful in 1m36s Details Branch Cleanup / Delete merged branch (pull_request) Successful in 1s Details RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped Details Universal: Build & Release / Promote to RC (pull_request) Has been skipped Details Universal: Build & Release / Build & Release Pipeline (pull_request) Failing after 55s Details Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Successful in 8m57s Details Generic: Project CI / Tests (pull_request) Has been cancelled Details Universal: PR Check / Build RC Package (pull_request) Has been cancelled Details Universal: PR Check / Report Issues (pull_request) Has been cancelled Details Generic: Repo Health / Scripts governance (pull_request) Has been cancelled Details Generic: Repo Health / Repository health (pull_request) Has been cancelled Details Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled Details Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled Details The RC release workflow drives a Joomla-style updates.xml update stream. On a generic repo with no updates.xml, the Determine RC version step ran sed on a missing file and aborted under set -e (exit 2). Detect updates.xml presence and gate the update-stream steps (edit/create-release/commit) on it so the job succeeds and no-ops when there is nothing to package.	2026-07-04 13:53:15 -05:00
jmiller	fc234bc911	fix: remove dangling mcp-mokogitea-api submodule gitlink Universal: PR Check / Branch Policy (pull_request) Successful in 1s Details Generic: Repo Health / Site Health (pull_request) Has been skipped Details Generic: Repo Health / Access control (pull_request) Successful in 2s Details Universal: PR Check / Validate PR (pull_request) Successful in 11s Details Generic: Project CI / Lint & Validate (pull_request) Successful in 39s Details Universal: Pre-Release / Build Pre-Release (${{ inputs.stability \|\| github.ref_name }}) (push) Successful in 42s Details Universal: Build & Release / Promote to RC (pull_request) Has been skipped Details Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped Details PR RC Release / Build RC Release (pull_request) Failing after 1m11s Details Universal: PR Check / Secret Scan (pull_request) Successful in 1m12s Details Generic: Project CI / Tests (pull_request) Has been cancelled Details Universal: PR Check / Build RC Package (pull_request) Has been cancelled Details Universal: PR Check / Report Issues (pull_request) Has been cancelled Details Generic: Repo Health / Scripts governance (pull_request) Has been cancelled Details Generic: Repo Health / Repository health (pull_request) Has been cancelled Details Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled Details Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled Details The tree carried a gitlink at mcp-mokogitea-api (mode 160000) with no .gitmodules entry, so git submodule update --init --recursive failed with exit 128 at checkout, breaking every PR build/release job. mcp-mokogitea-api is a separate repo, not a submodule; remove the gitlink from the index (keeping the local working-tree clone) and gitignore the path so it can't be re-added.	2026-07-04 13:46:35 -05:00
jmiller	b252e9569f	ci: allow fix/patch branches to target main and guard missing manifest Universal: PR Check / Branch Policy (pull_request) Successful in 2s Details Generic: Repo Health / Site Health (pull_request) Has been skipped Details Generic: Repo Health / Access control (pull_request) Successful in 2s Details Universal: PR Check / Validate PR (pull_request) Successful in 11s Details Generic: Project CI / Lint & Validate (pull_request) Successful in 36s Details Universal: Pre-Release / Build Pre-Release (${{ inputs.stability \|\| github.ref_name }}) (push) Failing after 1m0s Details Universal: Build & Release / Promote to RC (pull_request) Has been skipped Details Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped Details PR RC Release / Build RC Release (pull_request) Failing after 57s Details Universal: PR Check / Secret Scan (pull_request) Successful in 57s Details Generic: Project CI / Tests (pull_request) Has been cancelled Details Universal: PR Check / Build RC Package (pull_request) Has been cancelled Details Universal: PR Check / Report Issues (pull_request) Has been cancelled Details Generic: Repo Health / Scripts governance (pull_request) Has been cancelled Details Generic: Repo Health / Repository health (pull_request) Has been cancelled Details Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled Details Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled Details Branch policy in pr-check.yml only allowed fix/* and patch/* to target dev/rc, blocking fix/* PRs to main despite the documented policy. Allow fix/* -> main and patch/* -> main. Also guard the Detect platform step for a missing .mokogitea/manifest.xml (removed in favor of the metadata API) so it no longer aborts the Validate PR job under set -e.	2026-07-04 13:36:47 -05:00
jmiller	efb0433412	fix: preserve server-rendered radio default when config value is empty Universal: PR Check / Branch Policy (pull_request) Failing after 1s Details Generic: Repo Health / Site Health (pull_request) Has been skipped Details Generic: Repo Health / Access control (pull_request) Successful in 2s Details Universal: PR Check / Validate PR (pull_request) Failing after 11s Details Generic: Project CI / Lint & Validate (pull_request) Successful in 37s Details PR RC Release / Build RC Release (pull_request) Failing after 1m3s Details Universal: Pre-Release / Build Pre-Release (${{ inputs.stability \|\| github.ref_name }}) (push) Failing after 1m5s Details Universal: Build & Release / Promote to RC (pull_request) Has been skipped Details Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped Details Universal: PR Check / Secret Scan (pull_request) Successful in 1m9s Details Generic: Project CI / Tests (pull_request) Has been cancelled Details Universal: PR Check / Build RC Package (pull_request) Has been cancelled Details Universal: PR Check / Report Issues (pull_request) Has been cancelled Details Generic: Repo Health / Scripts governance (pull_request) Has been cancelled Details Generic: Repo Health / Repository health (pull_request) Has been cancelled Details Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled Details Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled Details LandingPageType.Mode defaults to "" (Go zero value), and the template renders the home radio as checked for an empty Mode. The initial radio fill would evaluate home.checked = ("home" === "") = false, unchecking the default on a fresh install. Skip assignment when the config value is empty so the server-rendered selection is preserved. Adds a test for the empty-value case.	2026-07-04 13:15:10 -05:00
jmiller	982e45a56e	fix: support radio inputs in admin system config form Universal: PR Check / Branch Policy (pull_request) Failing after 1s Details Generic: Repo Health / Site Health (pull_request) Has been skipped Details Generic: Repo Health / Access control (pull_request) Successful in 1s Details Universal: PR Check / Validate PR (pull_request) Failing after 11s Details Universal: Pre-Release / Build Pre-Release (${{ inputs.stability \|\| github.ref_name }}) (push) Failing after 38s Details Universal: Build & Release / Promote to RC (pull_request) Failing after 8s Details Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped Details Generic: Project CI / Lint & Validate (pull_request) Successful in 39s Details Universal: PR Check / Secret Scan (pull_request) Successful in 43s Details Generic: Project CI / Tests (pull_request) Has been cancelled Details Universal: PR Check / Build RC Package (pull_request) Has been cancelled Details Universal: PR Check / Report Issues (pull_request) Has been cancelled Details Generic: Repo Health / Scripts governance (pull_request) Has been cancelled Details Generic: Repo Health / Repository health (pull_request) Has been cancelled Details Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled Details Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled Details The system config form JS (config.ts) only mapped checkbox, text, textarea, and datetime-local elements. The fork landing_page.tmpl uses radio inputs for the Mode field, so fillFromSystemConfig() hit unsupportedElement() and threw, aborting all JS init on the admin settings page. Add radio handling in both directions: fill checks the option whose value matches the config value; collect returns the checked option's value and skips/nulls unchecked radios so a group resolves to exactly one value. Adds a radio-group test case.	2026-07-04 01:20:43 -05:00