MokoConsulting/MokoGitea-APP
1
0
Fork 0
Code Issues 171 Pull Requests 1 Releases 96 Wiki Activity

feat(issues): make status_id, priority_id, type_id required on create (#598) #613

Merged
jmiller merged 1 commits from feature/598-required-issue-metadata into main 2026-06-12 02:59:56 +00:00
Conversation 0 Commits 1 Files Changed 2
+11 -12
2 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/structs/issue.go
+4 -4
View File
@@ -114,10 +114,10 @@ type CreateIssueOption struct {
Closed bool `json:"closed"`
// custom field values keyed by field name
CustomFields map[string]string `json:"custom_fields,omitempty"`
// org-level issue metadata IDs
StatusID *int64 `json:"status_id,omitempty"`
PriorityID *int64 `json:"priority_id,omitempty"`
TypeID *int64 `json:"type_id,omitempty"`
// org-level issue metadata IDs (auto-assigned from org defaults when 0)
StatusID int64 `json:"status_id"`
PriorityID int64 `json:"priority_id"`
TypeID int64 `json:"type_id"`
}
// EditIssueOption options for editing an issue
routers/api/v1/repo/issue.go
+7 -8
View File
@@ -757,11 +757,10 @@ func CreateIssue(ctx *context.APIContext) {
}
// Set org-level issue metadata (status/priority/type).
// If not provided, auto-assign the org default.
if form.StatusID != nil && *form.StatusID > 0 {
_ = issues_model.SetIssueStatusID(ctx, issue.ID, *form.StatusID)
// Use provided value if > 0, otherwise auto-assign org default.
if form.StatusID > 0 {
_ = issues_model.SetIssueStatusID(ctx, issue.ID, form.StatusID)
} else {
// Auto-assign first non-closing status.
if defs, err := issues_model.GetIssueStatusDefsByOrg(ctx, ctx.Repo.Repository.OwnerID); err == nil {
for _, d := range defs {
if !d.ClosesIssue {
@@ -771,8 +770,8 @@ func CreateIssue(ctx *context.APIContext) {
}
}
}
if form.PriorityID != nil && *form.PriorityID > 0 {
_ = issues_model.SetIssuePriorityID(ctx, issue.ID, *form.PriorityID)
if form.PriorityID > 0 {
_ = issues_model.SetIssuePriorityID(ctx, issue.ID, form.PriorityID)
} else {
if defs, err := issues_model.GetIssuePriorityDefsByOrg(ctx, ctx.Repo.Repository.OwnerID); err == nil {
for _, d := range defs {
@@ -783,8 +782,8 @@ func CreateIssue(ctx *context.APIContext) {
}
}
}
if form.TypeID != nil && *form.TypeID > 0 {
_ = issues_model.SetIssueTypeID(ctx, issue.ID, *form.TypeID)
if form.TypeID > 0 {
_ = issues_model.SetIssueTypeID(ctx, issue.ID, form.TypeID)
} else {
if defs, err := issues_model.GetIssueTypeDefsByOrg(ctx, ctx.Repo.Repository.OwnerID); err == nil {
for _, d := range defs {