MokoConsulting/MokoGIT
1
0
Fork 0
Code Issues 161 Pull Requests 2 Releases 97 Wiki Activity

fix(ui): body data-bs-no-jquery (real Fomantic fix) + login/navbar favicon (#719 #819) #859

Merged
jmiller merged 3 commits from feat/mobile-retheme into dev 2026-07-21 20:09:30 +00:00
Conversation 0 Commits 3 Files Changed 5
+6 -40
jmiller commented 2026-07-21 20:09:08 +00:00
Owner
Copy Link
Copy Source

Follow-up to #858. Dev verification showed the noConflict shim did NOT clear the fullTextSearch TypeError (Bootstrap registers its jQuery plugins on DOMContentLoaded, after the shim ran).

  • 5afbf00 — real fix. Add data-bs-no-jquery to <body> so Bootstrap's getjQuery() returns null and it registers no jQuery plugins → never clobbers Fomantic's $.fn.{dropdown,modal,tab,…}. Bootstrap's data-bs-* API still works. Removes the ineffective noconflict.ts.
  • 65019dd — navbar brand → favicon. The Gitea logo.svg in the navbar (the logo you see on the dashboard after login) now uses the admin-selected favicon (/img/favicon.svg, png fallback).
  • e8d6451 — login page logo → favicon. Replaces the 404ing login-logo.png with the favicon.

https://claude.ai/code/session_01D5Zxu4xRRGoh9etzgShP4P

Follow-up to #858. Dev verification showed the noConflict shim did NOT clear the `fullTextSearch` TypeError (Bootstrap registers its jQuery plugins on DOMContentLoaded, after the shim ran). - **`5afbf00` — real fix.** Add `data-bs-no-jquery` to `<body>` so Bootstrap's `getjQuery()` returns null and it registers no jQuery plugins → never clobbers Fomantic's `$.fn.{dropdown,modal,tab,…}`. Bootstrap's `data-bs-*` API still works. Removes the ineffective `noconflict.ts`. - **`65019dd` — navbar brand → favicon.** The Gitea `logo.svg` in the navbar (the logo you see on the dashboard after login) now uses the admin-selected favicon (`/img/favicon.svg`, png fallback). - **`e8d6451` — login page logo → favicon.** Replaces the 404ing `login-logo.png` with the favicon. https://claude.ai/code/session_01D5Zxu4xRRGoh9etzgShP4P
jmiller added 3 commits 2026-07-21 20:09:09 +00:00
fix(ui): use selected favicon on the login page instead of missing gitea logo (#819) e8d6451f17 
The login page hard-coded {{AssetUrlPrefix}}/img/login-logo.png, which 404s (broken
image above the sign-in card). Point it at the configured favicon (/img/favicon.svg)
with a png fallback then hide, so the login page shows the actual selected site
icon/branding. Adds an alt of {{AppName}}.

Authored-by: Moko Consulting
Claude-Session: https://claude.ai/code/session_01D5Zxu4xRRGoh9etzgShP4P
fix(ui): navbar brand uses selected favicon instead of gitea logo (#819) 65019dd5ad 
The navbar brand (top-left, shown on the dashboard you land on after login) rendered
the default gitea logo.svg. Point it at the admin-selected favicon (/img/favicon.svg,
png fallback) so post-login pages carry the configured site icon.

Authored-by: Moko Consulting
Claude-Session: https://claude.ai/code/session_01D5Zxu4xRRGoh9etzgShP4P
fix(ui): stop Bootstrap clobbering Fomantic via <body data-bs-no-jquery> (#719)
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Details
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Details
Generic: Project CI / Tests (pull_request) Successful in 39s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 44s
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 2s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Universal: PR Check / Validate PR (pull_request) Successful in 9s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 1m2s
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
5afbf005ed 
The earlier noConflict shim (f5bf232) didn't work: Bootstrap 5 registers its jQuery
plugins inside an onDOMContentLoaded callback, so the shim (running at module-eval, before
DOMContentLoaded) restored Fomantic's $.fn.* BEFORE Bootstrap overwrote them — then
Bootstrap clobbered again. Verified still broken on dev (fullTextSearch TypeError persisted
in the redeployed bundle).

Correct fix: add `data-bs-no-jquery` to <body>. Bootstrap's getjQuery() then returns null
and it registers NO jQuery plugins, so Fomantic's dropdown/modal/tab/... are never touched.
Bootstrap's data-bs-* data-API is bound independently and keeps working (mobile collapse
drawers). Removes the now-unnecessary noconflict.ts.

Authored-by: Moko Consulting
Claude-Session: https://claude.ai/code/session_01D5Zxu4xRRGoh9etzgShP4P
jmiller merged commit 20b8b77436 into dev 2026-07-21 20:09:30 +00:00
jmiller deleted branch feat/mobile-retheme 2026-07-21 20:09:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 feature: wiki
Wiki system enhancements
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGIT#859
Delete Branch "feat/mobile-retheme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?