fix: baseline pre-existing PHPStan level-6 findings so Gate 1 passes #333

Merged

jmiller merged 2 commits from hotfix/phpstan-baseline into main 2026-07-04 21:02:35 +00:00

Conversation 0 Commits 2 Files Changed 3

+715 -2

jmiller commented 2026-07-04 20:48:36 +00:00

Owner

Copy Link

Copy Source

Gate 1 static analysis (PHPStan level 6) reported 194 pre-existing findings across 52 files in cli/, lib/, and validate/ — missing iterable value types, override signature mismatches, redundant nullable returns, etc. These predate this work (they were masked earlier by the phpcs/automation failures).

Consistent with the repo's existing phpstan-baseline.neon approach, this adds those findings to the baseline (177 entries) so Gate 1 passes while the type-annotation debt stays tracked for incremental cleanup — rather than silently disabling analysis.

Also adds the CHANGELOG [Unreleased] entry the PR check requires.

Gate 1 static analysis (PHPStan level 6) reported **194 pre-existing findings across 52 files** in `cli/`, `lib/`, and `validate/` — missing iterable value types, override signature mismatches, redundant nullable returns, etc. These predate this work (they were masked earlier by the phpcs/`automation` failures). Consistent with the repo's existing `phpstan-baseline.neon` approach, this adds those findings to the baseline (177 entries) so Gate 1 passes while the type-annotation debt stays tracked for incremental cleanup — rather than silently disabling analysis. Also adds the CHANGELOG `[Unreleased]` entry the PR check requires.

jmiller added 1 commit 2026-07-04 20:48:37 +00:00

fix: baseline pre-existing PHPStan level-6 findings + changelog ... 713cb61efc

Gate 1 static analysis reported 194 pre-existing PHPStan level-6 findings across cli/, lib/, and validate/ (missing iterable value types, override signature mismatches, etc.). Add them to phpstan-baseline.neon so Gate 1 passes; the debt stays tracked in the baseline for incremental cleanup. Also adds the changelog entry required by the PR check.

jmiller added 1 commit 2026-07-04 20:55:17 +00:00

fix: rename colliding printSummary() in client_provision to resolve PHPStan override errors 3164f21ba9

jmiller merged commit 0ff87f3631 into main 2026-07-04 21:02:35 +00:00

jmiller deleted branch hotfix/phpstan-baseline 2026-07-04 21:02:35 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

automation

Automated processes or scripts

breaking-change

Breaking API or functionality change

build

Build system changes

ci-cd

CI/CD pipeline changes

config

Configuration file changes

css

CSS/styling changes

dependencies

Dependency updates

deploy-failure

Automated deploy failure tracking

docker

Docker configuration changes

documentation

Documentation changes

dolibarr

Dolibarr module or extension

generic

Generic project or library

good first issue

Good for newcomers

health-check

Repository health check results

health: excellent

Health score 90-100

health: fair

Health score 50-69

health: good

Health score 70-89

health: poor

Health score below 50

help wanted

Extra attention needed

html

HTML template changes

javascript

JavaScript code changes

joomla

Joomla extension or component

mokostandards

MokoStandards compliance

needs-review

Awaiting code review

php

PHP code changes

push-failure

File push failure requiring attention

python

Python code changes

security

Security-related changes

size/l

Large change (101-300 lines)

size/m

Medium change (31-100 lines)

size/s

Small change (11-30 lines)

size/xl

Extra large change (301-1000 lines)

size/xs

Extra small change (1-10 lines)

size/xxl

Extremely large change (1000+ lines)

standards-drift

Repository drifted from MokoStandards

standards-update

MokoStandards sync update

sync-failure

Bulk sync failure requiring attention

sync-report

Bulk sync run report

template-validation-failure

Template workflow validation failure

tests

Test suite changes

type: bug

Something isn't working

type: chore

Maintenance tasks

type: enhancement

Enhancement to existing feature

type: feature

New feature or request

type: refactor

Code refactoring

type: version

Version-related change

typescript

TypeScript code changes

version

Version bump or release

version-drift

Version mismatch detected

work-in-progress

Work in progress, not ready for merge

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCLI#333