From f441a8a51fd765e5ea34bbcdc64d4a3a608c228c Mon Sep 17 00:00:00 2001
From: Jonathan Miller <jmiller-moko@noreply.git.mokoconsulting.tech>
Date: Mon, 25 May 2026 23:40:54 -0500
Subject: [PATCH] fix(updates_xml): restore <client>site</client> for all
 extension types

Joomla requires the client tag to match updates to installed extensions.
Without it, extension_id=0 in #__updates and the update is invisible.

Authored-by: Moko Consulting
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 cli/updates_xml_build.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/cli/updates_xml_build.php b/cli/updates_xml_build.php
index e5c88bc..0dcd587 100644
--- a/cli/updates_xml_build.php
+++ b/cli/updates_xml_build.php
@@ -217,12 +217,12 @@ $releaseTagMap = [
 $primarySuffix = $stabilitySuffixMap[$stability] ?? '';
 $primaryVersion = $version . $primarySuffix;
 
-// Build client tag — only needed for templates and modules (site vs admin).
-// Packages and components don't use client; plugins use folder instead.
+// Build client tag — Joomla requires <client>site</client> to match updates
+// to installed extensions. Without it, extension_id=0 in #__updates.
 $clientTag = '';
 if (!empty($extClient)) {
 	$clientTag = "    <client>{$extClient}</client>";
-} elseif (in_array($extType, ['template', 'module'])) {
+} else {
 	$clientTag = '    <client>site</client>';
 }