MokoConsulting/moko-platform
1
0
Fork 0
Code Issues 6 Pull Requests 1 Releases 8 Wiki Activity

refactor: simplify version extraction - derive filename from manifest version #191

New Issue
Closed
opened 2026-05-26 23:32:21 +00:00 by jmiller · 2 comments
jmiller commented 2026-05-26 23:32:21 +00:00
Owner
Copy Link
Copy Source

Problem

The update-server and pre-release workflows have complex version logic:

  1. Read version from manifest
  2. Strip suffix
  3. Bump patch
  4. Re-apply suffix based on branch
  5. Compute DISPLAY_VERSION separately
  6. Build filename from DISPLAY_VERSION

This leads to mismatches where the manifest version and the ZIP filename diverge (e.g. manifest says 01.02.14 but filename should be 01.02.14-dev.zip).

Proposed Fix

Since the manifest version now includes the full suffix (e.g. 01.02.14-dev), simplify to:

  1. Read version directly from manifest as-is
  2. Derive filename: element + version (no separate suffix logic)
  3. version_bump.php should preserve the existing suffix when bumping

This eliminates the separate DISPLAY_VERSION variable and the branch-to-suffix mapping logic.

Affected files

  • update-server.yml (Generate updates.xml entry step)
  • pre-release.yml (Resolve metadata step)
  • auto-release.yml (if applicable)
  • version_bump.php CLI (should preserve suffix)
## Problem The update-server and pre-release workflows have complex version logic: 1. Read version from manifest 2. Strip suffix 3. Bump patch 4. Re-apply suffix based on branch 5. Compute DISPLAY_VERSION separately 6. Build filename from DISPLAY_VERSION This leads to mismatches where the manifest version and the ZIP filename diverge (e.g. manifest says 01.02.14 but filename should be 01.02.14-dev.zip). ## Proposed Fix Since the manifest version now includes the full suffix (e.g. 01.02.14-dev), simplify to: 1. Read version directly from manifest as-is 2. Derive filename: element + version (no separate suffix logic) 3. version_bump.php should preserve the existing suffix when bumping This eliminates the separate DISPLAY_VERSION variable and the branch-to-suffix mapping logic. ## Affected files - update-server.yml (Generate updates.xml entry step) - pre-release.yml (Resolve metadata step) - auto-release.yml (if applicable) - version_bump.php CLI (should preserve suffix)
jmiller commented 2026-05-26 23:32:23 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/191-refactor-simplify-version-extraction-der

git fetch origin
git checkout feature/191-refactor-simplify-version-extraction-der
Branch created: [`feature/191-refactor-simplify-version-extraction-der`](https://git.mokoconsulting.tech/MokoConsulting/moko-platform/src/branch/feature/191-refactor-simplify-version-extraction-der) ```bash git fetch origin git checkout feature/191-refactor-simplify-version-extraction-der ```
jmiller commented 2026-05-31 19:03:53 +00:00
Author
Owner
Copy Link
Copy Source

Fixed in 1ecd923.

  • version_bump.php now preserves existing suffix (e.g. 01.02.03-dev ? 01.02.04-dev)
  • update-server.yml simplified: removed strip?map?re-apply suffix dance
  • pre-release.yml simplified: same pattern
  • Removed DISPLAY_VERSION and SUFFIX output variables
  • Added testPreservesSuffixOnBump test, fixed pre-existing testBumpsFromHtmlComment assertion
  • All 29 tests pass
Fixed in 1ecd923. - `version_bump.php` now preserves existing suffix (e.g. `01.02.03-dev` ? `01.02.04-dev`) - `update-server.yml` simplified: removed strip?map?re-apply suffix dance - `pre-release.yml` simplified: same pattern - Removed `DISPLAY_VERSION` and `SUFFIX` output variables - Added `testPreservesSuffixOnBump` test, fixed pre-existing `testBumpsFromHtmlComment` assertion - All 29 tests pass
Sign in to join this conversation.
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 priority: critical
Critical priority, must be addressed immediately
 priority: high
High priority
 priority: low
Low priority
 priority: medium
Medium priority
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 status: blocked
Blocked by another issue or dependency
 status: in-progress
Currently being worked on
 status: needs-review
Awaiting code review
 status: on-hold
Temporarily on hold
 status: pending
Pending action or decision
 status: wontfix
This will not be worked on
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
bug
Something is not working
 chore
Maintenance and housekeeping
 documentation
Documentation improvements
 enhancement
Improvement to existing functionality
 feature
New feature or request
 pending: dependency
Blocked by another issue or external dependency
 pending: deployment
Tested and approved, awaiting deployment to production
 pending: design
Needs UI/UX or architecture design before implementation
 pending: documentation
Feature works, needs documentation/wiki update
 pending: feedback
Awaiting feedback or decision from stakeholder
 pending: review
Implementation complete, awaiting code review
 pending: testing
Feature implemented but not yet tested
 priority: critical
Must fix immediately
 priority: high
Should fix soon
 priority: low
Nice to have
 priority: medium
Fix when convenient
 refactor
Code restructuring without behavior change
 roadmap
Planned feature or enhancement tracked on the roadmap
 scope: client
Client-specific work
 scope: dolibarr
Dolibarr modules and customizations
 scope: infrastructure
Server, CI, backups, monitoring
 scope: joomla
Joomla templates and extensions
 scope: waas
MokoWaaS platform
 security
Security vulnerability or hardening
 status: blocked
Waiting on external dependency
 status: duplicate
Duplicate of another issue
 status: in-progress
Being worked on
 status: needs-review
Ready for review
 status: wontfix
Will not be addressed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/moko-platform#191
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?