MokoConsulting/Template-Joomla
Template
1
0
Fork 0
Code Issues Pull Requests Releases 3 Wiki Activity

ci: skip Joomla metadata check on template repos; fix sample script PHP #41

Merged
jmiller merged 1 commits from fix/template-ci-skip into main 2026-07-04 19:27:10 +00:00
Conversation 0 Commits 1 Files Changed 5
+6 -4
jmiller commented 2026-07-04 19:26:46 +00:00
Owner
Copy Link
Copy Source

Summary

Fixes the remaining CI failures on this template repo.

Changes

  • pr-metadata-check.yml: guard the validate-metadata job with !startsWith(github.event.repository.name, 'Template-'). A template has no real extension manifest, so joomla_metadata_validate (No Joomla extension manifest XML found) can't pass by design.
  • samples/script/*.php: give each installer script a valid class name (ComponentInstallerScript, ModuleInstallerScript, PluginInstallerScript, PackageInstallerScript) instead of the invalid class {REPONAME}InstallerScript placeholder, so the files pass php -l. This matters for repos generated from this template that keep samples/ — their (non-template) CI would otherwise lint these and fail. String/comment placeholders remain for find-replace.

Related

Companion to Template-Generic#48 which guards the generic ci-generic/pr-check/branch-cleanup workflows.

Authored-by: Moko Consulting

## Summary Fixes the remaining CI failures on this template repo. ## Changes - **`pr-metadata-check.yml`**: guard the `validate-metadata` job with `!startsWith(github.event.repository.name, 'Template-')`. A template has no real extension manifest, so `joomla_metadata_validate` (`No Joomla extension manifest XML found`) can't pass by design. - **`samples/script/*.php`**: give each installer script a valid class name (`ComponentInstallerScript`, `ModuleInstallerScript`, `PluginInstallerScript`, `PackageInstallerScript`) instead of the invalid `class {REPONAME}InstallerScript` placeholder, so the files pass `php -l`. **This matters for repos generated from this template that keep `samples/`** — their (non-template) CI would otherwise lint these and fail. String/comment placeholders remain for find-replace. ## Related Companion to [Template-Generic#48](https://git.mokoconsulting.tech/MokoConsulting/Template-Generic/pulls/48) which guards the generic `ci-generic`/`pr-check`/`branch-cleanup` workflows. Authored-by: Moko Consulting
jmiller added 1 commit 2026-07-04 19:26:47 +00:00
ci: skip Joomla metadata check on template repos; fix sample script PHP
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Has been skipped
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Has been skipped
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 1s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Repo Health / Access control (pull_request) Successful in 1s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 5s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 5s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 21s
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 1s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped
Details
Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Successful in 9s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled
Details
e498b22b66 
- pr-metadata-check.yml: guard the validate-metadata job with
  !startsWith(github.event.repository.name, 'Template-'). Template repos
  have no real extension manifest, so the check cannot pass by design.
- samples/script/*.php: give each installer script a valid class name
  (ComponentInstallerScript, ModuleInstallerScript, PluginInstallerScript,
  PackageInstallerScript) instead of the invalid `class {REPONAME}...`
  placeholder, so the files pass `php -l`. This matters for repos generated
  from this template that keep samples/. String/comment placeholders remain
  for find-replace.

Authored-by: Moko Consulting
jmiller merged commit 7ad8efe281 into main 2026-07-04 19:27:10 +00:00
jmiller deleted branch fix/template-ci-skip 2026-07-04 19:27:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 documentation
Documentation changes
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 html
HTML/template changes
 joomla
Joomla extension
 major-release
Major version release
 minor-release
Minor version release
 mokostandards
Related to MokoStandards framework
 patch-release
Patch version release
 php
PHP code
 push-failure
Git push operation failed
 release-candidate
Release candidate build
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 version-drift
Version mismatch across files
 work-in-progress
Draft or incomplete work
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/Template-Joomla#41
Delete Branch "fix/template-ci-skip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?