From ba3cefa47072ae44cc8cd1c3b4eb01a8fbdb2e2a Mon Sep 17 00:00:00 2001
From: Jonathan Miller <jmiller-moko@noreply.git.mokoconsulting.tech>
Date: Tue, 23 Jun 2026 11:54:19 -0500
Subject: [PATCH] fix: change duplicate file references check from error to
 warning
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Cross-section duplicates (e.g. same folder in <files> and <media>) are
valid in Joomla manifests — should not block CI.

Authored-by: Moko Consulting
---
 .mokogitea/workflows/ci-joomla.yml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/.mokogitea/workflows/ci-joomla.yml b/.mokogitea/workflows/ci-joomla.yml
index 11d418f..6f184a2 100644
--- a/.mokogitea/workflows/ci-joomla.yml
+++ b/.mokogitea/workflows/ci-joomla.yml
@@ -895,9 +895,10 @@ jobs:
           fi
 
       - name: Duplicate file references check
+        continue-on-error: true
         run: |
           echo "### Duplicate File References" >> $GITHUB_STEP_SUMMARY
-          ERRORS=0
+          WARNINGS=0
 
           MANIFEST=""
           for XML_FILE in $(find . -maxdepth 2 -name "*.xml" -not -path "./.git/*" -not -path "./vendor/*"); do
@@ -919,9 +920,9 @@ jobs:
               if [ -n "$DUPES" ]; then
                 while IFS= read -r DUP; do
                   COUNT=$(echo "$ALL_REFS" | grep -cx "$DUP")
-                  echo "::error file=${MANIFEST}::Duplicate reference: \`${DUP}\` appears ${COUNT} times"
-                  echo "- **Duplicate:** \`${DUP}\` (${COUNT}x)" >> $GITHUB_STEP_SUMMARY
-                  ERRORS=$((ERRORS + 1))
+                  echo "::warning file=${MANIFEST}::Duplicate reference: \`${DUP}\` appears ${COUNT} times (may be valid if in different sections)"
+                  echo "- **Duplicate:** \`${DUP}\` (${COUNT}x) — check if cross-section" >> $GITHUB_STEP_SUMMARY
+                  WARNINGS=$((WARNINGS + 1))
                 done <<< "$DUPES"
               else
                 TOTAL=$(echo "$ALL_REFS" | wc -l)
@@ -931,9 +932,8 @@ jobs:
           fi
 
           echo "" >> $GITHUB_STEP_SUMMARY
-          if [ "${ERRORS}" -gt 0 ]; then
-            echo "**${ERRORS} duplicate reference(s) found.**" >> $GITHUB_STEP_SUMMARY
-            exit 1
+          if [ "$WARNINGS" -gt 0 ]; then
+            echo "**${WARNINGS} duplicate reference(s) found.** Review for cross-section validity." >> $GITHUB_STEP_SUMMARY
           else
             echo "**Duplicate file references check passed.**" >> $GITHUB_STEP_SUMMARY
           fi