generated from MokoConsulting/Template-Joomla
Compare commits
8 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 4a02861b90 | |||
| 258cfe0968 | |||
| a6c50f5e79 | |||
| 806660af44 | |||
| df5c18543d | |||
| c51ed89df8 | |||
| b1a023a673 | |||
| 471e0a7cc9 |
@@ -5,7 +5,7 @@
|
|||||||
# FILE INFORMATION
|
# FILE INFORMATION
|
||||||
# DEFGROUP: Gitea.Workflow
|
# DEFGROUP: Gitea.Workflow
|
||||||
# INGROUP: mokocli.Automation
|
# INGROUP: mokocli.Automation
|
||||||
# VERSION: 01.00.33
|
# VERSION: 01.00.36
|
||||||
# BRIEF: Auto-create feature branch when an issue is opened
|
# BRIEF: Auto-create feature branch when an issue is opened
|
||||||
|
|
||||||
name: "Universal: Issue Branch"
|
name: "Universal: Issue Branch"
|
||||||
|
|||||||
@@ -27,6 +27,7 @@
|
|||||||
- **CLAUDE.md** — repo-specific with channels, key patterns
|
- **CLAUDE.md** — repo-specific with channels, key patterns
|
||||||
|
|
||||||
### Fixed
|
### Fixed
|
||||||
|
- **Installer** — honest install success: the package postflight now verifies every bundled child extension (component + system plugin) actually landed in `#__extensions` before showing the license/next-steps message, and enqueues an error listing any missing ones instead. Fails open so a transient query/IO glitch never fakes a failure.
|
||||||
- **WebhookChannelHelper** — conversation race condition on concurrent webhooks (FOR UPDATE transaction)
|
- **WebhookChannelHelper** — conversation race condition on concurrent webhooks (FOR UPDATE transaction)
|
||||||
|
|
||||||
### Removed
|
### Removed
|
||||||
|
|||||||
+1
-1
@@ -14,7 +14,7 @@
|
|||||||
DEFGROUP: Template-Joomla
|
DEFGROUP: Template-Joomla
|
||||||
INGROUP: Template-Joomla.Documentation
|
INGROUP: Template-Joomla.Documentation
|
||||||
REPO: https://github.com/mokoconsulting-tech/Template-Joomla/
|
REPO: https://github.com/mokoconsulting-tech/Template-Joomla/
|
||||||
VERSION: 01.00.33
|
VERSION: 01.00.36
|
||||||
PATH: ./CODE_OF_CONDUCT.md
|
PATH: ./CODE_OF_CONDUCT.md
|
||||||
BRIEF: Community expectations and enforcement guidelines
|
BRIEF: Community expectations and enforcement guidelines
|
||||||
NOTE: Adapted with attribution from the Contributor Covenant v2.1
|
NOTE: Adapted with attribution from the Contributor Covenant v2.1
|
||||||
|
|||||||
+1
-1
@@ -19,7 +19,7 @@
|
|||||||
DEFGROUP: mokoconsulting-tech.Template-Joomla
|
DEFGROUP: mokoconsulting-tech.Template-Joomla
|
||||||
INGROUP: MokoStandards.Governance
|
INGROUP: MokoStandards.Governance
|
||||||
REPO: https://github.com/mokoconsulting-tech/Template-Joomla
|
REPO: https://github.com/mokoconsulting-tech/Template-Joomla
|
||||||
VERSION: 01.00.33
|
VERSION: 01.00.36
|
||||||
PATH: /GOVERNANCE.md
|
PATH: /GOVERNANCE.md
|
||||||
BRIEF: Project governance rules, roles, and decision process for Template-Joomla
|
BRIEF: Project governance rules, roles, and decision process for Template-Joomla
|
||||||
-->
|
-->
|
||||||
|
|||||||
+1
-1
@@ -23,7 +23,7 @@ DEFGROUP: Template-Joomla
|
|||||||
INGROUP: Template-Joomla.Documentation
|
INGROUP: Template-Joomla.Documentation
|
||||||
REPO: https://git.mokoconsulting.tech/MokoConsulting/Template-Joomla
|
REPO: https://git.mokoconsulting.tech/MokoConsulting/Template-Joomla
|
||||||
PATH: /SECURITY.md
|
PATH: /SECURITY.md
|
||||||
VERSION: 01.00.33
|
VERSION: 01.00.36
|
||||||
BRIEF: Security vulnerability reporting and handling policy
|
BRIEF: Security vulnerability reporting and handling policy
|
||||||
-->
|
-->
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,7 @@
|
|||||||
|
; MokoSuite Support - system language strings
|
||||||
|
; Copyright (C) 2026 Moko Consulting. All rights reserved.
|
||||||
|
; License GPL-3.0-or-later
|
||||||
|
|
||||||
|
COM_MOKOSUITESUPPORT="MokoSuite Support"
|
||||||
|
COM_MOKOSUITESUPPORT_SHORT="Support"
|
||||||
|
COM_MOKOSUITESUPPORT_XML_DESCRIPTION="MokoSuite Support component."
|
||||||
@@ -5,10 +5,13 @@
|
|||||||
<creationDate>2026-06-23</creationDate>
|
<creationDate>2026-06-23</creationDate>
|
||||||
<copyright>Copyright (C) 2026 Moko Consulting.</copyright>
|
<copyright>Copyright (C) 2026 Moko Consulting.</copyright>
|
||||||
<license>GPL-3.0-or-later</license>
|
<license>GPL-3.0-or-later</license>
|
||||||
<version>01.00.33</version>
|
<version>01.00.36</version>
|
||||||
<namespace path="src">Moko\Component\MokoSuiteSupport</namespace>
|
<namespace path="src">Moko\Component\MokoSuiteSupport</namespace>
|
||||||
<administration>
|
<administration>
|
||||||
<files folder="admin"><folder>services</folder><folder>src</folder><folder>tmpl</folder></files>
|
<files folder="admin"><folder>language</folder><folder>services</folder><folder>src</folder><folder>tmpl</folder></files>
|
||||||
<menu>COM_MOKOSUITESUPPORT</menu>
|
<menu>COM_MOKOSUITESUPPORT_SHORT</menu>
|
||||||
|
<languages folder="admin/language">
|
||||||
|
<language tag="en-GB">en-GB/com_mokosuitesupport.sys.ini</language>
|
||||||
|
</languages>
|
||||||
</administration>
|
</administration>
|
||||||
</extension>
|
</extension>
|
||||||
|
|||||||
@@ -8,7 +8,7 @@
|
|||||||
<license>GPL-3.0-or-later</license>
|
<license>GPL-3.0-or-later</license>
|
||||||
<authorEmail>hello@mokoconsulting.tech</authorEmail>
|
<authorEmail>hello@mokoconsulting.tech</authorEmail>
|
||||||
<authorUrl>https://mokoconsulting.tech</authorUrl>
|
<authorUrl>https://mokoconsulting.tech</authorUrl>
|
||||||
<version>01.00.33</version>
|
<version>01.00.36</version>
|
||||||
<php_minimum>8.3</php_minimum>
|
<php_minimum>8.3</php_minimum>
|
||||||
<description>PLG_SYSTEM_MOKOSUITESUPPORT_DESC</description>
|
<description>PLG_SYSTEM_MOKOSUITESUPPORT_DESC</description>
|
||||||
<namespace path="src">Moko\Plugin\System\MokoSuiteSupport</namespace>
|
<namespace path="src">Moko\Plugin\System\MokoSuiteSupport</namespace>
|
||||||
|
|||||||
@@ -3,7 +3,7 @@
|
|||||||
<name>Web Services - MokoSuite Support</name>
|
<name>Web Services - MokoSuite Support</name>
|
||||||
<element>mokosuitesupport</element>
|
<element>mokosuitesupport</element>
|
||||||
<author>Moko Consulting</author>
|
<author>Moko Consulting</author>
|
||||||
<version>01.00.33</version>
|
<version>01.00.36</version>
|
||||||
<license>GPL-3.0-or-later</license>
|
<license>GPL-3.0-or-later</license>
|
||||||
<namespace path="src">Moko\Plugin\WebServices\MokoSuiteSupport</namespace>
|
<namespace path="src">Moko\Plugin\WebServices\MokoSuiteSupport</namespace>
|
||||||
<files><folder>src</folder><folder>services</folder></files>
|
<files><folder>src</folder><folder>services</folder></files>
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
<extension type="package" method="upgrade">
|
<extension type="package" method="upgrade">
|
||||||
<name>Package - MokoSuite Support</name>
|
<name>Package - MokoSuite Support</name>
|
||||||
<packagename>mokosuitesupport</packagename>
|
<packagename>mokosuitesupport</packagename>
|
||||||
<version>01.00.33</version>
|
<version>01.00.36</version>
|
||||||
<creationDate>2026-06-21</creationDate>
|
<creationDate>2026-06-21</creationDate>
|
||||||
<author>Moko Consulting</author>
|
<author>Moko Consulting</author>
|
||||||
<authorEmail>hello@mokoconsulting.tech</authorEmail>
|
<authorEmail>hello@mokoconsulting.tech</authorEmail>
|
||||||
|
|||||||
@@ -16,9 +16,113 @@ class Pkg_MokoSuiteSupportInstallerScript
|
|||||||
{
|
{
|
||||||
public function postflight(string $type, InstallerAdapter $adapter): void
|
public function postflight(string $type, InstallerAdapter $adapter): void
|
||||||
{
|
{
|
||||||
|
// Be honest about success. Joomla's package installer only LOGS a failed child
|
||||||
|
// sub-install but still runs this postflight, so don't show the license /
|
||||||
|
// next-steps message if a bundled extension is actually missing. Fails open
|
||||||
|
// (see missingChildExtensions) so a query/IO glitch never fakes a failure.
|
||||||
|
$missing = $this->missingChildExtensions($adapter);
|
||||||
|
|
||||||
|
if (!empty($missing))
|
||||||
|
{
|
||||||
|
Factory::getApplication()->enqueueMessage(
|
||||||
|
'<h4>MokoSuiteSupport did not install correctly.</h4>'
|
||||||
|
. '<p>The following bundled extensions are missing: '
|
||||||
|
. htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '</p>'
|
||||||
|
. '<p>Please uninstall MokoSuiteSupport and reinstall the full package.</p>',
|
||||||
|
'error'
|
||||||
|
);
|
||||||
|
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Warn if no license key is configured (success / next-steps path)
|
||||||
$this->warnMissingLicenseKey();
|
$this->warnMissingLicenseKey();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Verify every child extension declared in the package manifest actually landed
|
||||||
|
* in #__extensions. Returns readable labels of any that are missing.
|
||||||
|
*
|
||||||
|
* Matching per Joomla's #__extensions uniqueness:
|
||||||
|
* - type = the <file> "type" attribute
|
||||||
|
* - element = the <file> "id" attribute, EXCEPT for plugins the manifest often
|
||||||
|
* declares the full `plg_<group>_<element>` id, so strip a leading
|
||||||
|
* `plg_<group>_` to get the real element; components/modules use id as-is
|
||||||
|
* - plugins ALSO match folder = the <file> "group" attribute
|
||||||
|
*
|
||||||
|
* FAILS OPEN: any error (unreadable manifest, query failure) returns [] so a
|
||||||
|
* transient glitch never turns a good install into a false failure.
|
||||||
|
*
|
||||||
|
* @param InstallerAdapter $adapter The package installer adapter.
|
||||||
|
*
|
||||||
|
* @return string[]
|
||||||
|
*/
|
||||||
|
private function missingChildExtensions(InstallerAdapter $adapter): array
|
||||||
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
$manifest = $adapter->getParent()->getManifest();
|
||||||
|
|
||||||
|
if (!$manifest || !isset($manifest->files) || !isset($manifest->files->file))
|
||||||
|
{
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
|
||||||
|
$db = Factory::getDbo();
|
||||||
|
$missing = [];
|
||||||
|
|
||||||
|
foreach ($manifest->files->file as $file)
|
||||||
|
{
|
||||||
|
$attrs = $file->attributes();
|
||||||
|
$id = isset($attrs['id']) ? (string) $attrs['id'] : '';
|
||||||
|
$exType = isset($attrs['type']) ? (string) $attrs['type'] : '';
|
||||||
|
|
||||||
|
if ($id === '' || $exType === '')
|
||||||
|
{
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
$group = isset($attrs['group']) ? (string) $attrs['group'] : '';
|
||||||
|
$element = $id;
|
||||||
|
|
||||||
|
// Plugin element in #__extensions is the id minus any leading plg_<group>_.
|
||||||
|
if ($exType === 'plugin' && $group !== '')
|
||||||
|
{
|
||||||
|
$prefix = 'plg_' . $group . '_';
|
||||||
|
|
||||||
|
if (strpos($element, $prefix) === 0)
|
||||||
|
{
|
||||||
|
$element = substr($element, \strlen($prefix));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
$query = $db->getQuery(true)
|
||||||
|
->select('COUNT(*)')
|
||||||
|
->from($db->quoteName('#__extensions'))
|
||||||
|
->where($db->quoteName('element') . ' = ' . $db->quote($element))
|
||||||
|
->where($db->quoteName('type') . ' = ' . $db->quote($exType));
|
||||||
|
|
||||||
|
if ($exType === 'plugin' && $group !== '')
|
||||||
|
{
|
||||||
|
$query->where($db->quoteName('folder') . ' = ' . $db->quote($group));
|
||||||
|
}
|
||||||
|
|
||||||
|
if ((int) $db->setQuery($query)->loadResult() === 0)
|
||||||
|
{
|
||||||
|
$label = trim((string) $file);
|
||||||
|
$missing[] = $label !== '' ? preg_replace('/\.zip$/i', '', $label) : $id;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return $missing;
|
||||||
|
}
|
||||||
|
catch (\Throwable $e)
|
||||||
|
{
|
||||||
|
// Fail open — never fake a failure on a glitch.
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
private function warnMissingLicenseKey(): void
|
private function warnMissingLicenseKey(): void
|
||||||
{
|
{
|
||||||
try
|
try
|
||||||
|
|||||||
Reference in New Issue
Block a user