MokoConsulting/MokoSuiteStoreLocator
1
0
Fork 0
Code Issues 6 Pull Requests 1 Releases 2 Wiki Activity

Admin menu: use COM_..._SHORT short-name constant + fix MOKOJOOM stem #75

New Issue
Closed
opened 2026-07-06 03:02:24 +00:00 by jmiller · 2 comments
jmiller commented 2026-07-06 03:02:24 +00:00
Owner
Copy Link
Copy Source

Part of the org-wide MokoSuite component naming/consistency pass.

Current: the top-level Administrator → Components menu item uses the full constant COM_MOKOJOOMSTORELOCATOR (no short form), and the constant stem is MOKOJOOM… rather than MOKOSUITE… / the actual element name.

Required (match MokoSuiteHQ / MokoSuiteClient):

  1. Set the manifest's top-level <administration><menu> to COM_<ELEMENT>_SHORT.
  2. Define COM_<ELEMENT>_SHORT="Store Locator" in the component's .sys.ini.
  3. Stem consistency: reconcile the MOKOJOOM prefix — the language-constant stem should match the component element (e.g. com_mokosuitestorelocator → COM_MOKOSUITESTORELOCATOR_*). Confirm the intended element name.

Suggested short value: "Store Locator".

Part of the org-wide MokoSuite component naming/consistency pass. **Current:** the top-level Administrator → Components menu item uses the full constant `COM_MOKOJOOMSTORELOCATOR` (no short form), and the constant stem is `MOKOJOOM…` rather than `MOKOSUITE…` / the actual element name. **Required (match MokoSuiteHQ / MokoSuiteClient):** 1. Set the manifest's top-level `<administration><menu>` to `COM_<ELEMENT>_SHORT`. 2. Define `COM_<ELEMENT>_SHORT="Store Locator"` in the component's **`.sys.ini`**. 3. **Stem consistency:** reconcile the `MOKOJOOM` prefix — the language-constant stem should match the component element (e.g. `com_mokosuitestorelocator` → `COM_MOKOSUITESTORELOCATOR_*`). Confirm the intended element name. Suggested short value: **"Store Locator"**.
jmiller commented 2026-07-06 03:03:30 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/75-admin-menu-use-com-short-short-name-cons

git fetch origin
git checkout feature/75-admin-menu-use-com-short-short-name-cons
Branch created: [`feature/75-admin-menu-use-com-short-short-name-cons`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteStoreLocator/src/branch/feature/75-admin-menu-use-com-short-short-name-cons) ```bash git fetch origin git checkout feature/75-admin-menu-use-com-short-short-name-cons ```
jmiller commented 2026-07-06 23:47:46 +00:00
Author
Owner
Copy Link
Copy Source

PR opened: #77 — #77 (branch fix/short-menu-constant → dev, not merged).

Summary:

  • (A) Renamed the language-key stem COM_MOKOJOOMSTORELOCATOR* → COM_MOKOSUITESTORELOCATOR* across 24 files (3 language .ini, 4 forms, 7 templates, 9 admin src PHP, 1 map-module template) — definitions and references changed in lockstep.
  • (B) Added COM_MOKOSUITESTORELOCATOR_SHORT="Store Locator" to all 3 language files and pointed the manifest <administration><menu> at COM_MOKOSUITESTORELOCATOR_SHORT.

The pre-existing full-name key COM_MOKOSUITESTORELOCATOR="MokoSuite Store Locator" was preserved; the old bare COM_MOKOJOOMSTORELOCATOR="Store Locator" became the new _SHORT (avoiding a duplicate-key collision).

Confirmed element/identity was NOT touched: <name>com_mokosuitestorelocator</name>, the com_mokosuitestorelocator folder/element, the Moko\Component\MokoSuiteStoreLocator namespace, the #__mokosuitestorelocator DB prefix, and all file paths are unchanged. This is a language-string key rename only.

Residual COM_MOKOJOOMSTORELOCATOR count on the branch = 0.

PR opened: #77 — https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteStoreLocator/pulls/77 (branch `fix/short-menu-constant` → `dev`, not merged). Summary: - **(A)** Renamed the language-key stem `COM_MOKOJOOMSTORELOCATOR*` → `COM_MOKOSUITESTORELOCATOR*` across 24 files (3 language `.ini`, 4 forms, 7 templates, 9 admin `src` PHP, 1 map-module template) — definitions and references changed in lockstep. - **(B)** Added `COM_MOKOSUITESTORELOCATOR_SHORT="Store Locator"` to all 3 language files and pointed the manifest `<administration><menu>` at `COM_MOKOSUITESTORELOCATOR_SHORT`. The pre-existing full-name key `COM_MOKOSUITESTORELOCATOR="MokoSuite Store Locator"` was preserved; the old bare `COM_MOKOJOOMSTORELOCATOR="Store Locator"` became the new `_SHORT` (avoiding a duplicate-key collision). Confirmed element/identity was NOT touched: `<name>com_mokosuitestorelocator</name>`, the `com_mokosuitestorelocator` folder/element, the `Moko\Component\MokoSuiteStoreLocator` namespace, the `#__mokosuitestorelocator` DB prefix, and all file paths are unchanged. This is a language-string key rename only. Residual `COM_MOKOJOOMSTORELOCATOR` count on the branch = 0.
Sign in to join this conversation.
Labels
Clear labels
area/admin
Administrator interface
 area/component
Core component (com_mokojoomstorelocator)
 area/database
Database schema or queries
 area/frontend
Site/frontend display
 area/import-export
Data import/export features
 area/module-map
Map module (mod_mokojoomstorelocator_map)
 area/module-search
Search module (mod_mokojoomstorelocator_search)
 priority/critical
Must have for v1.0
 priority/high
Important for initial release
 priority/low
Future enhancement
 priority/medium
Nice to have for v1.0
 type/bug
Something is broken
 type/docs
Documentation
 type/enhancement
Improvement to existing feature
 type/feature
New feature or functionality
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority Medium
Type Feature
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteStoreLocator#75
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?