chore: Category junction cleanup on location/category delete #60

New Issue

2026-06-28T15:36:33Z

jmiller commented

2026-06-28 15:36:33 +00:00

Summary

When a location or category is deleted, orphan rows remain in the #__mokosuitestorelocator_location_categories junction table. No cascade delete or cleanup logic exists.

Fix

Either:

Add ON DELETE CASCADE foreign keys to the junction table
Or add cleanup logic in LocationTable::delete() and CategoryTable::delete() to remove junction rows

Option 1 is preferred if the DB engine supports it (InnoDB). Option 2 is the Joomla-conventional approach using Table events.

Priority

P4 — data hygiene, no user-visible impact unless junction table grows large.

## Summary When a location or category is deleted, orphan rows remain in the `#__mokosuitestorelocator_location_categories` junction table. No cascade delete or cleanup logic exists. ## Fix Either: 1. Add `ON DELETE CASCADE` foreign keys to the junction table 2. Or add cleanup logic in `LocationTable::delete()` and `CategoryTable::delete()` to remove junction rows Option 1 is preferred if the DB engine supports it (InnoDB). Option 2 is the Joomla-conventional approach using Table events. ## Priority P4 — data hygiene, no user-visible impact unless junction table grows large.

jmiller commented

2026-06-28 15:36:37 +00:00

Branch created: feature/60-chore-category-junction-cleanup-on-locat

git fetch origin
git checkout feature/60-chore-category-junction-cleanup-on-locat

Branch created: [`feature/60-chore-category-junction-cleanup-on-locat`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteStoreLocator/src/branch/feature/60-chore-category-junction-cleanup-on-locat) ```bash git fetch origin git checkout feature/60-chore-category-junction-cleanup-on-locat ```

jmiller commented

2026-06-28 15:51:32 +00:00

Fixed:

LocationTable::delete() — cleans up location_categories junction rows where location_id matches
CategoryTable::delete() — cleans up location_categories junction rows where category_id matches
Uses Joomla Table override pattern: parent::delete() first, then junction cleanup

Fixed: - `LocationTable::delete()` — cleans up `location_categories` junction rows where `location_id` matches - `CategoryTable::delete()` — cleans up `location_categories` junction rows where `category_id` matches - Uses Joomla Table override pattern: parent::delete() first, then junction cleanup

jmiller closed this issue

2026-06-28 15:52:04 +00:00

jmiller referenced this issue from a commit

2026-06-28 16:22:52 +00:00

fix: resolve all open issues — detail map, clustering, CSP, GROUP BY, cleanup (#34 #57 #58 #59 #60 #61)

jmiller referenced this issue

2026-06-28 18:49:29 +00:00

v1.2.0 — Categories, API, hardening, polish #62

Sign in to join this conversation.