feat: v1.1 competitive parity — proximity, directions, geocoding, CSV import #55

Merged

jmiller merged 4 commits from feature/v1.1-parity into main 2026-06-23 17:26:46 +00:00

Conversation 0 Commits 4 Files Changed 42

+648 -1254

jmiller commented 2026-06-23 16:54:05 +00:00

Owner

Copy Link

Copy Source

Summary

Closes the four critical feature gaps identified in competitive analysis (#54). All competitors (Ideal, JSP, Hotspots, Novacore) have these features — MokoSuite now matches them while remaining free/GPL and API-key-free.

1. Haversine Proximity Search

• LocationsModel filters by great-circle distance using the Haversine formula
• populateState() captures lat/lng/radius/radius_unit from search module form
• Results sorted by distance ASC when proximity filter active
• Hidden radius_unit field bridges module params to component model

2. Get Directions

• Google Maps ?api=1 link on location detail page — no API key needed
• Directions link in every Leaflet map popup marker
• Works cross-platform: opens native app on mobile, web on desktop

3. Auto-Geocoding (Nominatim/OSM)

• LocationModel::save() override detects empty coordinates with address present
• Calls Nominatim API to auto-populate lat/lng
• Success/failure messages via Joomla message queue
• Respects rate limits (only fires on individual admin saves)

4. CSV Import

• ImportController + ImportModel + Import view with upload form
• Auto-detects column headers (title/name/store, address/street, city, lat, etc.)
• Per-row validation via LocationTable::bind()->check()->store()
• Configurable delimiter (comma, semicolon, pipe, tab)
• Toolbar button + submenu item for quick access

Files Changed (15)

• 4 new files (ImportController, ImportModel, Import HtmlView, import template)
• 11 modified files (models, templates, language, manifest, changelog, readme)

Test Plan

• Search with radius: select radius + use geolocation → results filtered by distance
• Search without radius: default ordering preserved
• Detail page: "Get Directions" button visible when coordinates exist
• Map popup: directions link appears below phone
• New location with address, no coords: save → coords auto-populated
• New location with coords already set: save → no geocoding triggered
• Geocoding API down: save succeeds with warning, coords remain empty
• CSV import: upload file with title,address,city,state,lat,lng columns → locations created
• CSV import: missing title → row skipped with error message
• CSV import: CSRF token validated

## Summary Closes the four critical feature gaps identified in competitive analysis (#54). All competitors (Ideal, JSP, Hotspots, Novacore) have these features — MokoSuite now matches them while remaining free/GPL and API-key-free. ### 1. Haversine Proximity Search - `LocationsModel` filters by great-circle distance using the Haversine formula - `populateState()` captures lat/lng/radius/radius_unit from search module form - Results sorted by distance ASC when proximity filter active - Hidden `radius_unit` field bridges module params to component model ### 2. Get Directions - Google Maps `?api=1` link on location detail page — no API key needed - Directions link in every Leaflet map popup marker - Works cross-platform: opens native app on mobile, web on desktop ### 3. Auto-Geocoding (Nominatim/OSM) - `LocationModel::save()` override detects empty coordinates with address present - Calls Nominatim API to auto-populate lat/lng - Success/failure messages via Joomla message queue - Respects rate limits (only fires on individual admin saves) ### 4. CSV Import - `ImportController` + `ImportModel` + Import view with upload form - Auto-detects column headers (title/name/store, address/street, city, lat, etc.) - Per-row validation via `LocationTable::bind()->check()->store()` - Configurable delimiter (comma, semicolon, pipe, tab) - Toolbar button + submenu item for quick access ## Files Changed (15) - 4 new files (ImportController, ImportModel, Import HtmlView, import template) - 11 modified files (models, templates, language, manifest, changelog, readme) ## Test Plan - [ ] Search with radius: select radius + use geolocation → results filtered by distance - [ ] Search without radius: default ordering preserved - [ ] Detail page: "Get Directions" button visible when coordinates exist - [ ] Map popup: directions link appears below phone - [ ] New location with address, no coords: save → coords auto-populated - [ ] New location with coords already set: save → no geocoding triggered - [ ] Geocoding API down: save succeeds with warning, coords remain empty - [ ] CSV import: upload file with title,address,city,state,lat,lng columns → locations created - [ ] CSV import: missing title → row skipped with error message - [ ] CSV import: CSRF token validated

jmiller added 1 commit 2026-06-23 16:54:06 +00:00

feat: v1.1 competitive parity — proximity search, directions, geocoding, CSV import ... 7ef9a23ef8

Haversine proximity search:
- LocationsModel filters by distance using Haversine formula
- populateState captures lat/lng/radius/radius_unit from search form
- Distance-sorted results when proximity filter is active
- Hidden radius_unit field added to search module form

Get Directions:
- Google Maps directions link on location detail page (no API key)
- Directions link in Leaflet popup markers

Auto-geocoding:
- LocationModel::save() override auto-geocodes empty coordinates
- Calls Nominatim/OSM API when address present but coords missing
- Success/failure messages via Joomla enqueueMessage

CSV Import:
- ImportController handles file upload with CSRF token check
- ImportModel parses CSV via SplFileObject with configurable delimiter
- Auto-detects column headers (title/name, address/street, city, etc.)
- Per-row validation via LocationTable::bind()->check()->store()
- Import view with upload form, delimiter picker, and column help
- Toolbar button and submenu item for import access

Addresses #54

Authored-by: Moko Consulting

jmiller added 1 commit 2026-06-23 17:07:12 +00:00

fix: code review fixes — security, 0-coord bug, BOM, ACL ... c8a3c58495

Security:
- ACL check (core.create) in ImportController before processing
- File extension validation (.csv/.txt only) on upload
- Website href restricted to http/https scheme (prevents javascript: XSS)

Bug fixes:
- Fix 0.0 coordinate rejection: use null checks instead of != 0.0
  (coordinates at equator/prime meridian are valid locations)
- Fix Haversine guard using !== null instead of PHP truthiness
- Fix geocoding result check: isset+is_numeric instead of !empty
- Strip UTF-8 BOM from first CSV header (fixes Excel-generated imports)
- Cap radius at 25000 to prevent unreasonable distance queries

Authored-by: Moko Consulting

jmiller referenced this pull request 2026-06-23 17:08:30 +00:00

Competitive analysis: feature gaps vs Joomla store locator market #54

jmiller added 1 commit 2026-06-23 17:23:12 +00:00

chore: remove legacy source/src/ directory (old MokoJoom naming) ... ddb25fa99f

Delete 26 files from the pre-rename MokoJoomStoreLocator structure.
These were superseded by source/packages/ with MokoSuite naming.
No workflow or manifest references remain to the old paths.

Closes #52

Authored-by: Moko Consulting

jmiller added 1 commit 2026-06-23 17:26:22 +00:00

fix: review round 2 — geocode 0-coord, tel: sanitization, Factory ACL ... c56f3473b1

- Fix geocoding trigger: use isset+is_numeric instead of !empty for
  coordinate detection (same 0.0 bug pattern as Haversine fix)
- Sanitize tel: href to digits/+/-/() only (prevents URI injection)
- Use Factory::getApplication() for ACL check (consistent with codebase)

Authored-by: Moko Consulting

jmiller merged commit cc70e4abc2 into main 2026-06-23 17:26:46 +00:00

jmiller deleted branch feature/v1.1-parity 2026-06-23 17:26:47 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

area/admin

Administrator interface

area/component

Core component (com_mokojoomstorelocator)

area/database

Database schema or queries

area/frontend

Site/frontend display

area/import-export

Data import/export features

area/module-map

Map module (mod_mokojoomstorelocator_map)

area/module-search

Search module (mod_mokojoomstorelocator_search)

priority/critical

Must have for v1.0

priority/high

Important for initial release

priority/low

Future enhancement

priority/medium

Nice to have for v1.0

type/bug

Something is broken

type/docs

Documentation

type/enhancement

Improvement to existing feature

type/feature

New feature or functionality

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteStoreLocator#55