fix: honest installer success for MokoSuiteStoreLocator package
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 11s

Package postflight now verifies every bundled child extension declared
in the manifest actually landed in #__extensions before enqueueing the
license/next-steps message. If any child is missing it enqueues an error
and returns instead of reporting a false success. Verification fails open
so a transient DB/IO glitch never turns a good install into a false
failure. Housekeeping (download-key restore) still runs unconditionally.

Claude-Session: https://claude.ai/code/session_01B9aZHSWbiiZykJD88pYx8R
This commit is contained in:
2026-07-06 11:14:07 -05:00
parent eed0d43991
commit 6b5573b12a
2 changed files with 110 additions and 0 deletions
+109
View File
@@ -128,12 +128,121 @@ class Pkg_MokosuitestorelocatorInstallerScript implements InstallerScriptInterfa
*/
public function postflight(string $type, InstallerAdapter $parent): bool
{
// Housekeeping runs unconditionally.
$this->restoreDownloadKey();
// Be honest about success. Joomla's package installer only LOGS a failed
// child sub-install but still runs this postflight, so don't show the
// license / next-steps message if a bundled extension is actually missing.
// Fails open (see missingChildExtensions) so a query/IO glitch never fakes
// a failure.
$missing = $this->missingChildExtensions($parent);
if (!empty($missing))
{
\Joomla\CMS\Factory::getApplication()->enqueueMessage(
'<h4>MokoSuiteStoreLocator did not install correctly.</h4>'
. '<p>The following bundled extensions are missing: '
. htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '</p>'
. '<p>Please uninstall MokoSuiteStoreLocator and reinstall the full package.</p>',
'error'
);
return true;
}
// Success / next-steps path — only reached when every child installed.
$this->warnMissingLicenseKey();
return true;
}
/**
* Verify every child extension declared in the package manifest actually landed
* in #__extensions. Returns readable labels of any that are missing.
*
* Matching per Joomla's #__extensions uniqueness:
* - type = the <file> "type" attribute
* - element = the <file> "id" attribute, EXCEPT for plugins the manifest often
* declares the full `plg_<group>_<element>` id, so strip a leading
* `plg_<group>_` to get the real element; components/modules use id as-is
* - plugins ALSO match folder = the <file> "group" attribute
*
* FAILS OPEN: any error (unreadable manifest, query failure) returns [] so a
* transient glitch never turns a good install into a false failure.
*
* @param InstallerAdapter $parent The parent installer object.
*
* @return array Readable labels of missing child extensions.
*
* @since 1.0.0
*/
private function missingChildExtensions(InstallerAdapter $parent): array
{
try
{
$manifest = $parent->getParent()->getManifest();
if (!$manifest || !isset($manifest->files) || !isset($manifest->files->file))
{
return [];
}
$db = \Joomla\CMS\Factory::getDbo();
$missing = [];
foreach ($manifest->files->file as $file)
{
$attrs = $file->attributes();
$id = isset($attrs['id']) ? (string) $attrs['id'] : '';
$exType = isset($attrs['type']) ? (string) $attrs['type'] : '';
if ($id === '' || $exType === '')
{
continue;
}
$group = isset($attrs['group']) ? (string) $attrs['group'] : '';
$element = $id;
// Plugin element in #__extensions is the id minus any leading plg_<group>_.
if ($exType === 'plugin' && $group !== '')
{
$prefix = 'plg_' . $group . '_';
if (strpos($element, $prefix) === 0)
{
$element = substr($element, \strlen($prefix));
}
}
$query = $db->getQuery(true)
->select('COUNT(*)')
->from($db->quoteName('#__extensions'))
->where($db->quoteName('element') . ' = ' . $db->quote($element))
->where($db->quoteName('type') . ' = ' . $db->quote($exType));
if ($exType === 'plugin' && $group !== '')
{
$query->where($db->quoteName('folder') . ' = ' . $db->quote($group));
}
if ((int) $db->setQuery($query)->loadResult() === 0)
{
$label = trim((string) $file);
$missing[] = $label !== '' ? preg_replace('/\.zip$/i', '', $label) : $id;
}
}
return $missing;
}
catch (\Throwable $e)
{
// Fail open — never fake a failure on a glitch.
return [];
}
}
private ?string $savedDownloadKey = null;
private function saveDownloadKey(): void