ImageGenerator uses @ error suppression — silent failures on missing GD/font #49

New Issue

2026-06-21T14:54:42Z

jmiller commented

2026-06-21 14:54:42 +00:00

Problem

ImageGenerator.php uses the @ error suppression operator on all GD library function calls. If the GD extension is missing, a TTF font file is not found, or image creation fails, errors are completely silenced with no logging.

Impact

Debugging image generation failures is extremely difficult
Sites without GD get no feedback that image generation is broken
Missing font files produce blank/broken images with no warning

Fix

Replace @ suppression with proper error checking
Log failures via Log::add() at WARNING level
Return graceful fallback (null/false) when generation fails

File

source/packages/plg_system_mokoog/src/Helper/ImageGenerator.php

## Problem `ImageGenerator.php` uses the `@` error suppression operator on all GD library function calls. If the GD extension is missing, a TTF font file is not found, or image creation fails, errors are completely silenced with no logging. ## Impact - Debugging image generation failures is extremely difficult - Sites without GD get no feedback that image generation is broken - Missing font files produce blank/broken images with no warning ## Fix - Replace `@` suppression with proper error checking - Log failures via `Log::add()` at WARNING level - Return graceful fallback (null/false) when generation fails ## File - `source/packages/plg_system_mokoog/src/Helper/ImageGenerator.php`

jmiller added the enhancement production-readiness labels 2026-06-21 14:54:42 +00:00

jmiller commented

2026-06-21 14:54:50 +00:00

Branch created: feature/49-imagegenerator-uses-error-suppression-si

git fetch origin
git checkout feature/49-imagegenerator-uses-error-suppression-si

Branch created: [`feature/49-imagegenerator-uses-error-suppression-si`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteOpenGraph/src/branch/feature/49-imagegenerator-uses-error-suppression-si) ```bash git fetch origin git checkout feature/49-imagegenerator-uses-error-suppression-si ```

jmiller referenced this issue

2026-06-21 16:11:59 +00:00

No TTF font file bundled or documented for image text overlay #50

jmiller closed this issue

2026-06-21 16:15:50 +00:00

jmiller referenced this issue from a commit

2026-06-21 20:27:33 +00:00

fix: replace GD error suppression with logging, remove dead adapters (#49, #36)

jmiller referenced this issue

2026-06-21 20:32:49 +00:00

v1.0 assessment: fix all blockers, add MokoSuiteShop, close 18 issues #54

Sign in to join this conversation.