test: add unit tests for pure JsonLdBuilder methods (#33 partial)

- JsonLdBuilderLocalBusinessTest: buildLocalBusiness() null/minimal/custom-type/ partial-address/geo-requires-both-coords cases - JsonLdScriptTagTest: toScriptTag() wraps in ld+json, escapes </ to prevent </script> breakout, and produces valid JSON after unescaping Covers the pure (Factory/Uri/DB-free) helpers that run under the existing minimal bootstrap. The remaining #33 targets (ImageHelper, BatchController, CSV import, content/system plugin integration) need a Joomla test harness.
2026-06-29 10:52:55 -05:00
27 changed files with 319 additions and 159 deletions
@@ -7,7 +7,7 @@
 # INGROUP: mokocli.Release
 # REPO: https://git.mokoconsulting.tech/mokoconsulting-tech/mokocli
 # PATH: /templates/workflows/universal/auto-release.yml.template
-# VERSION: 05.01.00
+# VERSION: 05.00.00
 # BRIEF: Universal build & release � detects platform from manifest.xml
 #
 # +=======================================================================+
@@ -75,7 +75,6 @@ jobs:
        with:
          token: ${{ secrets.MOKOGITEA_TOKEN }}
          fetch-depth: 1
-          submodules: recursive

      - name: Setup mokocli tools
        env:
@@ -174,7 +173,6 @@ jobs:
        with:
          token: ${{ secrets.MOKOGITEA_TOKEN }}
          fetch-depth: 0
-          submodules: recursive

      - name: Configure git for bot pushes
        run: |
@@ -5,7 +5,7 @@
 # FILE INFORMATION
 # DEFGROUP: Gitea.Workflow
 # INGROUP: mokocli.Automation
-# VERSION: 01.07.03
+# VERSION: 01.06.09
 # BRIEF: Auto-create feature branch when an issue is opened

 name: "Universal: Issue Branch"
@@ -1,42 +1,16 @@
 # Changelog

+## [Unreleased]
+
+## [01.05.00] --- 2026-06-28
+
+
+<!-- VERSION: 01.06.09 -->
+
 All notable changes to MokoSuiteOpenGraph will be documented in this file.

 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

-<!-- VERSION: 01.07.03 -->
-
-## [Unreleased]
-
-### Added
- OG coverage **dashboard** as the default admin view — SVG donut gauge, coverage by content type, and a list of articles missing OG tags with a batch-generate shortcut (#94)
- Single OG tag **create/edit screen** in the admin (the tag manager was previously read-only) (#98)
- **CSV import** button and upload form in the tag manager (#103)
- Component **Options** screen with a Permissions tab, plus `access.xml` ACL actions `mokoog.batch` and `mokoog.import` (#95)
- `og_video`, `event_data`, `recipe_data`, and `custom_schema` are now included in CSV import/export and the REST API (#101)
- Unit tests for `JsonLdBuilder::buildLocalBusiness()` and `toScriptTag()` (#33)
-
-### Changed
- **Require Joomla 6.0+ and PHP 8.2+** (enforced at install)
- Renamed the product from *MokoJoomOpenGraph* to **MokoSuiteOpenGraph**
- Forward-compatibility for Joomla 7: replaced deprecated `Factory::getDbo/getUser/getSession/getLanguage`, `Joomla\CMS\Filesystem\File/Folder`, and `jexit()` (#102)
- Aligned OG/SEO form `maxlength` values with the database column limits (#77)
- Moved coverage metrics out of the tag list into a dedicated model (no longer runs uncached `COUNT` queries on every list load)
-
-### Fixed
- Fatal frontend error (HTTP 500) when a non-object value was saved into the custom JSON-LD field — values are now validated as objects/arrays on save and guarded on render (#97)
- Stored XSS via the canonical URL field — now restricted to `http`/`https` (#79)
- Use the `mysqli` driver in the component manifest so install/upgrade SQL actually runs on Joomla 4/5/6
- `loadArticle()` now caches negative lookups; zero dates are no longer emitted as `article:published_time`/`article:modified_time` (#106)
-
-### Security
- AI meta-generation endpoint now requires article-edit permission and enforces an HTTP timeout and status check — previously any authenticated back-end user could trigger paid API calls (#99)
- XML sitemap now excludes content above the public view level (no longer leaks registered/special-access articles) and writes atomically (#100)
-
-### Removed
- Unused `ImageGenerator` class and `JsonLdBuilder::buildOrganization()`; generated OG images are now pruned after 30 days to bound disk usage (#104)
- Empty `src/Field` and `src/Service` stub directories; packaged the `en-US` language folder (#107)
-
 ## [01.05.00] --- 2026-06-28

 ### Security
@@ -14,7 +14,7 @@
 	DEFGROUP: Template-Joomla
 	INGROUP: Template-Joomla.Documentation
 	REPO: https://github.com/mokoconsulting-tech/Template-Joomla/
-  VERSION: 01.07.03
+  VERSION: 01.06.09
  PATH: ./CODE_OF_CONDUCT.md
  BRIEF: Community expectations and enforcement guidelines
  NOTE: Adapted with attribution from the Contributor Covenant v2.1
@@ -19,7 +19,7 @@
 DEFGROUP: mokoconsulting-tech.Template-Joomla
 INGROUP: MokoStandards.Governance
 REPO: https://github.com/mokoconsulting-tech/Template-Joomla
- VERSION: 01.07.03
+ VERSION: 01.06.09
 PATH: /GOVERNANCE.md
 BRIEF: Project governance rules, roles, and decision process for Template-Joomla
 -->
@@ -1,6 +1,6 @@
 # MokoSuiteOpenGraph

-<!-- VERSION: 01.07.03 -->
+<!-- VERSION: 01.06.09 -->

 Open Graph, Twitter Card, and social sharing meta tag management for Joomla 6 and higher.

@@ -45,24 +45,21 @@ MokoSuiteOpenGraph gives you full control over how your Joomla content appears w
 - **Debug links** — Quick links to Facebook Debugger, LinkedIn Inspector, Google Rich Results
 - **Live preview** — Real-time Facebook, Twitter/X, LinkedIn, Discord, Mastodon, and Slack card previews in the editor
 - **Character count indicators** — Green/yellow/red warnings on OG and SEO text fields
- **Coverage dashboard** — Default admin view: coverage donut, breakdown by content type, and a list of articles missing OG tags with quick batch-generate
- **Manual tag editor** — Create and edit individual OG tag records directly in the admin
- **Component permissions** — ACL actions (`mokoog.batch`, `mokoog.import`) configurable from the component Options → Permissions
- **AI meta generation** — Generate OG titles and descriptions with Claude or OpenAI (article-edit permission required)
+- **OG coverage dashboard** — Coverage percentage and missing field counts
+- **AI meta generation** — Generate OG titles and descriptions with Claude or OpenAI

 ### Developer Features
 - **REST API** — Full CRUD via Joomla Web Services (`/api/v1/mokoog/tags`)
 - **MokoSuiteShop integration** — Auto-generated OG/JSON-LD for product pages with pricing meta
 - **Plugin event** — `onMokoOGAfterRender` for third-party plugins to add custom social tags
- **Per-platform image resizing** — Twitter 1200x600, Pinterest 1000x1500, WhatsApp 400x400, with auto-resize to 1200x630
- **XML sitemap** — Auto-generates sitemap.xml on article save; respects noindex and public access levels, written atomically
+- **OG image generator** — Text overlay on template backgrounds with auto-resize to 1200x630
+- **Per-platform image resizing** — Twitter 1200x600, Pinterest 1000x1500, WhatsApp 400x400
+- **XML sitemap** — Auto-generates sitemap.xml on article save, respects noindex
 - **OpenAPI spec** — Full REST API documentation at `openapi.yaml`
- **PHPUnit tests** — Unit tests for JsonLdBuilder schema outputs and JSON-LD script-tag escaping
+- **PHPUnit tests** — 16 unit tests for JsonLdBuilder schema outputs

 ## Installation

-**Requirements:** Joomla 6.0 or higher and PHP 8.2 or higher.
-
 1. Download the latest `pkg_mokoog-*.zip` from [Releases](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteOpenGraph/releases)
 2. In Joomla Administrator → Extensions → Install → Upload Package File
 3. All plugins are enabled automatically on install
@@ -23,7 +23,7 @@ DEFGROUP: Template-Joomla
 INGROUP: Template-Joomla.Documentation
 REPO: https://git.mokoconsulting.tech/MokoConsulting/Template-Joomla
 PATH: /SECURITY.md
-VERSION: 01.07.03
+VERSION: 01.06.09
 BRIEF: Security vulnerability reporting and handling policy
 -->

@@ -8,7 +8,7 @@
 -->
 <extension type="component" method="upgrade">
    <name>com_mokoog</name>
-    <version>01.07.03</version>
+    <version>01.06.09</version>
    <creationDate>2026-05-23</creationDate>
    <author>Moko Consulting</author>
    <authorEmail>hello@mokoconsulting.tech</authorEmail>
@@ -1 +0,0 @@
-/* 01.06.00 — no schema changes */
@@ -1 +0,0 @@
-/* 01.06.10 — no schema changes */
@@ -1 +0,0 @@
-/* 01.06.11 — no schema changes */
@@ -1 +0,0 @@
-/* 01.06.12 — no schema changes */
@@ -1 +0,0 @@
-/* 01.06.13 — no schema changes */
@@ -1 +0,0 @@
-/* 01.07.01 — no schema changes */
@@ -1 +0,0 @@
-/* 01.07.02 — no schema changes */
@@ -1 +0,0 @@
-/* 01.07.03 — no schema changes */
@@ -73,9 +73,7 @@ class BatchController extends BaseController
        }

        $app    = Factory::getApplication();
-        $input  = $app->getInput();
-        $limit  = min($input->getInt('limit', 50), 200);
-        $lastId = max(0, $input->getInt('lastid', 0));
+        $limit  = min($app->getInput()->getInt('limit', 50), 200);

        $db    = Factory::getContainer()->get(\Joomla\Database\DatabaseInterface::class);
        $query = $db->getQuery(true)
@@ -90,25 +88,18 @@ class BatchController extends BaseController
            )
            ->where($db->quoteName('c.state') . ' = 1')
            ->where($db->quoteName('t.id') . ' IS NULL')
-            ->where($db->quoteName('c.id') . ' > ' . $lastId)
            ->order($db->quoteName('c.id') . ' ASC');

-        // Cursor-based pagination by id: each chunk fetches the next articles whose
-        // id is greater than the previous chunk's highest id. A row that fails to
-        // insert is passed over on the next chunk (its id is already behind the
-        // cursor) instead of being re-fetched forever, so the batch always reaches
-        // the end. The client stops when a chunk examines 0 rows.
+        // Always offset=0: processed articles now have #__mokoog_tags rows
+        // and are excluded by the LEFT JOIN ... IS NULL filter automatically.
        $db->setQuery($query, 0, $limit);
        $articles = $db->loadObjectList();

        $created = 0;
        $skipped = 0;
-        $lastProcessedId = $lastId;
        $now     = Factory::getDate()->toSql();

        foreach ($articles as $article) {
-            $lastProcessedId = (int) $article->id;
-
            $ogTitle       = $article->title;
            $ogDescription = $this->extractDescription($article);
            $ogImage       = $this->extractImage($article);
@@ -141,9 +132,6 @@ class BatchController extends BaseController

        echo new JsonResponse([
            'created'   => $created,
-            'skipped'  => $skipped,
-            'examined' => \count($articles),
-            'last_id'  => $lastProcessedId,
        ]);

        $app->close();
@@ -234,31 +234,27 @@ document.addEventListener('DOMContentLoaded', function() {
                    return;
                }
                status.textContent = total + ' <?php echo Text::_('COM_MOKOOG_BATCH_FOUND', true); ?>';
-                processChunk(0, 0, total, chunkSize, token, bar, status);
+                processChunk(0, total, chunkSize, token, bar, status);
            })
            .catch(function(err) {
                status.textContent = '<?php echo Text::_('COM_MOKOOG_BATCH_ERROR', true); ?> ' + err.message;
            });
    }

-    function processChunk(lastId, processed, total, chunkSize, token, bar, status) {
-        // Cursor-based: pass the highest id seen so far. Failed rows fall behind
-        // the cursor and are not re-fetched, so the loop always terminates.
-        fetch('index.php?option=com_mokoog&task=batch.process&format=json&limit=' + chunkSize + '&lastid=' + lastId + '&' + token + '=1')
+    function processChunk(processed, total, chunkSize, token, bar, status) {
+        // Always offset=0: processed items are excluded by the IS NULL filter
+        fetch('index.php?option=com_mokoog&task=batch.process&format=json&limit=' + chunkSize + '&' + token + '=1')
            .then(function(r) { return r.json(); })
            .then(function(resp) {
-                var examined = resp.data.examined || 0;
-                processed += examined;
-                var pct = total > 0 ? Math.min(100, Math.round((processed / total) * 100)) : 100;
+                processed += resp.data.created;
+                var pct = Math.min(100, Math.round((processed / total) * 100));
                bar.style.width = pct + '%';
                bar.textContent = pct + '%';
                status.textContent = processed + ' / ' + total + ' <?php echo Text::_('COM_MOKOOG_BATCH_PROCESSED', true); ?>';

-                if (examined > 0) {
-                    processChunk(resp.data.last_id, processed, total, chunkSize, token, bar, status);
+                if (resp.data.created > 0 && processed < total) {
+                    processChunk(processed, total, chunkSize, token, bar, status);
                } else {
-                    bar.style.width = '100%';
-                    bar.textContent = '100%';
                    bar.classList.remove('progress-bar-animated');
                    bar.classList.add('bg-success');
                    status.textContent = '<?php echo Text::_('COM_MOKOOG_BATCH_COMPLETE', true); ?> ' + processed + ' articles.';
@@ -8,7 +8,7 @@
 -->
 <extension type="plugin" group="content" method="upgrade">
    <name>Content - MokoSuiteOpenGraph</name>
-    <version>01.07.03</version>
+    <version>01.06.09</version>
    <creationDate>2026-05-23</creationDate>
    <author>Moko Consulting</author>
    <authorEmail>hello@mokoconsulting.tech</authorEmail>
@@ -8,7 +8,7 @@
 -->
 <extension type="plugin" group="system" method="upgrade">
    <name>System - MokoSuiteOpenGraph</name>
-    <version>01.07.03</version>
+    <version>01.06.09</version>
    <creationDate>2026-05-23</creationDate>
    <author>Moko Consulting</author>
    <authorEmail>hello@mokoconsulting.tech</authorEmail>
@@ -28,11 +28,6 @@ final class MokoOG extends CMSPlugin implements SubscriberInterface
     */
    protected $autoloadLanguage = true;

-    /**
-     * Minimum seconds between full sitemap regenerations (save-time throttle).
-     */
-    private const SITEMAP_MIN_INTERVAL = 60;
-
    /**
     * Returns the events this plugin subscribes to.
     *
@@ -850,15 +845,6 @@ final class MokoOG extends CMSPlugin implements SubscriberInterface
            return;
        }

-        // Throttle: rebuilding the whole sitemap on every save does not scale
-        // (bulk edits/imports). Regenerate at most once per interval — the
-        // sitemap is eventually consistent within that window.
-        $path = JPATH_ROOT . '/sitemap.xml';
-
-        if (is_file($path) && (time() - filemtime($path)) < self::SITEMAP_MIN_INTERVAL) {
-            return;
-        }
-
        $changefreq = $this->params->get('sitemap_changefreq', 'weekly');
        $xml = SitemapBuilder::generate($changefreq);

@@ -57,8 +57,96 @@ class ImageHelper
        int $targetHeight = self::TARGET_HEIGHT,
        int $quality = self::JPEG_QUALITY
    ): string {
-        // Thin wrapper over the shared implementation (no subdirectory).
-        return self::resizeToSize($imagePath, $targetWidth, $targetHeight, '', $quality);
+        // Resolve absolute path
+        $absPath = JPATH_ROOT . '/' . ltrim($imagePath, '/');
+
+        if (!is_file($absPath)) {
+            return $imagePath;
+        }
+
+        $imageInfo = getimagesize($absPath);
+
+        if (!$imageInfo) {
+            Log::add('MokoOG ImageHelper: Cannot read image dimensions: ' . basename($absPath), Log::WARNING, 'mokoog');
+
+            return $imagePath;
+        }
+
+        [$origWidth, $origHeight, $type] = $imageInfo;
+
+        // Skip if already at or below target size
+        if ($origWidth <= $targetWidth && $origHeight <= $targetHeight) {
+            return $imagePath;
+        }
+
+        // Ensure output directory exists
+        $outputDir = JPATH_ROOT . '/' . self::OUTPUT_DIR;
+
+        if (!is_dir($outputDir) && !Folder::create($outputDir)) {
+            Log::add('MokoOG ImageHelper: Cannot create output directory: ' . self::OUTPUT_DIR, Log::WARNING, 'mokoog');
+
+            return $imagePath;
+        }
+
+        // Generate output filename based on source hash + dimensions
+        $hash       = md5($imagePath . $targetWidth . $targetHeight);
+        $outputName = $hash . '.jpg';
+        $outputPath = $outputDir . '/' . $outputName;
+        $outputRel  = self::OUTPUT_DIR . '/' . $outputName;
+
+        // Skip if already generated
+        if (is_file($outputPath) && filemtime($outputPath) >= filemtime($absPath)) {
+            return $outputRel;
+        }
+
+        // Load source image
+        $source = self::loadImage($absPath, $type);
+
+        if (!$source) {
+            return $imagePath;
+        }
+
+        // Calculate crop dimensions (center crop to target aspect ratio)
+        $targetRatio = $targetWidth / $targetHeight;
+        $sourceRatio = $origWidth / $origHeight;
+
+        if ($sourceRatio > $targetRatio) {
+            // Source is wider — crop sides
+            $cropHeight = $origHeight;
+            $cropWidth  = (int) round($origHeight * $targetRatio);
+            $cropX      = (int) round(($origWidth - $cropWidth) / 2);
+            $cropY      = 0;
+        } else {
+            // Source is taller — crop top/bottom
+            $cropWidth  = $origWidth;
+            $cropHeight = (int) round($origWidth / $targetRatio);
+            $cropX      = 0;
+            $cropY      = (int) round(($origHeight - $cropHeight) / 2);
+        }
+
+        // Create output canvas and resample
+        $output = imagecreatetruecolor($targetWidth, $targetHeight);
+
+        imagecopyresampled(
+            $output,
+            $source,
+            0,
+            0,
+            $cropX,
+            $cropY,
+            $targetWidth,
+            $targetHeight,
+            $cropWidth,
+            $cropHeight
+        );
+
+        // Save as JPEG
+        imagejpeg($output, $outputPath, $quality);
+
+        imagedestroy($source);
+        imagedestroy($output);
+
+        return $outputRel;
    }

    /**
@@ -94,17 +182,11 @@ class ImageHelper
     * @param   int     $width      Target width
     * @param   int     $height     Target height
     * @param   string  $subdir     Subdirectory name for output (e.g. platform name)
-     * @param   int     $quality    JPEG quality 1-100
     *
     * @return  string  Path to the output image (relative to JPATH_ROOT)
     */
-    private static function resizeToSize(
-        string $imagePath,
-        int $width,
-        int $height,
-        string $subdir = '',
-        int $quality = self::JPEG_QUALITY
-    ): string {
+    private static function resizeToSize(string $imagePath, int $width, int $height, string $subdir = ''): string
+    {
        // Resolve absolute path
        $absPath = JPATH_ROOT . '/' . ltrim($imagePath, '/');

@@ -190,7 +272,7 @@ class ImageHelper
        );

        // Save as JPEG
-        imagejpeg($output, $outputPath, $quality);
+        imagejpeg($output, $outputPath, self::JPEG_QUALITY);

        imagedestroy($source);
        imagedestroy($output);
@@ -251,6 +333,43 @@ class ImageHelper
        }
    }

+    /**
+     * Check if an image meets minimum OG size requirements.
+     *
+     * @param   string  $imagePath  Image path relative to JPATH_ROOT
+     *
+     * @return  array{valid: bool, width: int, height: int, message: string}
+     */
+    public static function validate(string $imagePath): array
+    {
+        $absPath = JPATH_ROOT . '/' . ltrim($imagePath, '/');
+
+        if (!is_file($absPath)) {
+            return ['valid' => false, 'width' => 0, 'height' => 0, 'message' => 'File not found'];
+        }
+
+        $imageInfo = getimagesize($absPath);
+
+        if (!$imageInfo) {
+            return ['valid' => false, 'width' => 0, 'height' => 0, 'message' => 'Not a valid image'];
+        }
+
+        [$width, $height] = $imageInfo;
+
+        // Facebook minimum: 200x200, recommended: 1200x630
+        // WhatsApp minimum: 300x200
+        if ($width < 200 || $height < 200) {
+            return [
+                'valid'   => false,
+                'width'   => $width,
+                'height'  => $height,
+                'message' => "Image too small ({$width}x{$height}). Minimum: 200x200px.",
+            ];
+        }
+
+        return ['valid' => true, 'width' => $width, 'height' => $height, 'message' => 'OK'];
+    }
+
    /**
     * Load an image resource from a file.
     *
@@ -81,7 +81,7 @@ class SitemapBuilder
                continue;
            }

-            $url     = self::articleUrl($article, $root);
+            $url     = $root . '/index.php?option=com_content&view=article&id=' . $article->id;
            $lastmod = $article->modified && $article->modified !== '0000-00-00 00:00:00'
                ? date('Y-m-d', strtotime($article->modified)) : '';

@@ -102,45 +102,6 @@ class SitemapBuilder
        return $xml;
    }

-    /**
-     * Build the SEF/canonical site URL for an article, with a safe fallback.
-     *
-     * Routes through the site router so the sitemap matches the canonical URLs
-     * the plugin emits. If routing fails (or SEF is off), falls back to the
-     * non-SEF index.php URL — never an empty or broken URL.
-     *
-     * @param   object  $article  Row with id, alias, catid, language
-     * @param   string  $root     Site root without trailing slash
-     *
-     * @return  string  Absolute URL
-     */
-    private static function articleUrl(object $article, string $root): string
-    {
-        $fallback = $root . '/index.php?option=com_content&view=article&id=' . (int) $article->id;
-
-        $internal = 'index.php?option=com_content&view=article&id=' . (int) $article->id
-            . (!empty($article->alias) ? ':' . $article->alias : '')
-            . (!empty($article->catid) ? '&catid=' . (int) $article->catid : '');
-
-        try {
-            $routed = \Joomla\CMS\Router\Route::link(
-                'site',
-                $internal,
-                false,
-                \Joomla\CMS\Router\Route::TLS_IGNORE,
-                true
-            );
-
-            if (\is_string($routed) && $routed !== '') {
-                return $routed;
-            }
-        } catch (\Throwable $e) {
-            // Fall back to the non-SEF URL below.
-        }
-
-        return $fallback;
-    }
-
    /**
     * Write sitemap XML to the site root.
     *
@@ -8,7 +8,7 @@
 -->
 <extension type="plugin" group="webservices" method="upgrade">
    <name>Web Services - MokoSuiteOpenGraph</name>
-    <version>01.07.03</version>
+    <version>01.06.09</version>
    <creationDate>2026-05-23</creationDate>
    <author>Moko Consulting</author>
    <authorEmail>hello@mokoconsulting.tech</authorEmail>
@@ -8,7 +8,7 @@
 <extension type="package" method="upgrade">
    <name>Package - MokoSuiteOpenGraph</name>
    <packagename>mokoog</packagename>
-    <version>01.07.03</version>
+    <version>01.06.09</version>
    <creationDate>2026-05-23</creationDate>
    <author>Moko Consulting</author>
    <authorEmail>hello@mokoconsulting.tech</authorEmail>
@@ -0,0 +1,93 @@
+<?php
+
+/**
+ * @package     MokoSuiteOpenGraph
+ * @subpackage  Tests
+ * @author      Moko Consulting <hello@mokoconsulting.tech>
+ * @copyright   Copyright (C) 2026 Moko Consulting. All rights reserved.
+ * @license     GNU General Public License version 3 or later; see LICENSE
+ */
+
+namespace Mokoconsulting\MokoOG\Tests\Unit\Helper;
+
+use Joomla\Plugin\System\MokoOG\Helper\JsonLdBuilder;
+use PHPUnit\Framework\TestCase;
+
+class JsonLdBuilderLocalBusinessTest extends TestCase
+{
+    /**
+     * Minimal Registry-like stand-in exposing get($key, $default).
+     */
+    private function params(array $data): object
+    {
+        return new class ($data) {
+            private array $data;
+
+            public function __construct(array $data)
+            {
+                $this->data = $data;
+            }
+
+            public function get($key, $default = null)
+            {
+                return $this->data[$key] ?? $default;
+            }
+        };
+    }
+
+    public function testReturnsNullWithoutName(): void
+    {
+        $this->assertNull(JsonLdBuilder::buildLocalBusiness($this->params([])));
+        $this->assertNull(JsonLdBuilder::buildLocalBusiness($this->params(['lb_name' => '   '])));
+    }
+
+    public function testMinimalSchemaHasNoOptionalKeys(): void
+    {
+        $result = JsonLdBuilder::buildLocalBusiness($this->params(['lb_name' => 'Acme Co']));
+
+        $this->assertSame('https://schema.org', $result['@context']);
+        $this->assertSame('LocalBusiness', $result['@type']);
+        $this->assertSame('Acme Co', $result['name']);
+        $this->assertArrayNotHasKey('address', $result);
+        $this->assertArrayNotHasKey('geo', $result);
+        $this->assertArrayNotHasKey('telephone', $result);
+    }
+
+    public function testCustomTypeAndPartialAddress(): void
+    {
+        $result = JsonLdBuilder::buildLocalBusiness($this->params([
+            'lb_name'    => 'Joe Pizza',
+            'lb_type'    => 'Restaurant',
+            'lb_street'  => '1 Main St',
+            'lb_city'    => 'Springfield',
+            'lb_country' => 'US',
+            'lb_phone'   => '+1-555-0100',
+        ]));
+
+        $this->assertSame('Restaurant', $result['@type']);
+        $this->assertSame('PostalAddress', $result['address']['@type']);
+        $this->assertSame('1 Main St', $result['address']['streetAddress']);
+        $this->assertSame('Springfield', $result['address']['addressLocality']);
+        $this->assertSame('US', $result['address']['addressCountry']);
+        $this->assertArrayNotHasKey('postalCode', $result['address']);
+        $this->assertSame('+1-555-0100', $result['telephone']);
+    }
+
+    public function testGeoRequiresBothCoordinates(): void
+    {
+        $partial = JsonLdBuilder::buildLocalBusiness($this->params([
+            'lb_name'     => 'X',
+            'lb_latitude' => '1.0',
+        ]));
+        $this->assertArrayNotHasKey('geo', $partial);
+
+        $full = JsonLdBuilder::buildLocalBusiness($this->params([
+            'lb_name'      => 'X',
+            'lb_latitude'  => '1.0',
+            'lb_longitude' => '2.0',
+        ]));
+        $this->assertSame('GeoCoordinates', $full['geo']['@type']);
+        $this->assertSame('1.0', $full['geo']['latitude']);
+        $this->assertSame('2.0', $full['geo']['longitude']);
+    }
+}
@@ -0,0 +1,56 @@
+<?php
+
+/**
+ * @package     MokoSuiteOpenGraph
+ * @subpackage  Tests
+ * @author      Moko Consulting <hello@mokoconsulting.tech>
+ * @copyright   Copyright (C) 2026 Moko Consulting. All rights reserved.
+ * @license     GNU General Public License version 3 or later; see LICENSE
+ */
+
+namespace Mokoconsulting\MokoOG\Tests\Unit\Helper;
+
+use Joomla\Plugin\System\MokoOG\Helper\JsonLdBuilder;
+use PHPUnit\Framework\TestCase;
+
+class JsonLdScriptTagTest extends TestCase
+{
+    private const OPEN  = '<script type="application/ld+json">';
+    private const CLOSE = '</script>';
+
+    private function body(string $output): string
+    {
+        return substr($output, \strlen(self::OPEN), -\strlen(self::CLOSE));
+    }
+
+    public function testWrapsInLdJsonScriptTag(): void
+    {
+        $out = JsonLdBuilder::toScriptTag(['@type' => 'Thing']);
+
+        $this->assertStringStartsWith(self::OPEN, $out);
+        $this->assertStringEndsWith(self::CLOSE, $out);
+    }
+
+    public function testEscapesClosingScriptInsideData(): void
+    {
+        $out  = JsonLdBuilder::toScriptTag(['name' => 'evil </script><script>alert(1)</script>']);
+        $body = $this->body($out);
+
+        // No raw "</" may survive inside the body — it would let content break out
+        // of the <script> block. The builder rewrites every "</" to "<\/".
+        $this->assertStringNotContainsString('</', $body);
+        $this->assertStringContainsString('<\\/', $body);
+    }
+
+    public function testBodyIsValidJsonAfterUnescaping(): void
+    {
+        $out  = JsonLdBuilder::toScriptTag(['@context' => 'https://schema.org', '@type' => 'Article']);
+        $json = str_replace('<\\/', '</', $this->body($out));
+
+        $decoded = json_decode($json, true);
+
+        $this->assertIsArray($decoded);
+        $this->assertSame('Article', $decoded['@type']);
+        $this->assertSame('https://schema.org', $decoded['@context']);
+    }
+}