MokoConsulting/MokoSuiteNPO
1
0
Fork 0
Code Issues 18 Pull Requests 2 Releases 3 Wiki Activity

Admin menu: use COM_..._SHORT short-name constant (one-word naming pass) #37

New Issue
Closed
opened 2026-07-06 03:01:46 +00:00 by jmiller · 2 comments
jmiller commented 2026-07-06 03:01:46 +00:00
Owner
Copy Link
Copy Source

Part of the org-wide MokoSuite component naming/consistency pass.

Current: the top-level Administrator → Components menu item is a hardcoded literal MokoSuite NPO.

Required (match MokoSuiteHQ / MokoSuiteClient):

  1. Replace the literal in the manifest's top-level <administration><menu> with COM_<ELEMENT>_SHORT.
  2. Define COM_<ELEMENT>_SHORT="NPO" in the component's .sys.ini.

Suggested short value: "NPO".

Part of the org-wide MokoSuite component naming/consistency pass. **Current:** the top-level Administrator → Components menu item is a **hardcoded literal** `MokoSuite NPO`. **Required (match MokoSuiteHQ / MokoSuiteClient):** 1. Replace the literal in the manifest's top-level `<administration><menu>` with `COM_<ELEMENT>_SHORT`. 2. Define `COM_<ELEMENT>_SHORT="NPO"` in the component's **`.sys.ini`**. Suggested short value: **"NPO"**.
jmiller commented 2026-07-06 03:03:26 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/37-admin-menu-use-com-short-short-name-cons

git fetch origin
git checkout feature/37-admin-menu-use-com-short-short-name-cons
Branch created: [`feature/37-admin-menu-use-com-short-short-name-cons`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteNPO/src/branch/feature/37-admin-menu-use-com-short-short-name-cons) ```bash git fetch origin git checkout feature/37-admin-menu-use-com-short-short-name-cons ```
jmiller commented 2026-07-06 22:46:27 +00:00
Author
Owner
Copy Link
Copy Source

Opened PR #41 to resolve this: #41

Adds the COM_MOKOSUITENPO_SHORT="NPO" short-name constant, points the admin <menu> at it (was hardcoded literal MokoSuite NPO), and wires the admin en-GB language so the constant resolves. This supersedes #39 (the _SHORT_NAME duplicate) by using the _SHORT naming that matches sibling components (COM_MOKOSUITEHQ_SHORT).

Opened PR #41 to resolve this: https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteNPO/pulls/41 Adds the `COM_MOKOSUITENPO_SHORT="NPO"` short-name constant, points the admin `<menu>` at it (was hardcoded literal `MokoSuite NPO`), and wires the admin `en-GB` language so the constant resolves. This supersedes #39 (the `_SHORT_NAME` duplicate) by using the `_SHORT` naming that matches sibling components (`COM_MOKOSUITEHQ_SHORT`).
Sign in to join this conversation.
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority Medium
Type Feature
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteNPO#37
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?