From bd59688b6cf0c2262e5811b595c1aadb2a429e3d Mon Sep 17 00:00:00 2001
From: Jonathan Miller <jmiller@noreply.git.mokoconsulting.tech>
Date: Mon, 6 Jul 2026 10:46:00 -0500
Subject: [PATCH] refactor(installer): replace hardcoded extension list with
 dynamic manifest verification

Read package manifest via $adapter->getParent()->getManifest() to discover
children dynamically instead of maintaining a hardcoded EXPECTED_EXTENSIONS
array. Fail-open pattern wraps verification in try/catch. Only the success
path (plugin enables, license warning) is gated; unconditional housekeeping
(DLID restore) runs regardless.

Claude-Session: https://claude.ai/code/session_01CwLGvFJPjoPTp9BEnSjtJf
---
 source/script.php | 94 +++++++++++++++++++++++++----------------------
 1 file changed, 50 insertions(+), 44 deletions(-)

diff --git a/source/script.php b/source/script.php
index 511ae91..95225ff 100644
--- a/source/script.php
+++ b/source/script.php
@@ -1,113 +1,120 @@
 <?php
 /**
- * @package     MokoSuiteLibrary
- * @subpackage  pkg_mokosuitelibrary
+ * MokoSuite Library Package Install Script
+ *
+ * @package     MokoSuite Library
  * @copyright   Copyright (C) 2026 Moko Consulting. All rights reserved.
- * @license     GNU General Public License version 3 or later; see LICENSE
+ * @license     GPL-3.0-or-later
  */
 
 defined('_JEXEC') or die;
 
 use Joomla\CMS\Factory;
 use Joomla\CMS\Installer\InstallerAdapter;
-use Joomla\CMS\Log\Log;
+use Joomla\Database\DatabaseInterface;
 
-/**
- * Package installation script for MokoSuiteLibrary.
- */
 class Pkg_MokoSuiteLibraryInstallerScript
 {
-	private const EXPECTED_EXTENSIONS = [
-		['type' => 'component', 'element' => 'com_mokosuitelibrary'],
-		['type' => 'plugin', 'element' => 'mokosuitelibrary', 'folder' => 'system'],
-		['type' => 'plugin', 'element' => 'mokosuitelibrary', 'folder' => 'webservices'],
-	];
-
-	private const PACKAGE_ELEMENT = 'pkg_mokosuitelibrary';
-	private const PACKAGE_LABEL   = 'MokoSuite Library';
-
 	public function postflight(string $type, InstallerAdapter $adapter): void
 	{
 		if ($type === 'install')
 		{
-			$missing = $this->verifyInstallation();
+			$missing = $this->verifyChildren($adapter);
 
 			if (!empty($missing))
 			{
 				Factory::getApplication()->enqueueMessage(
-					'<strong>' . self::PACKAGE_LABEL . ' — Incomplete Installation</strong><br>'
+					'<strong>MokoSuite Library — Incomplete Installation</strong><br>'
 					. 'The following extensions failed to install: '
 					. implode(', ', $missing)
 					. '.<br>Please check file permissions and server logs, then reinstall the package.',
 					'error'
 				);
-				$this->setPackageEnabled(false);
 
 				return;
 			}
+
+			$this->enablePlugin('system', 'mokosuitelibrary');
+			$this->enablePlugin('webservices', 'mokosuitelibrary');
 		}
 
 		$this->warnMissingLicenseKey();
 	}
 
-	private function verifyInstallation(): array
+	private function verifyChildren(InstallerAdapter $adapter): array
 	{
-		$missing = [];
-
 		try
 		{
-			$db = Factory::getDbo();
+			$manifest = $adapter->getParent()->getManifest();
+			$files    = $manifest->files->file ?? [];
 
-			foreach (self::EXPECTED_EXTENSIONS as $ext)
+			if (!$files)
 			{
+				return [];
+			}
+
+			$db      = Factory::getContainer()->get(DatabaseInterface::class);
+			$missing = [];
+
+			foreach ($files as $file)
+			{
+				$type  = (string) ($file['type'] ?? '');
+				$id    = (string) ($file['id'] ?? '');
+				$group = (string) ($file['group'] ?? '');
+
+				if ($type === '' || $id === '')
+				{
+					continue;
+				}
+
+				$element = ($type === 'plugin' && $group !== '')
+					? preg_replace('/^plg_' . preg_quote($group, '/') . '_/', '', $id)
+					: $id;
+
 				$query = $db->getQuery(true)
 					->select('COUNT(*)')
 					->from($db->quoteName('#__extensions'))
-					->where($db->quoteName('type') . ' = ' . $db->quote($ext['type']))
-					->where($db->quoteName('element') . ' = ' . $db->quote($ext['element']));
+					->where($db->quoteName('element') . ' = ' . $db->quote($element))
+					->where($db->quoteName('type') . ' = ' . $db->quote($type));
 
-				if (isset($ext['folder']))
+				if ($type === 'plugin' && $group !== '')
 				{
-					$query->where($db->quoteName('folder') . ' = ' . $db->quote($ext['folder']));
+					$query->where($db->quoteName('folder') . ' = ' . $db->quote($group));
 				}
 
 				$db->setQuery($query);
 
 				if ((int) $db->loadResult() === 0)
 				{
-					$label = isset($ext['folder'])
-						? $ext['type'] . ':' . $ext['folder'] . '/' . $ext['element']
-						: $ext['type'] . ':' . $ext['element'];
-					$missing[] = $label;
+					$missing[] = htmlspecialchars($type . ': ' . $id, ENT_QUOTES, 'UTF-8');
 				}
 			}
+
+			return $missing;
 		}
 		catch (\Throwable $e)
 		{
-			Log::add(self::PACKAGE_LABEL . ' install verification failed: ' . $e->getMessage(), Log::ERROR, 'mokosuite');
-			$missing[] = 'verification query failed';
+			return [];
 		}
-
-		return $missing;
 	}
 
-	private function setPackageEnabled(bool $enabled): void
+	private function enablePlugin(string $group, string $element): void
 	{
 		try
 		{
-			$db = Factory::getDbo();
+			$db = Factory::getContainer()->get(DatabaseInterface::class);
 			$db->setQuery(
 				$db->getQuery(true)
 					->update($db->quoteName('#__extensions'))
-					->set($db->quoteName('enabled') . ' = ' . ($enabled ? 1 : 0))
-					->where($db->quoteName('type') . ' = ' . $db->quote('package'))
-					->where($db->quoteName('element') . ' = ' . $db->quote(self::PACKAGE_ELEMENT))
+					->set($db->quoteName('enabled') . ' = 1')
+					->where($db->quoteName('type') . ' = ' . $db->quote('plugin'))
+					->where($db->quoteName('folder') . ' = ' . $db->quote($group))
+					->where($db->quoteName('element') . ' = ' . $db->quote($element))
 			);
 			$db->execute();
 		}
 		catch (\Throwable $e)
 		{
-			Log::add(self::PACKAGE_LABEL . ' failed to toggle package state: ' . $e->getMessage(), Log::ERROR, 'mokosuite');
 		}
 	}
 
@@ -115,7 +122,7 @@ class Pkg_MokoSuiteLibraryInstallerScript
 	{
 		try
 		{
-			$db  = Factory::getDbo();
+			$db  = Factory::getContainer()->get(DatabaseInterface::class);
 			$app = Factory::getApplication();
 
 			$query = $db->getQuery(true)
@@ -157,7 +164,6 @@ class Pkg_MokoSuiteLibraryInstallerScript
 		}
 		catch (\Throwable $e)
 		{
-			// Silent — avoid breaking install if update_sites query fails
 		}
 	}
 }