Admin menu: use COM_..._SHORT short-name constant (one-word naming pass) #13

Open
opened 2026-07-06 02:59:57 +00:00 by jmiller · 1 comment
Owner

Part of the org-wide MokoSuite component naming/consistency pass.

Current: the top-level Administrator → Components menu item uses the full constant COM_MOKOSUITESIGHT (element is com_mokosuitesight).

Required (match MokoSuiteHQ / MokoSuiteClient):

  1. Set the manifest's top-level <administration><menu> to COM_MOKOSUITESIGHT_SHORT.
  2. Define COM_MOKOSUITESIGHT_SHORT="Insight" in the component's .sys.ini.

Suggested short value: "Insight".

⚠️ Note: the element/constant stem is mokosuitesight (missing the "in"). Worth confirming whether the element should be com_mokosuiteinsight for consistency with the repo/product name.

Part of the org-wide MokoSuite component naming/consistency pass. **Current:** the top-level Administrator → Components menu item uses the full constant `COM_MOKOSUITESIGHT` (element is `com_mokosuitesight`). **Required (match MokoSuiteHQ / MokoSuiteClient):** 1. Set the manifest's top-level `<administration><menu>` to `COM_MOKOSUITESIGHT_SHORT`. 2. Define `COM_MOKOSUITESIGHT_SHORT="Insight"` in the component's **`.sys.ini`**. Suggested short value: **"Insight"**. ⚠️ Note: the element/constant stem is `mokosuitesight` (missing the "in"). Worth confirming whether the element should be `com_mokosuiteinsight` for consistency with the repo/product name.
Author
Owner

Draft PR opened: #16#16

Goes beyond the _SHORT menu-constant ask and does the full element rename you flagged: com_mokosuitesightcom_mokosuiteinsight (the element was missing the "in"), plus the missing admin .sys.ini with COM_MOKOSUITEINSIGHT_SHORT="Insight" wired into <administration>, and an idempotent postflight install migration (#__extensions/#__menu/#__assets reconcile; no-op on fresh installs) so existing sites don't get a duplicate/orphaned extension.

⚠ BREAKING — held as draft; needs staging test (fresh install + upgrade-from-old) before merge/release. Sibling plg_system_/plg_webservices_/pkg_ element renames and the #__mokosuitesight_* table rename are intentionally excluded (plugin owns the tables; renaming now would break it) and flagged for a follow-up issue. Details in the PR body.

https://claude.ai/code/session_01B9aZHSWbiiZykJD88pYx8R

Draft PR opened: #16 — https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteInsight/pulls/16 Goes beyond the `_SHORT` menu-constant ask and does the full element rename you flagged: **`com_mokosuitesight` → `com_mokosuiteinsight`** (the element was missing the "in"), plus the missing admin `.sys.ini` with `COM_MOKOSUITEINSIGHT_SHORT="Insight"` wired into `<administration>`, and an idempotent postflight install migration (`#__extensions`/`#__menu`/`#__assets` reconcile; no-op on fresh installs) so existing sites don't get a duplicate/orphaned extension. ⚠ BREAKING — held as **draft**; needs staging test (fresh install + upgrade-from-old) before merge/release. Sibling `plg_system_/plg_webservices_/pkg_` element renames and the `#__mokosuitesight_*` table rename are intentionally **excluded** (plugin owns the tables; renaming now would break it) and flagged for a follow-up issue. Details in the PR body. https://claude.ai/code/session_01B9aZHSWbiiZykJD88pYx8R
Sign in to join this conversation.
Priority Medium
Type Feature
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteInsight#13