From 0e3c922b7ad0f20fe350368bb210494eaf8a81d6 Mon Sep 17 00:00:00 2001 From: Jonathan Miller Date: Mon, 6 Jul 2026 11:19:37 -0500 Subject: [PATCH 1/2] fix: honest installer success (gate license/next-steps on child install) The package postflight showed the "License Key Required" / next-steps message even when a bundled child extension failed to sub-install (Joomla only logs those failures). Add a fail-open manifest verifier (missingChildExtensions) that confirms every declared child landed in #__extensions and enqueues an error + returns before the license path when any are missing. Fails open so a transient glitch never fakes a failure. Claude-Session: https://claude.ai/code/session_01B9aZHSWbiiZykJD88pYx8R --- CHANGELOG.md | 3 ++ source/script.php | 95 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 98 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 525c203..7552818 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,9 @@ ## [Unreleased] +### Fixed +- **Honest install success** — the package installer no longer shows the license / next-steps message when a bundled child extension failed to install. A fail-open manifest verifier confirms every child extension landed in `#__extensions` and reports any that are missing. + ### Added - **Repository** -- initial repo creation with scaffolding - **System Plugin** -- Extension class, service provider diff --git a/source/script.php b/source/script.php index 9ce2d9b..50fddcc 100644 --- a/source/script.php +++ b/source/script.php @@ -16,9 +16,104 @@ class Pkg_MokoSuiteFieldInstallerScript { public function postflight(string $type, InstallerAdapter $adapter): void { + // Be honest about success. Joomla's package installer only LOGS a failed child + // sub-install but still runs this postflight, so don't show the license / + // next-steps message if a bundled extension is actually missing. Fails open + // (see missingChildExtensions) so a query/IO glitch never fakes a failure. + $missing = $this->missingChildExtensions($adapter); + + if (!empty($missing)) + { + Factory::getApplication()->enqueueMessage( + '

MokoSuiteField did not install correctly.

' + . '

The following bundled extensions are missing: ' + . htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '

' + . '

Please uninstall MokoSuiteField and reinstall the full package.

', + 'error' + ); + + return; + } + $this->warnMissingLicenseKey(); } + /** + * Verify every child extension declared in the package manifest actually landed in + * #__extensions. Returns readable labels of any that are missing. + * + * Matching per Joomla's #__extensions uniqueness: type = "type"; element = + * "id" (for plugins, strip a leading plg__); plugins also match + * folder = "group". + * + * FAILS OPEN: any error returns [] so a transient glitch never fakes a failure. + */ + private function missingChildExtensions($adapter): array + { + try + { + $manifest = $adapter->getParent()->getManifest(); + + if (!$manifest || !isset($manifest->files) || !isset($manifest->files->file)) + { + return []; + } + + $db = Factory::getDbo(); + $missing = []; + + foreach ($manifest->files->file as $file) + { + $attrs = $file->attributes(); + $id = isset($attrs['id']) ? (string) $attrs['id'] : ''; + $exType = isset($attrs['type']) ? (string) $attrs['type'] : ''; + + if ($id === '' || $exType === '') + { + continue; + } + + $group = isset($attrs['group']) ? (string) $attrs['group'] : ''; + $element = $id; + + // Plugin element in #__extensions is the id minus any leading plg__. + if ($exType === 'plugin' && $group !== '') + { + $prefix = 'plg_' . $group . '_'; + + if (strpos($element, $prefix) === 0) + { + $element = substr($element, \strlen($prefix)); + } + } + + $query = $db->getQuery(true) + ->select('COUNT(*)') + ->from($db->quoteName('#__extensions')) + ->where($db->quoteName('element') . ' = ' . $db->quote($element)) + ->where($db->quoteName('type') . ' = ' . $db->quote($exType)); + + if ($exType === 'plugin' && $group !== '') + { + $query->where($db->quoteName('folder') . ' = ' . $db->quote($group)); + } + + if ((int) $db->setQuery($query)->loadResult() === 0) + { + $label = trim((string) $file); + $missing[] = $label !== '' ? preg_replace('/\.zip$/i', '', $label) : $id; + } + } + + return $missing; + } + catch (\Throwable $e) + { + // Fail open — never fake a failure on a glitch. + return []; + } + } + private function warnMissingLicenseKey(): void { try -- 2.52.0 From 4212ce1ded78d5de9dc92fede02b83c9de75a05a Mon Sep 17 00:00:00 2001 From: "gitea-actions[bot]" Date: Mon, 6 Jul 2026 16:20:48 +0000 Subject: [PATCH 2/2] chore(version): pre-release bump to 06.00.21-dev [skip ci] --- .mokogitea/workflows/issue-branch.yml | 2 +- source/packages/com_mokosuitefield/mokosuitefield.xml | 2 +- source/packages/plg_system_mokosuitefield/mokosuitefield.xml | 2 +- .../packages/plg_webservices_mokosuitefield/mokosuitefield.xml | 2 +- source/pkg_mokosuitefield.xml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.mokogitea/workflows/issue-branch.yml b/.mokogitea/workflows/issue-branch.yml index 8ebe99d..64dade7 100644 --- a/.mokogitea/workflows/issue-branch.yml +++ b/.mokogitea/workflows/issue-branch.yml @@ -5,7 +5,7 @@ # FILE INFORMATION # DEFGROUP: Gitea.Workflow # INGROUP: mokocli.Automation -# VERSION: 06.00.19 +# VERSION: 06.00.21 # BRIEF: Auto-create feature branch when an issue is opened name: "Universal: Issue Branch" diff --git a/source/packages/com_mokosuitefield/mokosuitefield.xml b/source/packages/com_mokosuitefield/mokosuitefield.xml index 898aff7..5b08055 100644 --- a/source/packages/com_mokosuitefield/mokosuitefield.xml +++ b/source/packages/com_mokosuitefield/mokosuitefield.xml @@ -5,7 +5,7 @@ 2026-06-27 Copyright (C) 2026 Moko Consulting. GPL-3.0-or-later - 06.00.19 + 06.00.21 Moko\Component\MokoSuiteField servicessrctmpl diff --git a/source/packages/plg_system_mokosuitefield/mokosuitefield.xml b/source/packages/plg_system_mokosuitefield/mokosuitefield.xml index 532e8f9..82ce757 100644 --- a/source/packages/plg_system_mokosuitefield/mokosuitefield.xml +++ b/source/packages/plg_system_mokosuitefield/mokosuitefield.xml @@ -8,7 +8,7 @@ GPL-3.0-or-later hello@mokoconsulting.tech https://mokoconsulting.tech - 06.00.19 + 06.00.21 8.3 PLG_SYSTEM_MOKOSUITEFIELD_DESC Moko\Plugin\System\MokoSuiteField diff --git a/source/packages/plg_webservices_mokosuitefield/mokosuitefield.xml b/source/packages/plg_webservices_mokosuitefield/mokosuitefield.xml index c435113..11f3fa9 100644 --- a/source/packages/plg_webservices_mokosuitefield/mokosuitefield.xml +++ b/source/packages/plg_webservices_mokosuitefield/mokosuitefield.xml @@ -3,7 +3,7 @@ Web Services - MokoSuite Field mokosuitefield Moko Consulting - 06.00.19 + 06.00.21 GPL-3.0-or-later Moko\Plugin\WebServices\MokoSuiteField srcservices diff --git a/source/pkg_mokosuitefield.xml b/source/pkg_mokosuitefield.xml index aa4b966..024506f 100644 --- a/source/pkg_mokosuitefield.xml +++ b/source/pkg_mokosuitefield.xml @@ -2,7 +2,7 @@ Package - MokoSuite Field mokosuitefield - 06.00.19 + 06.00.21 2026-06-27 Moko Consulting hello@mokoconsulting.tech -- 2.52.0