Compare commits
10 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 196d237e9f | |||
| 3cd9767997 | |||
| dd7b089d30 | |||
| 2585d54018 | |||
| 9309500fe5 | |||
| 552d31aaec | |||
| 8167223c92 | |||
| b3bb63c8dc | |||
| 4212ce1ded | |||
| 0e3c922b7a |
@@ -5,7 +5,7 @@
|
||||
# FILE INFORMATION
|
||||
# DEFGROUP: Gitea.Workflow
|
||||
# INGROUP: mokocli.Automation
|
||||
# VERSION: 06.00.19
|
||||
# VERSION: 06.00.25
|
||||
# BRIEF: Auto-create feature branch when an issue is opened
|
||||
|
||||
name: "Universal: Issue Branch"
|
||||
|
||||
@@ -11,6 +11,9 @@
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
### Fixed
|
||||
- **Honest install success** — the package installer no longer shows the license / next-steps message when a bundled child extension failed to install. A fail-open manifest verifier confirms every child extension landed in `#__extensions` and reports any that are missing.
|
||||
|
||||
### Added
|
||||
- **Repository** -- initial repo creation with scaffolding
|
||||
- **System Plugin** -- Extension class, service provider
|
||||
|
||||
@@ -3,6 +3,7 @@
|
||||
; Authored-by: Moko Consulting
|
||||
|
||||
COM_MOKOSUITEFIELD="MokoSuite Field"
|
||||
COM_MOKOSUITEFIELD_SHORT="Field"
|
||||
COM_MOKOSUITEFIELD_DESCRIPTION="Field service management for contractors."
|
||||
COM_MOKOSUITEFIELD_MENU_DASHBOARD="Dashboard"
|
||||
COM_MOKOSUITEFIELD_MENU_WORKORDERS="Work Orders"
|
||||
|
||||
@@ -5,10 +5,10 @@
|
||||
<creationDate>2026-06-27</creationDate>
|
||||
<copyright>Copyright (C) 2026 Moko Consulting.</copyright>
|
||||
<license>GPL-3.0-or-later</license>
|
||||
<version>06.00.19</version>
|
||||
<version>06.00.25</version>
|
||||
<namespace path="src">Moko\Component\MokoSuiteField</namespace>
|
||||
<administration>
|
||||
<files folder="admin"><folder>services</folder><folder>src</folder><folder>tmpl</folder></files>
|
||||
<menu>COM_MOKOSUITEFIELD</menu>
|
||||
<menu>COM_MOKOSUITEFIELD_SHORT</menu>
|
||||
</administration>
|
||||
</extension>
|
||||
|
||||
@@ -8,7 +8,7 @@
|
||||
<license>GPL-3.0-or-later</license>
|
||||
<authorEmail>hello@mokoconsulting.tech</authorEmail>
|
||||
<authorUrl>https://mokoconsulting.tech</authorUrl>
|
||||
<version>06.00.19</version>
|
||||
<version>06.00.25</version>
|
||||
<php_minimum>8.3</php_minimum>
|
||||
<description>PLG_SYSTEM_MOKOSUITEFIELD_DESC</description>
|
||||
<namespace path="src">Moko\Plugin\System\MokoSuiteField</namespace>
|
||||
|
||||
@@ -3,7 +3,7 @@
|
||||
<name>Web Services - MokoSuite Field</name>
|
||||
<element>mokosuitefield</element>
|
||||
<author>Moko Consulting</author>
|
||||
<version>06.00.19</version>
|
||||
<version>06.00.25</version>
|
||||
<license>GPL-3.0-or-later</license>
|
||||
<namespace path="src">Moko\Plugin\WebServices\MokoSuiteField</namespace>
|
||||
<files><folder>src</folder><folder>services</folder></files>
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
<extension type="package" method="upgrade">
|
||||
<name>Package - MokoSuite Field</name>
|
||||
<packagename>mokosuitefield</packagename>
|
||||
<version>06.00.19</version>
|
||||
<version>06.00.25</version>
|
||||
<creationDate>2026-06-27</creationDate>
|
||||
<author>Moko Consulting</author>
|
||||
<authorEmail>hello@mokoconsulting.tech</authorEmail>
|
||||
|
||||
@@ -16,9 +16,104 @@ class Pkg_MokoSuiteFieldInstallerScript
|
||||
{
|
||||
public function postflight(string $type, InstallerAdapter $adapter): void
|
||||
{
|
||||
// Be honest about success. Joomla's package installer only LOGS a failed child
|
||||
// sub-install but still runs this postflight, so don't show the license /
|
||||
// next-steps message if a bundled extension is actually missing. Fails open
|
||||
// (see missingChildExtensions) so a query/IO glitch never fakes a failure.
|
||||
$missing = $this->missingChildExtensions($adapter);
|
||||
|
||||
if (!empty($missing))
|
||||
{
|
||||
Factory::getApplication()->enqueueMessage(
|
||||
'<h4>MokoSuiteField did not install correctly.</h4>'
|
||||
. '<p>The following bundled extensions are missing: '
|
||||
. htmlspecialchars(implode(', ', $missing), ENT_QUOTES) . '</p>'
|
||||
. '<p>Please uninstall MokoSuiteField and reinstall the full package.</p>',
|
||||
'error'
|
||||
);
|
||||
|
||||
return;
|
||||
}
|
||||
|
||||
$this->warnMissingLicenseKey();
|
||||
}
|
||||
|
||||
/**
|
||||
* Verify every child extension declared in the package manifest actually landed in
|
||||
* #__extensions. Returns readable labels of any that are missing.
|
||||
*
|
||||
* Matching per Joomla's #__extensions uniqueness: type = <file> "type"; element =
|
||||
* <file> "id" (for plugins, strip a leading plg_<group>_); plugins also match
|
||||
* folder = <file> "group".
|
||||
*
|
||||
* FAILS OPEN: any error returns [] so a transient glitch never fakes a failure.
|
||||
*/
|
||||
private function missingChildExtensions($adapter): array
|
||||
{
|
||||
try
|
||||
{
|
||||
$manifest = $adapter->getParent()->getManifest();
|
||||
|
||||
if (!$manifest || !isset($manifest->files) || !isset($manifest->files->file))
|
||||
{
|
||||
return [];
|
||||
}
|
||||
|
||||
$db = Factory::getDbo();
|
||||
$missing = [];
|
||||
|
||||
foreach ($manifest->files->file as $file)
|
||||
{
|
||||
$attrs = $file->attributes();
|
||||
$id = isset($attrs['id']) ? (string) $attrs['id'] : '';
|
||||
$exType = isset($attrs['type']) ? (string) $attrs['type'] : '';
|
||||
|
||||
if ($id === '' || $exType === '')
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
$group = isset($attrs['group']) ? (string) $attrs['group'] : '';
|
||||
$element = $id;
|
||||
|
||||
// Plugin element in #__extensions is the id minus any leading plg_<group>_.
|
||||
if ($exType === 'plugin' && $group !== '')
|
||||
{
|
||||
$prefix = 'plg_' . $group . '_';
|
||||
|
||||
if (strpos($element, $prefix) === 0)
|
||||
{
|
||||
$element = substr($element, \strlen($prefix));
|
||||
}
|
||||
}
|
||||
|
||||
$query = $db->getQuery(true)
|
||||
->select('COUNT(*)')
|
||||
->from($db->quoteName('#__extensions'))
|
||||
->where($db->quoteName('element') . ' = ' . $db->quote($element))
|
||||
->where($db->quoteName('type') . ' = ' . $db->quote($exType));
|
||||
|
||||
if ($exType === 'plugin' && $group !== '')
|
||||
{
|
||||
$query->where($db->quoteName('folder') . ' = ' . $db->quote($group));
|
||||
}
|
||||
|
||||
if ((int) $db->setQuery($query)->loadResult() === 0)
|
||||
{
|
||||
$label = trim((string) $file);
|
||||
$missing[] = $label !== '' ? preg_replace('/\.zip$/i', '', $label) : $id;
|
||||
}
|
||||
}
|
||||
|
||||
return $missing;
|
||||
}
|
||||
catch (\Throwable $e)
|
||||
{
|
||||
// Fail open — never fake a failure on a glitch.
|
||||
return [];
|
||||
}
|
||||
}
|
||||
|
||||
private function warnMissingLicenseKey(): void
|
||||
{
|
||||
try
|
||||
|
||||
Reference in New Issue
Block a user