fix(heartbeat): add error logging, fix params persistence race

- Add Log::add() to empty catch blocks in sendHeartbeat(), checkHeartbeat(), and fetchLocalHealth() so failures are diagnosable - Add curl_error() check and non-2xx logging to script.php sendHeartbeat() - Replace $extension->store() with targeted DB update in checkHeartbeat() to avoid overwriting params modified by migrateMonitorParams()
2026-06-20 11:09:03 -05:00
parent 99f0901fd2
commit f1d483aa38
2 changed files with 33 additions and 9 deletions
@@ -946,16 +946,25 @@ class Pkg_MokosuiteclientInstallerScript

 			$response = curl_exec($ch);
 			$code     = (int) curl_getinfo($ch, CURLINFO_HTTP_CODE);
+			$error    = curl_error($ch);
 			curl_close($ch);

-			if ($code >= 200 && $code < 300)
+			if ($error)
+			{
+				Log::add('Heartbeat connection failed: ' . $error, Log::WARNING, 'mokosuiteclient');
+			}
+			elseif ($code >= 200 && $code < 300)
 			{
 				Factory::getApplication()->enqueueMessage('MokoSuiteClientHQ heartbeat: site registered', 'message');
 			}
+			else
+			{
+				Log::add(sprintf('Heartbeat HTTP %d: %s', $code, $response), Log::WARNING, 'mokosuiteclient');
+			}
 		}
 		catch (\Throwable $e)
 		{
-			// Silent failure — heartbeat is non-critical
+			Log::add('Heartbeat failed: ' . $e->getMessage(), Log::WARNING, 'mokosuiteclient');
 		}
 	}