From 1a1c81550c569267caf97097ea7baeeb6716f6cf Mon Sep 17 00:00:00 2001
From: Jonathan Miller <jmiller@mokoconsulting.tech>
Date: Sun, 5 Jul 2026 18:57:42 -0500
Subject: [PATCH 1/2] fix(plugin): pre-update backup notifies on success too,
 not only failure

runPreActionBackup() only enqueued a message when the backup failed, so a
successful pre-update backup produced no admin notification at all. Now it
surfaces every outcome via the BackupRunner status: complete -> success,
warning (archive made but remote upload failed) -> warning, fail -> error.

Refs #192

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
---
 CHANGELOG.md                                  |  3 +++
 .../src/Extension/MokoSuiteBackup.php         | 22 ++++++++++++++++---
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 04932f5d..54a38afe 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## [Unreleased]
 
+### Fixed
+- Pre-update backup now shows an admin notification on **every** outcome (success / warning / failure) — previously a *successful* pre-update backup fired nothing, so it looked like the notification wasn't working. (#192)
+
 ### Changed
 - Component admin CSS now loads via the Joomla **Web Asset Manager** (`media/com_mokosuitebackup/` + `joomla.asset.json`) instead of an inline `<style>` block.
 - "Keep local copy" is configured **per remote destination** (in the Add/Edit Destination modal); the redundant profile-level field and its "Remote" tab are removed.
diff --git a/source/packages/plg_system_mokosuitebackup/src/Extension/MokoSuiteBackup.php b/source/packages/plg_system_mokosuitebackup/src/Extension/MokoSuiteBackup.php
index 30864e73..1a97838f 100644
--- a/source/packages/plg_system_mokosuitebackup/src/Extension/MokoSuiteBackup.php
+++ b/source/packages/plg_system_mokosuitebackup/src/Extension/MokoSuiteBackup.php
@@ -390,12 +390,28 @@ final class MokoSuiteBackup extends CMSPlugin implements SubscriberInterface
 
 		try {
 			$result = (new BackupRunner())->run($profileId, $description, 'preaction');
+			$app    = Factory::getApplication();
+			$status = $result['status'] ?? (!empty($result['success']) ? 'complete' : 'fail');
 
-			if (!$result['success']) {
-				Factory::getApplication()->enqueueMessage(
-					'MokoSuiteBackup: ' . $description . ' failed — ' . $result['message'],
+			/* Always surface the outcome so the pre-update backup is visible in the
+			   admin — previously only failures produced a message, so a successful
+			   pre-update backup fired no notification at all. */
+			if ($status === 'warning') {
+				$app->enqueueMessage(
+					'MokoSuiteBackup: ' . $description . ' completed with warnings — '
+					. ($result['message'] ?: 'the local archive was created but a remote upload failed; see the backup log.'),
 					'warning'
 				);
+			} elseif ($status === 'fail' || empty($result['success'])) {
+				$app->enqueueMessage(
+					'MokoSuiteBackup: ' . $description . ' failed — ' . ($result['message'] ?: 'unknown error'),
+					'error'
+				);
+			} else {
+				$app->enqueueMessage(
+					'MokoSuiteBackup: ' . $description . ' completed successfully.',
+					'message'
+				);
 			}
 		} catch (\Throwable $e) {
 			error_log('MokoSuiteBackup: ' . $description . ' failed: ' . $e->getMessage());
-- 
2.52.0


From dfd4e77adeee06e35b3d2b5fcd86a2224b1b2751 Mon Sep 17 00:00:00 2001
From: "mokogitea-actions[bot]" <mokogitea-actions[bot]@mokoconsulting.tech>
Date: Sun, 5 Jul 2026 23:58:13 +0000
Subject: [PATCH 2/2] chore(version): pre-release bump to 02.57.09-dev [skip
 ci]

---
 .mokogitea/workflows/issue-branch.yml                           | 2 +-
 SECURITY.md                                                     | 2 +-
 source/packages/com_mokosuitebackup/mokosuitebackup.xml         | 2 +-
 .../packages/com_mokosuitebackup/sql/updates/mysql/02.57.09.sql | 1 +
 .../mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml   | 2 +-
 .../packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml  | 2 +-
 source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml | 2 +-
 source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml | 2 +-
 .../packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml  | 2 +-
 source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml  | 2 +-
 source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml    | 2 +-
 .../plg_webservices_mokosuitebackup/mokosuitebackup.xml         | 2 +-
 source/pkg_mokosuitebackup.xml                                  | 2 +-
 13 files changed, 13 insertions(+), 12 deletions(-)
 create mode 100644 source/packages/com_mokosuitebackup/sql/updates/mysql/02.57.09.sql

diff --git a/.mokogitea/workflows/issue-branch.yml b/.mokogitea/workflows/issue-branch.yml
index 2513dd4a..c6a0e771 100644
--- a/.mokogitea/workflows/issue-branch.yml
+++ b/.mokogitea/workflows/issue-branch.yml
@@ -5,7 +5,7 @@
 # FILE INFORMATION
 # DEFGROUP: MokoGitea.Workflow
 # INGROUP: mokocli.Automation
-# VERSION: 02.57.08
+# VERSION: 02.57.09
 # BRIEF: Auto-create feature branch when an issue is opened
 
 name: "Universal: Issue Branch"
diff --git a/SECURITY.md b/SECURITY.md
index 8f65f806..010f79ca 100644
--- a/SECURITY.md
+++ b/SECURITY.md
@@ -23,7 +23,7 @@ DEFGROUP: Template-Joomla
 INGROUP: Template-Joomla.Documentation
 REPO: https://git.mokoconsulting.tech/MokoConsulting/Template-Joomla
 PATH: /SECURITY.md
-VERSION: 02.57.08
+VERSION: 02.57.09
 BRIEF: Security vulnerability reporting and handling policy
 -->
 
diff --git a/source/packages/com_mokosuitebackup/mokosuitebackup.xml b/source/packages/com_mokosuitebackup/mokosuitebackup.xml
index f267c276..63045fba 100644
--- a/source/packages/com_mokosuitebackup/mokosuitebackup.xml
+++ b/source/packages/com_mokosuitebackup/mokosuitebackup.xml
@@ -17,7 +17,7 @@
 		display label there.
 	-->
 	<name>MokoSuiteBackup</name>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
diff --git a/source/packages/com_mokosuitebackup/sql/updates/mysql/02.57.09.sql b/source/packages/com_mokosuitebackup/sql/updates/mysql/02.57.09.sql
new file mode 100644
index 00000000..b6bf29bc
--- /dev/null
+++ b/source/packages/com_mokosuitebackup/sql/updates/mysql/02.57.09.sql
@@ -0,0 +1 @@
+/* 02.57.09 — no schema changes */
diff --git a/source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml b/source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml
index 0d55955d..e61f6106 100644
--- a/source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml
+++ b/source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml
@@ -8,7 +8,7 @@
  -->
 <extension type="module" client="administrator" method="upgrade">
 	<name>Module - MokoSuiteBackup - cPanel</name>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-23</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
diff --git a/source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml
index 9d55ebdf..8bcdf2be 100644
--- a/source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml
+++ b/source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml
@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="actionlog" method="upgrade">
 	<name>Action Log - MokoSuiteBackup</name>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
diff --git a/source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml
index 77676618..f9e389a7 100644
--- a/source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml
+++ b/source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml
@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="console" method="upgrade">
 	<name>Console - MokoSuiteBackup</name>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
diff --git a/source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml
index 4fa3063d..b0d45c6d 100644
--- a/source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml
+++ b/source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml
@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="content" method="upgrade">
 	<name>Content - MokoSuiteBackup</name>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-04</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
diff --git a/source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml
index 73398314..567eaff8 100644
--- a/source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml
+++ b/source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <extension type="plugin" group="quickicon" method="upgrade">
 	<name>Quick Icon - MokoSuiteBackup</name>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
diff --git a/source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml
index 167ec894..38f18f6d 100644
--- a/source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml
+++ b/source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml
@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="system" method="upgrade">
 	<name>System - MokoSuiteBackup</name>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
diff --git a/source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml
index 99d4f678..93147bb7 100644
--- a/source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml
+++ b/source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml
@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="task" method="upgrade">
 	<name>Task - MokoSuiteBackup</name>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
diff --git a/source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml
index f79cff11..74f7c25e 100644
--- a/source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml
+++ b/source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml
@@ -7,7 +7,7 @@
  -->
 <extension type="plugin" group="webservices" method="upgrade">
 	<name>Web Services - MokoSuiteBackup</name>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
diff --git a/source/pkg_mokosuitebackup.xml b/source/pkg_mokosuitebackup.xml
index a704753e..cbe31c85 100644
--- a/source/pkg_mokosuitebackup.xml
+++ b/source/pkg_mokosuitebackup.xml
@@ -8,7 +8,7 @@
 <extension type="package" method="upgrade">
 	<name>Package - MokoSuiteBackup</name>
 	<packagename>mokosuitebackup</packagename>
-	<version>02.57.08</version>
+	<version>02.57.09</version>
 	<creationDate>2026-06-02</creationDate>
 	<author>Moko Consulting</author>
 	<authorEmail>hello@mokoconsulting.tech</authorEmail>
-- 
2.52.0