MokoConsulting/MokoSuiteBackup
1
0
Fork 0
Code Issues 23 Pull Requests 1 Releases 2 Wiki Activity

Interrupted backups stay 'running' forever; End Time renders '-0001'; no log #307

New Issue
Open
opened 2026-07-18 20:17:37 +00:00 by jmiller · 1 comment
jmiller commented 2026-07-18 20:17:37 +00:00
Owner
Copy Link
Copy Source

Type: bug Priority: high Component: com_mokosuitebackup

Summary

When the driving window/CLI dies mid-run (closed tab, PHP timeout, killed cron), the record is orphaned in running with a null end time, appears as a phantom in-progress backup on the dashboard, shows (no log available), and — until the Cancel-Stalled fatal is fixed — could not be cleared.

The backup detail view also renders the null backupend (0000-00-00 00:00:00) as the bogus "Monday, November 29, -0001".

Fix (this PR)

  • BackupStatusHelper::markStalledAsFailed() flips running records older than a 1h threshold to fail; swept when the records list loads (the threshold spares genuinely in-flight scheduled/CLI backups, which run without the admin browser lock).
  • Detail view shows Not finished for a null/zero backupend.

Follow-up (not in this PR)

  • Persist a backup log even for interrupted runs, and add a real heartbeat column so the stalled-detection does not rely on start-time age.
**Type:** bug **Priority:** high **Component:** com_mokosuitebackup ### Summary When the driving window/CLI dies mid-run (closed tab, PHP timeout, killed cron), the record is orphaned in `running` with a null end time, appears as a phantom in-progress backup on the dashboard, shows `(no log available)`, and — until the Cancel-Stalled fatal is fixed — could not be cleared. The backup detail view also renders the null `backupend` (`0000-00-00 00:00:00`) as the bogus **"Monday, November 29, -0001"**. ### Fix (this PR) - `BackupStatusHelper::markStalledAsFailed()` flips `running` records older than a 1h threshold to `fail`; swept when the records list loads (the threshold spares genuinely in-flight scheduled/CLI backups, which run without the admin browser lock). - Detail view shows **Not finished** for a null/zero `backupend`. ### Follow-up (not in this PR) - Persist a backup log even for interrupted runs, and add a real heartbeat column so the stalled-detection does not rely on start-time age.
jmiller commented 2026-07-18 20:36:10 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/307-interrupted-backups-stay-running-forever

git fetch origin
git checkout feature/307-interrupted-backups-stay-running-forever
Branch created: [`feature/307-interrupted-backups-stay-running-forever`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteBackup/src/branch/feature/307-interrupted-backups-stay-running-forever) ```bash git fetch origin git checkout feature/307-interrupted-backups-stay-running-forever ```
Sign in to join this conversation.
Labels
Clear labels
component: admin
Admin UI and views
 component: api
REST API
 component: engine
Backup/restore engine
 component: remote
Remote storage (FTP/GDrive)
 component: scheduler
Scheduled tasks
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority Medium
Type Feature
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#307
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?